Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp118065iob; Tue, 17 May 2022 20:49:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycFYp1CRybBhJ0HQHhV60IoDtLHqBzpA1f9J8X8w0QeUOKW4yBbvuf2mLcQENVbz8mxe/s X-Received: by 2002:a17:902:f605:b0:154:aa89:bd13 with SMTP id n5-20020a170902f60500b00154aa89bd13mr25581568plg.112.1652845791827; Tue, 17 May 2022 20:49:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652845791; cv=none; d=google.com; s=arc-20160816; b=QxgN1Vq61TDBVpytHsM0U6RwtZEfgKV4OEq6snMcn67iEcZKUTp1ZLUw/ZB3xKlkYi y7wFDWYrT/1FQK5uCsolGyH0F5i+ju+LK+Fb6YXzrb3bD6Eo+tnxenBYvMbSTJnHI46h geBWYzIUyUz4+th/QQJjBHi11cbzwJKh4KjCr2QvjfY61hhBN7EzOeSnusIoMGCmfZES ucSekf9k3ZnFFjzr3PCai82KJEQCm/mlR5JE/9CvgvtgIwQsnefhpM7KJe+qhoEm+oq1 xF77qGSuwWCCstahexkrZJxm5nRpWY7DF1jkpXmP41k8XUugOsROTgcqVWN1g9JPyPMU lAiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=o3Jcn1iAarxojLmeUPOFMO73FT+c4hfJanwaPilfZzg=; b=k9zScNg8V7hiqWv2vQToTHlDM00BQ/j3nwXM7JKH4uDYszbOnCLcNS9qwbTasWS7PZ J/sJdVlQ5dBY64uYlxSvuS93Xr6RtVqYEnPJcOv66umoFPpcl/KkyQRXcWcbpJHDnJts hgLrF8F31XLS6X8adc22BuY3tJqm6n2HgzJqSWFSsT6QyMorJuCKl31Pi0vlXCUq5Fb/ opXcFoVDNFe91cD3plxoJgwyDMKt8tndQXuX+xcGyZXyOnxslqcfnlPNtoO3USUAoY7z ERAX3EyhOn82v+D8m8SG+LzGKBX6PbnidRTbCFxF1YtOGqZcMnrrPCZO7qvG8peAULwv shXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QqrrLB9f; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o6-20020a655206000000b003daeb3ad0e2si1112130pgp.170.2022.05.17.20.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 20:49:51 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QqrrLB9f; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AEBEA8A31D; Tue, 17 May 2022 20:32:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbiEQX1i (ORCPT + 99 others); Tue, 17 May 2022 19:27:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231715AbiEQX1h (ORCPT ); Tue, 17 May 2022 19:27:37 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F2693584C for ; Tue, 17 May 2022 16:27:36 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-2fed823dd32so6603657b3.12 for ; Tue, 17 May 2022 16:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o3Jcn1iAarxojLmeUPOFMO73FT+c4hfJanwaPilfZzg=; b=QqrrLB9fcAAqWfAdPHgvPg1TR8H44QppAqFbge8zxueoMw3Lc78YQjaMIqeRxQYjWy yEglKnCqd4+ukyd5esKDU04HjYYF9BJ8LclvkX/9OU/h+JmVwmnTsiyuc4j/BZVo4hVb kEuj9+XxADeB2pPPFs88jkAACTQbS6YqGGt8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o3Jcn1iAarxojLmeUPOFMO73FT+c4hfJanwaPilfZzg=; b=BMpBOVax3oCOHigc2Tv97EHZIdub561TkYrsT/GCLqsYSQ8GOiOJZiCRnzrC6Ts8Q2 2mRNgGC+k5PqqeT6qkccwx7NeUeBhkHT5Up0Ry/CNiZbNgteBs8M+278wNsEqJiZWtCJ dU/EeSAeEEuYvejWOIx2btIW71m5Qj1BFRfXPZlAqH1zWz0eyyMRk1pUeglL8PtJc9Du 5NzSP/Bth9QC3YL1feC0XKEKJejDQtXbCI485nHBMR1fp3ejhK6xOxfjgDCBBfyQbtH5 dYiRr2qn8CHJGdG3eIHelLh/Dv5lrn9bbx2d7waPkcTaEnrvhtvy8Tmay1nSWkoawhsM jsLg== X-Gm-Message-State: AOAM533syNE6H7thptEoq5eqzliih/FORXpkrUCew5XcHGngjwPRbWlG GcsRZ/zU2QsvAQYSiB7n6j+EQisYjsLH74Qk6y9BeQ== X-Received: by 2002:a81:604:0:b0:2e6:6b45:4812 with SMTP id 4-20020a810604000000b002e66b454812mr28130840ywg.266.1652830055463; Tue, 17 May 2022 16:27:35 -0700 (PDT) MIME-Version: 1.0 References: <20220511222910.635307-1-dlunev@chromium.org> <20220512082832.v2.2.I692165059274c30b59bed56940b54a573ccb46e4@changeid> In-Reply-To: From: Daniil Lunev Date: Wed, 18 May 2022 09:27:23 +1000 Message-ID: Subject: Re: [PATCH v2 2/2] FUSE: Retire superblock on force unmount To: Al Viro Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, fuse-devel@lists.sourceforge.net, tytso@mit.edu, miklos@szeredi.hu, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SCC_BODY_URI_ONLY,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Al, Here is my v1 version of the patch which does skip the node in testing super https://lore.kernel.org/linux-fsdevel/20220511013057.245827-1-dlunev@chromium.org/T/#u I am not particular which version is to be used. However note, it still needs to remove the bdi node since otherwise the new mount will have a conflict. The bdi put should not kill the bdi if it has more references (and then conflict would still occur, but chances of bdi being opened for a long time is low AFAIU), thus this should be safe, but I might be missing something. Note, that FUSE super block at the time is barely alive, it may have open filehandles/references, but the connection with user space is already cut and all of the ops would return transport error. Let me know what you think and how we can address it better maybe? Thanks, Daniil