Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <CGME20220509073953epcas1p127f2d36186316642068c92c5d9dee1c4@epcas1p1.samsung.com>
 <20220509074330.4822-1-jaewon31.kim@samsung.com> <20220516173321.67402b7f09eacc43d4e476f4@linux-foundation.org>
 <YoNcBG6kQnmLZ3Z9@linux.ibm.com>
In-Reply-To: <YoNcBG6kQnmLZ3Z9@linux.ibm.com>
From:   Jaewon Kim <jaewon31.kim@gmail.com>
Date:   Tue, 17 May 2022 20:38:18 +0900
Message-ID: <CAJrd-UuzTh-0Ee9+rMRES9onP_EkvJS-VpPP66J4M4n0Ku0ZWA@mail.gmail.com>
Subject: Re: [RFC PATCH] page_ext: create page extension for all memblock
 memory regions
To:     Mike Rapoport <rppt@linux.ibm.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jaewon Kim <jaewon31.kim@samsung.com>,
        Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Mike Rapoport
Thank you for your comment.

Oh really? Could you point out the code or the commit regarding 'all
struct pages in any section should be valid and
properly initialized' ?

Actually I am using v5.10 based source tree on an arm64 device.
I tried to look up and found the following commit in v5.16-rc1, did
you mean this?
3de360c3fdb3 arm64/mm: drop HAVE_ARCH_PFN_VALID

I guess memblock_is_memory code in pfn_valid in arch/arm64/mm/init.c, v5.10
might affect the page_ext_init.

Thank you

2022=EB=85=84 5=EC=9B=94 17=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 5:25, M=
ike Rapoport <rppt@linux.ibm.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On Mon, May 16, 2022 at 05:33:21PM -0700, Andrew Morton wrote:
> > On Mon,  9 May 2022 16:43:30 +0900 Jaewon Kim <jaewon31.kim@samsung.com=
> wrote:
> >
> > > The page extension can be prepared for each section. But if the first
> > > page is not valid, the page extension for the section was not
> > > initialized though there were many other valid pages within the secti=
on.
>
> What do you mean by "first page [in a section] is not valid"?
> In recent kernels all struct pages in any section should be valid and
> properly initialized.
>
> > > To support the page extension for all sections, refer to memblock mem=
ory
> > > regions. If the page is valid use the nid from pfn_to_nid, otherwise =
use
> > > the previous nid.
> > >
> > > Also this pagech changed log to include total sections and a section
> > > size.
> > >
> > > i.e.
> > > allocated 100663296 bytes of page_ext for 64 sections (1 section : 0x=
8000000)
> >
> > Cc Joonsoo, who wrote this code.
> > Cc Mike, for memblock.
> >
> > Thanks.
> >
> > >
> > > diff --git a/mm/page_ext.c b/mm/page_ext.c
> > > index 2e66d934d63f..506d58b36a1d 100644
> > > --- a/mm/page_ext.c
> > > +++ b/mm/page_ext.c
> > > @@ -381,41 +381,43 @@ static int __meminit page_ext_callback(struct n=
otifier_block *self,
> > >  void __init page_ext_init(void)
> > >  {
> > >     unsigned long pfn;
> > > -   int nid;
> > > +   int nid =3D 0;
> > > +   struct memblock_region *rgn;
> > > +   int nr_section =3D 0;
> > > +   unsigned long next_section_pfn =3D 0;
> > >
> > >     if (!invoke_need_callbacks())
> > >             return;
> > >
> > > -   for_each_node_state(nid, N_MEMORY) {
> > > +   /*
> > > +    * iterate each memblock memory region and do not skip a section =
having
> > > +    * !pfn_valid(pfn)
> > > +    */
> > > +   for_each_mem_region(rgn) {
> > >             unsigned long start_pfn, end_pfn;
> > >
> > > -           start_pfn =3D node_start_pfn(nid);
> > > -           end_pfn =3D node_end_pfn(nid);
> > > -           /*
> > > -            * start_pfn and end_pfn may not be aligned to SECTION an=
d the
> > > -            * page->flags of out of node pages are not initialized. =
 So we
> > > -            * scan [start_pfn, the biggest section's pfn < end_pfn) =
here.
> > > -            */
> > > +           start_pfn =3D (unsigned long)(rgn->base >> PAGE_SHIFT);
> > > +           end_pfn =3D start_pfn + (unsigned long)(rgn->size >> PAGE=
_SHIFT);
> > > +
> > > +           if (start_pfn < next_section_pfn)
> > > +                   start_pfn =3D next_section_pfn;
> > > +
> > >             for (pfn =3D start_pfn; pfn < end_pfn;
> > >                     pfn =3D ALIGN(pfn + 1, PAGES_PER_SECTION)) {
> > >
> > > -                   if (!pfn_valid(pfn))
> > > -                           continue;
> > > -                   /*
> > > -                    * Nodes's pfns can be overlapping.
> > > -                    * We know some arch can have a nodes layout such=
 as
> > > -                    * -------------pfn-------------->
> > > -                    * N0 | N1 | N2 | N0 | N1 | N2|....
> > > -                    */
> > > -                   if (pfn_to_nid(pfn) !=3D nid)
> > > -                           continue;
> > > +                   if (pfn_valid(pfn))
> > > +                           nid =3D pfn_to_nid(pfn);
> > > +                   nr_section++;
> > >                     if (init_section_page_ext(pfn, nid))
> > >                             goto oom;
> > >                     cond_resched();
> > >             }
> > > +           next_section_pfn =3D pfn;
> > >     }
> > > +
> > >     hotplug_memory_notifier(page_ext_callback, 0);
> > > -   pr_info("allocated %ld bytes of page_ext\n", total_usage);
> > > +   pr_info("allocated %ld bytes of page_ext for %d sections (1 secti=
on : 0x%x)\n",
> > > +           total_usage, nr_section, (1 << SECTION_SIZE_BITS));
> > >     invoke_init_callbacks();
> > >     return;
> > >
> > > --
> > > 2.17.1
> > >
>
> --
> Sincerely yours,
> Mike.