Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 17 May 2022 17:24:43 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Roman Gushchin <roman.gushchin@linux.dev>
Cc:     Michal =?ISO-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>,
        void@manifault.com, cgroups@vger.kernel.org, hannes@cmpxchg.org,
        kernel-team@fb.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, mhocko@kernel.org, shakeelb@google.com,
        tj@kernel.org, Richard Palethorpe <rpalethorpe@suse.de>
Subject: Re: [PATCH 4/4] selftests: memcg: Remove protection from top level
 memcg
Message-Id: <20220517172443.3e524a8319c693ab24c5f22e@linux-foundation.org>
In-Reply-To: <Yn6qrHHS935ppX98@carbon>
References: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com>
        <20220513171811.730-1-mkoutny@suse.com>
        <20220513171811.730-5-mkoutny@suse.com>
        <Yn6qrHHS935ppX98@carbon>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 13 May 2022 11:59:56 -0700 Roman Gushchin <roman.gushchin@linux.dev=
> wrote:

> On Fri, May 13, 2022 at 07:18:11PM +0200, Michal Koutny wrote:
> > The reclaim is triggered by memory limit in a subtree, therefore the
> > testcase does not need configured protection against external reclaim.
> >=20
> > Also, correct/deduplicate respective comments
> >=20
> > Signed-off-by: Michal Koutn=FD <mkoutny@suse.com>
> > ---
> >  tools/testing/selftests/cgroup/test_memcontrol.c | 12 ++++--------
> >  1 file changed, 4 insertions(+), 8 deletions(-)
> >=20
> > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/t=
esting/selftests/cgroup/test_memcontrol.c
> > index 9ffacf024bbd..9d370aafd799 100644
> > --- a/tools/testing/selftests/cgroup/test_memcontrol.c
> > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c
> > @@ -247,7 +247,7 @@ static int cg_test_proc_killed(const char *cgroup)
> > =20
> >  /*
> >   * First, this test creates the following hierarchy:
> > - * A       memory.min =3D 50M,  memory.max =3D 200M
> > + * A       memory.min =3D 0,    memory.max =3D 200M
> >   * A/B     memory.min =3D 50M,  memory.current =3D 50M
> >   * A/B/C   memory.min =3D 75M,  memory.current =3D 50M
> >   * A/B/D   memory.min =3D 25M,  memory.current =3D 50M
> > @@ -257,7 +257,7 @@ static int cg_test_proc_killed(const char *cgroup)
> >   * Usages are pagecache, but the test keeps a running
> >   * process in every leaf cgroup.
> >   * Then it creates A/G and creates a significant
> > - * memory pressure in it.
> > + * memory pressure in A.
> >   *
> >   * A/B    memory.current ~=3D 50M
> >   * A/B/C  memory.current ~=3D 29M
> > @@ -335,8 +335,6 @@ static int test_memcg_min(const char *root)
> >  			      (void *)(long)fd);
> >  	}
> > =20
> > -	if (cg_write(parent[0], "memory.min", "50M"))
> > -		goto cleanup;
> >  	if (cg_write(parent[1], "memory.min", "50M"))
> >  		goto cleanup;
> >  	if (cg_write(children[0], "memory.min", "75M"))
> > @@ -404,8 +402,8 @@ static int test_memcg_min(const char *root)
> > =20
> >  /*
> >   * First, this test creates the following hierarchy:
> > - * A       memory.low =3D 50M,  memory.max =3D 200M
> > - * A/B     memory.low =3D 50M,  memory.current =3D 50M
> > + * A       memory.low =3D 0,    memory.max =3D 200M
> > + * A/B     memory.low =3D 50M,  memory.current =3D ...
>=20
> Can you, please, just remove "memory.current =3D ...", it's not
> because obvious what "..." means here.
>=20

You mean this?

--- a/tools/testing/selftests/cgroup/test_memcontrol.c~selftests-memcg-remo=
ve-protection-from-top-level-memcg-fix
+++ a/tools/testing/selftests/cgroup/test_memcontrol.c
@@ -403,15 +403,14 @@ cleanup:
 /*
  * First, this test creates the following hierarchy:
  * A       memory.low =3D 0,    memory.max =3D 200M
- * A/B     memory.low =3D 50M,  memory.current =3D ...
+ * A/B     memory.low =3D 50M
  * A/B/C   memory.low =3D 75M,  memory.current =3D 50M
  * A/B/D   memory.low =3D 25M,  memory.current =3D 50M
  * A/B/E   memory.low =3D 0,    memory.current =3D 50M
  * A/B/F   memory.low =3D 500M, memory.current =3D 0
  *
  * Usages are pagecache.
- * Then it creates A/G an creates a significant
- * memory pressure in it.
+ * Then it creates A/G and creates significant memory pressure in it.
  *
  * Then it checks actual memory usages and expects that:
  * A/B    memory.current ~=3D 50M
_

(includes gratuitous comment cleanup)

I assume your comment in
https://lkml.kernel.org/r/Yn6pBPq+lAXm9NG8@carbon can be addressed in a
later patch.

I'm not sure what to amke of https://lkml.kernel.org/r/Yn6pWPodGPlz+D8G@car=
bon

Do we feel this series needs more work before merging it up?