Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220516170306.6008-1-makvihas@gmail.com> <20220516170306.6008-3-makvihas@gmail.com>
 <7b926f43-8c6b-6eae-edc6-02dc16376eb0@gmail.com>
In-Reply-To: <7b926f43-8c6b-6eae-edc6-02dc16376eb0@gmail.com>
From:   Vihas Makwana <makvihas@gmail.com>
Date:   Tue, 17 May 2022 19:21:47 +0530
Message-ID: <CAH1kMwTM9oT+wr7D7km68LXYWxs1TvsjhsFizq9Bm2juvQpJyg@mail.gmail.com>
Subject: Re: [PATCH 2/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_pwrctrl
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Dan Carpenter <dan.carpenter@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 17, 2022 at 1:15 AM Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> Hi Vihas,
>
> On 5/16/22 20:03, Vihas Makwana wrote:
> > Refactor the code to fix following warnings:
> >      WARNING: Comparisons should place the constant on the right side of the test
> >
> > Signed-off-by: Vihas Makwana <makvihas@gmail.com>
> > ---
>
> [code snip]
>
> >               if ((pwrpriv->smart_ps == smart_ps) &&
> > @@ -356,7 +356,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
> >
> >       pwrctrlpriv->LpsIdleCount = 0;
> >       pwrctrlpriv->power_mgnt = padapter->registrypriv.power_mgnt;/*  PS_MODE_MIN; */
> > -     pwrctrlpriv->bLeisurePs = PS_MODE_ACTIVE != pwrctrlpriv->power_mgnt;
> > +     pwrctrlpriv->bLeisurePs =  pwrctrlpriv->power_mgnt != PS_MODE_ACTIVE;
> >
>
> Please remove extra space
>
Oh sorry, my bad. Will submit a v2.
>
>
> With regards,
> Pavel Skripkin


-- 
Thanks,
Vihas