Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp129970iob; Tue, 17 May 2022 21:14:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjMD8U0HuJzatiS6Cgq/GBQUiaMdp5WSGY5NXjRTGldqm5mx1EH3riWE+NxsjhQinZpXEb X-Received: by 2002:a17:902:b289:b0:161:872d:6f03 with SMTP id u9-20020a170902b28900b00161872d6f03mr11339524plr.30.1652847255636; Tue, 17 May 2022 21:14:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652847255; cv=none; d=google.com; s=arc-20160816; b=xSO+GNA/fkvH4yX07sbAVAkaZeIXa9Ro9ZST/UXwscVKxcYU/7dYlu/ghzsv3Pj9U3 5vevCQA73QteJ8l6iwhAk8JWHeTtgkJvfUOZzhdCHP4KyucPOII0URzKT9nab7LnQSBg no3uSHCclZtVXtBOJM4EJymK6I9QW8LIzTLAGA5yUyjtMt2csjXcSyrECF1fdqeTeDeP tIRWX+b5xd9YK0d7quGI5yYg5u8yADyoduaLHFS1TQD0C1XcHaWMUFVdKPxIVGgxp/JA a1gVvE1AvwCVMRcgnneJwYf+LTWUx7imAXSKOBfp/Myu7HSRCFFhZBZeq7NFxnUI5WjS RqAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1j8CfhRp2BNkwVrsFdXtwV+6sxNYFap84vpkj/InTXw=; b=YViqxpLkPQWrHtRe4jt1YwkKqClKxv6lXDrqeTDe8UbSHSq2VB2+qrl0zce8khLQIj UWwfSUjqL2MBDULphHKLloH7R6TmJYDhzCZm+lP803NKy+dY5ZxiYuphLcPoorcmzWNM lPSS4PZXs5ARIg8aGcVG7eeOZoU/2N2/2zC4uYn3xNjTtfcAHqNiwjb6zBRV++QynGp3 nGmb/aHAwy+x/yHjMdSj4gZxOfxV+m+DUH9KNlQR0RvQnXtP6T3paSP5q5CGom0Yb2YS j2Xgcs1uwixIagQBHyrmdq0pwbinBJ6w9WgGLxQE+ot7rql94vMX/Jkw8wWfJNb1RsKQ a57Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id bh8-20020a056a02020800b003aafd468f3asi1076619pgb.469.2022.05.17.21.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 21:14:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B33845E74C; Tue, 17 May 2022 20:43:51 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347086AbiEQNXr (ORCPT + 99 others); Tue, 17 May 2022 09:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347577AbiEQNXn (ORCPT ); Tue, 17 May 2022 09:23:43 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1681433B3; Tue, 17 May 2022 06:23:36 -0700 (PDT) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4L2cGt2kLfzgYBP; Tue, 17 May 2022 21:22:14 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 17 May 2022 21:23:34 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 17 May 2022 21:23:34 +0800 From: Yang Yingliang To: , , , CC: , , , , Subject: [PATCH -next] cpufreq: mediatek: fix error return code in mtk_cpu_dvfs_info_init() Date: Tue, 17 May 2022 21:34:50 +0800 Message-ID: <20220517133450.2266243-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If regulator_get_voltage() fails, it should return the error code in mtk_cpu_dvfs_info_init(). Fixes: 0daa47325bae ("cpufreq: mediatek: Link CCI device to CPU") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/cpufreq/mediatek-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c index 37a1eb20f5ba..3a2be4552020 100644 --- a/drivers/cpufreq/mediatek-cpufreq.c +++ b/drivers/cpufreq/mediatek-cpufreq.c @@ -474,6 +474,7 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu) if (info->soc_data->ccifreq_supported) { info->vproc_on_boot = regulator_get_voltage(info->proc_reg); if (info->vproc_on_boot < 0) { + ret = info->vproc_on_boot; dev_err(info->cpu_dev, "invalid Vproc value: %d\n", info->vproc_on_boot); goto out_disable_inter_clock; -- 2.25.1