Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <a33ab7b9-738f-db91-f6ba-78a9641365e8@amd.com>
Date:   Tue, 17 May 2022 10:13:17 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context
Content-Language: en-US
From:   Andrey Grodzovsky <andrey.grodzovsky@amd.com>
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Erico Nunes <nunes.erico@gmail.com>,
        Steven Price <steven.price@arm.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Rob Herring <robh@kernel.org>,
        Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
        Rob Clark <robdclark@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
References: <20220411221536.283312-1-dmitry.osipenko@collabora.com>
 <a78343c8-2a6d-b223-4219-6b6b0a4fcb1f@arm.com>
 <CAK4VdL2hCEoshWZbCh5mkHuS6wYMiPFR3v4MWTnrEKM9zyv6Mw@mail.gmail.com>
 <ef88ec2c-77b5-fa0d-49d1-fdd2451713b7@collabora.com>
 <573fae0d-c9ab-98b0-c6f1-5b0d4e52dd01@amd.com>
In-Reply-To: <573fae0d-c9ab-98b0-c6f1-5b0d4e52dd01@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NElxU0NHelEvRVRabHNsREgvV1RCV2E0V0s2dW1OOHphU055VHZLTEZYdWNY?=
 =?utf-8?B?YXhKT29jT2Z3OXpLZ2NVdnRQaTJKNUIra0ZnbklrR3pXUDRrZDc0SW9uWXNh?=
 =?utf-8?B?ZUk0bksrUThvbjJBaWdtUFp5MW9ZK0lLZnkwNU55TGVSWE40ZS9MQW9ldGhk?=
 =?utf-8?B?dW83eCsxbVBDQlZVK3V0cnJ2cGl0WEhENWxRNFFXMnZsU3lwTVo2K3dMTWtS?=
 =?utf-8?B?RUhJeEIvZzNBMXNsditpcUZYQ3lId0V5cW5RanZvQ09OMk1BTnJJZm14YWdy?=
 =?utf-8?B?SmttbGpNb1I1c1ZnV0VQcXpHdmp0bjN0N1ltdVIzVVU0MWtndXYyYVpIKzUy?=
 =?utf-8?B?NkxBNFlaN1V3aFJFVmQyOVEySVpIQ3lvdGw1SGR1WFU3Z2dtblZLcGJFaDZ4?=
 =?utf-8?B?NXY1UjZyaEZNSTREVjJPL2d6aWxPcHFhSEZyMXVxNEU2dVVPblRPaHhabWd4?=
 =?utf-8?B?blZPV1RONlJacGpoU2FaamlYSjVYS2s5djIwVUVVOU5ydExibktCMzlSTkl6?=
 =?utf-8?B?OXArblUvTUhVRURqR1dIZFBqc0tOaGU5dDFCbU5NZHB5Vk9QUGhWTXpManJF?=
 =?utf-8?B?UlBsOHJla296akFVYkpFUVJ0Q0hKV3lCS2EwWjBIUURpbUVLY09aYTJhRGJX?=
 =?utf-8?B?cFVTbG1qb25na2QwVDdaazR3NFBJUDY3YmRmSTV5MnpGLzdmeVhaUktwS3RQ?=
 =?utf-8?B?d1BwaTQreXVOVmFqMWFRUUFFYi9SWkhPZllMOTllR040dmU0M2FITEZWWW1B?=
 =?utf-8?B?WDZJSnQzTUtiV2FBamlFYVFIb1QrRlg3aGpyenlmZ1dSQnA4Ykcvcnp3MnNz?=
 =?utf-8?B?aHMxTXZyS01HMGVHRFlFWFNpRXB5NUprVlJPS0gwaFlZS1FqSHVCYlRyYzdJ?=
 =?utf-8?B?QWxMazB2OFFyQkRIdFVrNVhNRFlWUzgwMEJRK3RxeHB2NGlwYnMyVXJwVHlq?=
 =?utf-8?B?dlFabm5zaVJpZSs1WVBEY2QyOG80SHFnVFFuK2g4MTdZTXJyYVpCdG1GMlh1?=
 =?utf-8?B?VWJoYUtZbHIzKzBjVzVtbzhKc1JISkxpTDYyNDdPRFhEdmxienFJMk9NM1lr?=
 =?utf-8?B?eFkzRlErWUE5VlpJc2daQmdzcW1sSCt6cjVjMHhvb1BEZDBITlV4K2Zmc2VR?=
 =?utf-8?B?VUpiV0RaTzFVT0RycW1uNzBlRGl5U1hlUGhCSkNlSkdaNy9nWVp0V3NpdCtm?=
 =?utf-8?B?NzhrU0JuaS9QdS9IR0dKNzdCRXMwd3IwZkFCN2JWVHd4aFJkeFlEZW1IK2dz?=
 =?utf-8?B?RS9qbVIwZkFhdUsvRGlrTFdWU0FxeHdlVE85ek9aNVFWTkVOWExTRFdpbnBD?=
 =?utf-8?B?bEc2WXBGTVZ6NE9rYTFHeGNEd1RpK2xSSXJWeHpUdkxWUEYwZFRNYWlPWGph?=
 =?utf-8?B?THkxYWVqVU52Vk5EYi8xSVNxbWVydEhRT3RadXVxdmFKVEh2M3VjQXFaRzh5?=
 =?utf-8?B?NmNjT0pYb0xJWlo2R0VpUkNPOGNPMjFGOHhjd0lNRzBwLzNYTTNOUm1TbSsx?=
 =?utf-8?B?NWNoa0RYT3BIMGpOTmZnSEJ2RGh2TnJ4OEovTktJbzd4ZU5PZndtWGRkdW9O?=
 =?utf-8?B?ZEcxdkdOMmFZM3MvUDllY0kzRkFPK2x4MkZYTElXOS82V2RBb1MyZVJub0FX?=
 =?utf-8?B?eWZkTWdGdUlPRVh1c0lJWHpjWEtZZVJxd3NWOGRHYzNjcE85WThkaEtyYTA3?=
 =?utf-8?B?d2h1ZDIzT0ZMc09tTU1JbjdLWnBRRTlqTUpHMW5pYWppV3FiNjJEdEwxdEtV?=
 =?utf-8?B?MTl1VElEU0NKL0VGb01JeTBHVlcrMEZGMlR5QkJ3aXVIVnFKN2RsdXp3RXlv?=
 =?utf-8?B?Mk5LUFMvN0dnNXE3ckVPLzVUV08wdHJjdlgwZXN4KzMzR3pkbFNndzFKTWlp?=
 =?utf-8?B?S3Y2ZXQ3Y0lSUG1sSjdJRmozTW02ckphRXJTVVl5N2owL0ZTRGhKeGpONi90?=
 =?utf-8?B?QXFWd3Vra1c2Mkh4MFA4RmJFMzBXcmZ2VU05U2IzWWlrU2VMSTZZeVpJdzZt?=
 =?utf-8?B?RFppWmpHQnUwQXRlSUNwdWtNTkd3b2ZVcUdwTG5kaGtiK0JGOE1nZFR4RGRi?=
 =?utf-8?B?TnRyNVc4WStNS1NDdnh3ejgvclJjVEdWcHo2Y3BqbmZ3TDE2YStoKzkyU1lh?=
 =?utf-8?B?NFZjTGZ0L2VBYlFPMFZwSldDTmFDSDJNcWNQOUFiOWp3WFNwckFUdm9iZE8r?=
 =?utf-8?B?NnZhMFl0eFI1b0ZiKzdNY1FTaHVadTYwakM1Z00xcUNRZUpKWXVUZ2VCMXlp?=
 =?utf-8?B?MzJBSDhhOUxha3haWEpxVGk5VDBndE9yMkRBL0MyaG9CZ0ZsZThRUms1NGsx?=
 =?utf-8?B?bUl3elFjc1NhdTQvekoyN1VsVHMyRWpEaGM1TUl5eFBIQjdpVGgxdVVkMTZj?=
 =?utf-8?Q?CsiaQ6Qm31oRd91bDdyN52qpWGqru2vIJTfZ9SlKBbcmX?=
X-MS-Exchange-AntiSpam-MessageData-1: p8fZIYXPh5pNXg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf46a35-867e-4a06-d869-08da380f64b4
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1947.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:13:19.3928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k8WQEMDmwv1u6xUiO9e5LmsLMRBZOYhwTSmyYmGJLZuqwyiCTl02D+XhYoxqb1nTsSjAVIbCssRLhZo2r62ndQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2903
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Done.

Andrey

On 2022-05-17 10:03, Andrey Grodzovsky wrote:
> Let me push it into drm-misc-next.
>
> Andrey
>
> On 2022-05-17 05:03, Dmitry Osipenko wrote:
>
>> On 5/17/22 10:40, Erico Nunes wrote:
>>> On Wed, Apr 13, 2022 at 12:05 PM Steven Price <steven.price@arm.com> 
>>> wrote:
>>>> On 11/04/2022 23:15, Dmitry Osipenko wrote:
>>>>> Interrupt context can't sleep. Drivers like Panfrost and MSM are 
>>>>> taking
>>>>> mutex when job is released, and thus, that code can sleep. This 
>>>>> results
>>>>> into "BUG: scheduling while atomic" if locks are contented while 
>>>>> job is
>>>>> freed. There is no good reason for releasing scheduler's jobs in IRQ
>>>>> context, hence use normal context to fix the trouble.
>>>>>
>>>>> Cc: stable@vger.kernel.org
>>>>> Fixes: 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a 
>>>>> processes")
>>>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>> Reviewed-by: Steven Price <steven.price@arm.com>
>>> Is there something blocking this patch?
>>> Mesa CI is still hitting the issue and I have been waiting for it to
>>> be applied/backported to update CI with it.
>>> Thanks
>> If this patch won't be picked up anytime soon, then I'll include it into
>> my "memory shrinker" patchset together with the rest of the fixes, so it
>> won't get lost.
>>