Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Eric W. Biederman" <ebiederm@xmission.com>
To:     Huacai Chen <chenhuacai@gmail.com>
Cc:     WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "<linux-arch@vger.kernel.org>" <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Guo Ren <guoren@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Al Viro <viro@zeniv.linux.org.uk>
References: <20220514080402.2650181-1-chenhuacai@loongson.cn>
        <20220514080402.2650181-15-chenhuacai@loongson.cn>
        <ef37e578-d843-6a2f-2108-2a26dc54bece@xen0n.name>
        <CAAhV-H7UwLJLiMtjkW0xxfsBBaCPXqkQ-d+ZW4rm+=igvVP6ew@mail.gmail.com>
        <b30e5b28-2a3a-f3a6-1bb1-592323f6eadd@xen0n.name>
        <87bkvxd12b.fsf@email.froward.int.ebiederm.org>
        <CAAhV-H7R4hioE-dHVxAnPmeJJ-eqiWkdmZWxNDfLesuvURCLcw@mail.gmail.com>
Date:   Tue, 17 May 2022 10:36:48 -0500
In-Reply-To: <CAAhV-H7R4hioE-dHVxAnPmeJJ-eqiWkdmZWxNDfLesuvURCLcw@mail.gmail.com>
        (Huacai Chen's message of "Tue, 17 May 2022 10:08:18 +0800")
Message-ID: <87v8u49nn3.fsf@email.froward.int.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH V10 14/22] LoongArch: Add signal handling support
Precedence: bulk

Huacai Chen <chenhuacai@gmail.com> writes:

> Hi, Eric,
>
> On Mon, May 16, 2022 at 10:07 PM Eric W. Biederman
> <ebiederm@xmission.com> wrote:
>>
>> I can understand exporting these values but the names aren't very
>> well namespaced at all.  Which means they could accidentially
>> conflict with things.
>>
>> It would probably be better to do:
>> SC_USED_FP
>> SC_ADDRERR_RD
>> SC_ADDRERR_WR
> SC_ prefix is good, but ADRERR_RD/ADRERR_WR is used together with
> SIGSEGV/SIGBUS, so I want to keep the same as BUS_ADRERR (a single D)
> if possible.

Fair enough about the single D.  Please add the prefix in the next
version. Especially for kabi symbols in a namespace is a very good idea.


>> Given that neither lsx_context nor lasx_context are used in the kernel
>> code yet I would very much prefer that their inclusion wait until there
>> is actual code that needs them.
>>
>> If nothing else that will put the definitions in context so people can
>> more easily see the big picture and understand how the pieces fit.
> OK, I will remove lsx_context/lasx_context in the next version.

Thanks,
Eric