Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp135404iob; Tue, 17 May 2022 21:26:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+iduGlMFWClBEIMwC2UIkMHqbeSr5F+uOm9S8fdd902C+u9rmKMCFdj+PEkqBcud/WpAU X-Received: by 2002:a17:902:cec9:b0:15f:3718:7b3f with SMTP id d9-20020a170902cec900b0015f37187b3fmr25997203plg.77.1652848006123; Tue, 17 May 2022 21:26:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652848006; cv=none; d=google.com; s=arc-20160816; b=buaUaTXxGleQpKoygefyqdxeltZ33Mpb7y03ls+SazmTzj5TUj+QgmkMw3m6sxqrEJ GaPaemuVVpRjVSCsMvcZHelub/S+/6Kzv18KaKrlnIUWEFxt2s4CxB7hkYjGIu1TWwxW 4FMZTC8mgZ4cqX9lmfnqAgVri3BvmVuIyQQhd+niI+VQ1RxmuTKxNx6MyokB+jm1QxB/ ZIL6JKqsNckBkxAmUEZLo11pMbNv1tbnbsQ8gc4bBrp6PVqjwDwzpKWdKrTQVkH+vAUw X4hfqhtGuei15pnM2HHzmcTXgb1KpP++uM4cbTUZllqKCL+K2q66a59dRsLn4NoEM9mV S98Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=jA+ZZ535mW9lkveex/k/BNBtXLLURKxBnX7kfn3Gewg=; b=NRV2Idxz6ry7CUA+jCK4Yuyw4zXc87Ux7VTT/vOKjaVGVcgYH4AIBMMt/MXAtiq3Um NkWFrs044Z8A4iPXHIHj4LcIJyOAyxO2uxBW2ZRRbX3RKnelOppYP6l20s0oeUdAyU8Z ZST6midSxvSpxiVufey2ZVDht0glBami9YR+PmwKlWPLp5238P4M5KwE0Bx4CpcOprYV +KktjNY0kSMT/E3x31llF0vwCk5Ff41Hq3blVFFEw/DrkDN9ciO2RP+adlD+HyCjT5F6 JlqO7WhIg82lATmLuzXkY5G9z7NzRKQTUgbzntIWrsxeAnBzB5QZr/X37IoGaeiw3xqS 72pw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id e7-20020a63db07000000b0039eea38be43si1201800pgg.287.2022.05.17.21.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 21:26:46 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 98AFC8B0B5; Tue, 17 May 2022 20:50:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352862AbiEQTl2 (ORCPT + 99 others); Tue, 17 May 2022 15:41:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352853AbiEQTlE (ORCPT ); Tue, 17 May 2022 15:41:04 -0400 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CDDE1D317; Tue, 17 May 2022 12:41:03 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2ef5380669cso1810917b3.9; Tue, 17 May 2022 12:41:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jA+ZZ535mW9lkveex/k/BNBtXLLURKxBnX7kfn3Gewg=; b=oF1guhNrPBsF9TeKexacQWWMM7lgyzQXxgX/Ehysj0hdK0X2jMp88v7PjSKQYsZGAp DhTBZpMnGUKp8XpWYeLjiHk8uIfhPQ5Aguu0CbBJlT9svNOl5pSQuHpKAGdyNC9EKkXE HbYB2isKJkdyqAwZtJj+YCSnk1OLMOrBqFHF1eJO6g9pOx8s83SL7AfZsRclygCdknL6 7w8+gFvGD3V7ExlWD4AjLzDsdXttMoa+uAHgGNrhVq2YC7l8/WNSmQBnUhozJ7ttSdYw dxAJXVBvpybOtd3eH4+i4vcMsaiKL+9HoMK2A5PbaLPTx4fEnygUiUSWjdpNGYERg5tO Zv3Q== X-Gm-Message-State: AOAM533rmzBem1ghiK6vBvUfFUwUzh5Z8RpbGYrQ2iExHK3PG3xXlEz1 r4j2VeeA90YC5vxj6e2rfEUWrYH8ZFaqLRp6vKI= X-Received: by 2002:a81:1b97:0:b0:2db:640f:49d8 with SMTP id b145-20020a811b97000000b002db640f49d8mr26970283ywb.326.1652816462836; Tue, 17 May 2022 12:41:02 -0700 (PDT) MIME-Version: 1.0 References: <20220516030251.42323-1-schspa@gmail.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 17 May 2022 21:40:51 +0200 Message-ID: Subject: Re: [PATCH v6 1/2] cpufreq: Abort show/store for half initialized policy To: Viresh Kumar , Schspa Shi Cc: "Rafael J. Wysocki" , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2022 at 12:25 PM Viresh Kumar wrote: > > On Mon, 16 May 2022 at 04:03, Schspa Shi wrote: > > > > If policy initialization fails after the sysfs files are created, > > there is a possibility that we may end up running show()/store() > > callbacks for half initialized policies, which may have unpredictable > > outcomes. > > > > Abort show/store in such a case by making sure the policy is active. > > Also inactivate the policy on such failures. > > > > Signed-off-by: Schspa Shi > > Acked-by: Viresh Kumar Applied along with the [2/2], with some adjustments in the subject and changelog, as 5.19 material. Thanks!