Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <301a1d0a-971b-5b27-c5a9-86390358de9a@wanadoo.fr>
Date:   Tue, 17 May 2022 21:42:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] RDMA: remove null check after call container_of()
Content-Language: en-US
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, Haowen Bai <baihaowen@meizu.com>
Newsgroups: gmane.linux.drivers.rdma,gmane.linux.kernel
References: <1652751208-23211-1-git-send-email-baihaowen@meizu.com>
 <20220517121646.GE63055@ziepe.ca>
 <142a9c03-574f-adcf-bc4d-bb2a25c01e88@wanadoo.fr>
 <20220517180303.GK63055@ziepe.ca>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20220517180303.GK63055@ziepe.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 17/05/2022 à 20:03, Jason Gunthorpe a écrit :
> On Tue, May 17, 2022 at 07:54:38PM +0200, Christophe JAILLET wrote:
>> Le 17/05/2022 à 14:16, Jason Gunthorpe a écrit :
>>> On Tue, May 17, 2022 at 09:33:28AM +0800, Haowen Bai wrote:
>>>> container_of() will never return NULL, so remove useless code.
>>>
>>> It is confusing here, but it can be null.
>>
>> Hi,
>>
>> out of curiosity, can you elaborate how it can be NULL?
> 
> It is guarented/required that that container_of is a 0 offset. The
> normal usage of the ib_alloc_device macro:
> 
> #define ib_alloc_device(drv_struct, member)                                    \
> 	container_of(_ib_alloc_device(sizeof(struct drv_struct) +              \
> 				      BUILD_BUG_ON_ZERO(offsetof(              \
> 					      struct drv_struct, member))),    \
> 		     struct drv_struct, member)
> 
> Enforces this property with a BUILD_BUG_ON
> 
> So, if the input pointer to container_of is reliably NULL or ERR_PTR
> then the output pointer will be the same.
> 
> The rvt code here open codes the call because it is a mid-layer and
> the sizeof() calculation above is not correct for it.
> 
> Jason
> 

Crystal clear.
Thank you for the explanation.

CJ