Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Song Liu <songliubraving@fb.com>
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "song@kernel.org" <song@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "Torvalds, Linus" <torvalds@linux-foundation.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        Kernel Team <Kernel-team@fb.com>,
        "ast@kernel.org" <ast@kernel.org>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>
Subject: Re: [PATCH bpf-next 2/5] x86/alternative: introduce text_poke_set
Thread-Topic: [PATCH bpf-next 2/5] x86/alternative: introduce text_poke_set
Thread-Index: AQHYaOeQGQ/WNhSrw0WYR6bm3RcCIa0jc3eAgAAfpAA=
Date:   Tue, 17 May 2022 21:09:57 +0000
Message-ID: <C71A3F08-5FDC-4981-99E5-F486A048D377@fb.com>
References: <20220516054051.114490-1-song@kernel.org>
 <20220516054051.114490-3-song@kernel.org>
 <e681c4083fc53cedded845301e8df7a4910d1075.camel@intel.com>
In-Reply-To: <e681c4083fc53cedded845301e8df7a4910d1075.camel@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WoLFZ6xpMsCZq75nww6Y21j6ZSjpsG6yjPwJFZqdNA4wc85d8HeKr/eb2VuC?=
 =?us-ascii?Q?s/W/mNZmPggyZUkhXo1NewCJUFOXOf89aHP2yLfsy/x8QfYS3WJs+Pkkt49p?=
 =?us-ascii?Q?6lRavPfCtiW71uWXYjHerVXULc1ExxZ7Ga6mwujwD5uUJ2r7jlE8OHl2E4HA?=
 =?us-ascii?Q?y8bgk1D0mVpv3NRY0KSHLVkjfYxCiEvbWfdAn6CVRusnBmKFAdciCUO4+JBM?=
 =?us-ascii?Q?tA/onfjaExIAPNYo2Rpfn4GT6bQCeHdIj9FnUQ8AP4N7qkKjGtaH1yMgAvau?=
 =?us-ascii?Q?eVYGjgFsgw1mjcx3K4P4DEEwNn8kDfIxwvwC3SrqdeSTSA3OnHibHIceMpt8?=
 =?us-ascii?Q?Deh4P3zzLGnglijgDWU8+qwa9nlE9E0RzZcQnuo2BOccmp65S+F8Rk1YAwv3?=
 =?us-ascii?Q?7M7BYBzcpsGyuEREK92VQzNcimbiYx6w485UxF9P2YZapkfTwBQNehvPMym5?=
 =?us-ascii?Q?gQEfRs/oyfiTnOJv9tnWiPg6EOizoQS+e6moWAH51zc0XZ3wPvQplf1wN8e+?=
 =?us-ascii?Q?ujMIoRjNaJIrwXf3XhC/AfLBd1L/gHiHM3Dw4tDM5rVbMW8YhsUhMsPF9PSJ?=
 =?us-ascii?Q?0zQQTeYNqd4Max4CIdGMgVD0uLPYrHZfmE/5KMAL2N2ygrgA4G0YWLnvU56o?=
 =?us-ascii?Q?593zsEISm7BRV2cwD+8/3eTZJPw0tEXAHEmdmedrrW+i21phkW6xLHsa8IDD?=
 =?us-ascii?Q?D6eE9QhTRReaBHmbSy12POnRldicG2BlhtxURVz5fHwHm0nuWkurWQwSHj7d?=
 =?us-ascii?Q?Tvjg0csjGBKtaCPpV+bK7nrTRUizzhHz55Gv335hgxj1LPKKxaTrEHfu+00g?=
 =?us-ascii?Q?z6LqKjI725Meyol70f0yWkRI2SxUtc9tu6Jd2bOjeyJLeZHw2kt3KF6kzMlj?=
 =?us-ascii?Q?Wxl2NOeuX5eoZJbc4rv7zu3FKGiSl8o5OrqGyHfqZ616xQXTVaGUN8XRf8Yw?=
 =?us-ascii?Q?lnBoRhPs0NjVGMSDeP7Imqn2ufpyzdWbKDPycN0QN7KpM6HKwu8cNoYix6jH?=
 =?us-ascii?Q?vh4XMQJ/Ocx3/U7yiuQ1o9T8mzEUHETHTjEdYVoMD8uKCHAKLEXUvIurJFw6?=
 =?us-ascii?Q?ECd/S9mZdCnUQ+4vRj1KBJyVaJ9zZr36x0TZO7tRW0tfC6I7EOygTfCJVshM?=
 =?us-ascii?Q?SH5sZ8NcLoFXMAGSNZGKpcpg6/LrV5NexOGCJrsxuC9jSy7x8IkIWIo59NGV?=
 =?us-ascii?Q?zZ4rwe9mtnjPquDSLII84pKDe6yUcrGRmpyFqwGwqPqNqvGhXeLuGTFUKcQF?=
 =?us-ascii?Q?+/FMRRqv4e0J/OnKSqLsoCAod7l2sixhIqaOBofiNTfeOuD2kfO3xUUHRp9y?=
 =?us-ascii?Q?Hu6qL36RMSE3Zr6gGtUcK53aNhIAIzWzn4f2/SfTjO5472Ef0OCMlvUi51Lv?=
 =?us-ascii?Q?WYniyc45d4x0YkMZRN8qvggMrwZeNd3hhv52lOKwwyr4+UWMYMIjY9LWyztv?=
 =?us-ascii?Q?rIXC3xV2rpLxBb+ZId2OuPWdP0EBJgiO6ZEawTGLLObRfkQixB/fIH6eHvLe?=
 =?us-ascii?Q?+ul/QLWW1oRegOAr+oA2tzdxVua/Gqz0J1yGRLEtizE3LC+XzYpQ05yyCkUF?=
 =?us-ascii?Q?E9zZCO4z5TttsHC5RwIodaldhuknGcizmadzqU4rw5rrd1I2XVPWQ9mtrXpI?=
 =?us-ascii?Q?A0RF8MCf0Ny1TocjP4AlfSlcnnuZqlcqMFhr6EoAn9lxsdmW2CZmfjwVvBD/?=
 =?us-ascii?Q?VqcKeQdl5bYJctEFYvHkORKUUsRIeOgc+X0wjWIS/r96/vIYlhA/X4Pw/s9t?=
 =?us-ascii?Q?PzwsPPrx5m2e5GSAmVA1rm0jKzzTa1Zyo3+VLm9x6sO7S2RTTnqv?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <87CF3FC68848B447A1F9FACAFEA5A3A6@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8406cb27-ae3d-44dd-ef9b-08da3849992f
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 21:09:57.9701
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gw0zpALxUHC6EDUWGPw9IY01qLHcjDQ/DGCb3FCVlzIdX0PxYLGUGvFfA/K9R9q34P9m93tNscn7FJgYUm/ADA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2322
X-Proofpoint-GUID: D3HyMvpkWxV63clxEEalIRZpDdb49_67
X-Proofpoint-ORIG-GUID: D3HyMvpkWxV63clxEEalIRZpDdb49_67
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-17_03,2022-05-17_02,2022-02-23_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 17, 2022, at 12:16 PM, Edgecombe, Rick P <rick.p.edgecombe@intel.com> wrote:
> 
> On Sun, 2022-05-15 at 22:40 -0700, Song Liu wrote:
>> +static void text_poke_memset(void *dst, const void *src, size_t len)
>> +{
>> +       int c = *(int *)src;
> 
> It casts away the const unnecessarily. It could be *(const int *)src.

I will fix this in the next version. Or we can ask the maintainer to 
fix it when applying the patches. 

Thanks,
Song

> 
>> +
>> +       memset(dst, c, len);
>> +}
>> +