Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Sven Schnelle <svens@linux.ibm.com>
CC:     Heiko Carstens <hca@linux.ibm.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mapletree-vs-khugepaged
Thread-Topic: [PATCH] mapletree-vs-khugepaged
Thread-Index: AQHYWyROtMkVxK19R0i3Z444SV9CtK0GzcYAgBYshMGAACVRAIADV5a2gAEtjgCAABq5+YAAA6QAgAAWUO+AAWu4AA==
Date:   Tue, 17 May 2022 14:52:33 +0000
Message-ID: <20220517145222.7onuxvc7ckbmx3e6@revolver>
References: <20220428172040.GA3623323@roeck-us.net> <YmvVkKXJWBoGqWFx@osiris>
 <yt9dk0apbicu.fsf@linux.ibm.com> <20220513165955.mkg5wvfi4dwpzoer@revolver>
 <yt9dbkvy5zu0.fsf@linux.ibm.com> <20220516140202.pcw2f6gu4kyslmjd@revolver>
 <yt9d1qwt5w06.fsf@linux.ibm.com> <20220516155042.axgwex2enlf54n5m@revolver>
 <yt9dwnel4d4x.fsf@linux.ibm.com>
In-Reply-To: <yt9dwnel4d4x.fsf@linux.ibm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Iqa42bFEJ8I/BDsjc/FAQv8y2D+kMplHWPDzxWCwYQoDWPrEcIOSbWBZDEkY?=
 =?us-ascii?Q?Pf1KvqYzKUz+O/vxIOussYcSteR5y/XkCk3eeXTx5InUememOqqc7+v4bC6L?=
 =?us-ascii?Q?B8l0RtyeJzk5ZHhVuvuIcItunMsvLFEk98gAM6ID5dTUvAeMa5bZDJBA2GSW?=
 =?us-ascii?Q?Slr63xhRx0QJvItyyKj+6Pvzfh3zDmRnpqwmHt0++HexqtiAXQN5nd4FnJyI?=
 =?us-ascii?Q?38Ihg1snH9vnwG95lhbslYK2ZCFeWJGQJOX4ea8DvKmPXmLsTxpj5C1AVZo1?=
 =?us-ascii?Q?KSCbrv4pjDXYJ9EjiX1Xw+ET/yoWFpVawDi7BaHyYar8lJgFwFZfysaI1MHQ?=
 =?us-ascii?Q?Tr8WGenGcAdgxcalEUf+8mwBJYnLwccrFftY5AXIJiIyoyn/rodYi/i/SyGR?=
 =?us-ascii?Q?SaztTX3s8V+OmzfyikowoL9q2ipflNy5m6VXvZ/DljwuGzZYqdljvSPYaNly?=
 =?us-ascii?Q?DTYoT2IDjk5ohFkujR/jE7IxLfaHCaVq4PFG+7fusrvoJxCCNWQMebX7Ifk8?=
 =?us-ascii?Q?hpA0BmUMT9/oU6WWA1idD153nuanBEQHDHfzivGxY3sBqcqg2ZzqS6Y5WaOD?=
 =?us-ascii?Q?PCSdQEbqG378kuj29lPwuHj7iLzv8Kpixs+w+uJpY0kOCo/BhqCYzAWvO0Ay?=
 =?us-ascii?Q?u7tIKJYz2uq79jmaV7tVsy/1CdxjWg03DeYJf68S+fUf+5jOMRHzlLJ5xjTQ?=
 =?us-ascii?Q?hTA4F/8PYYzX3erHclsL7Zgwp71UzU9oTWw/WkVhmvo9V0k/UicNhbk08YF9?=
 =?us-ascii?Q?jDdxZULJFhjMOHgTPb1OfxMLIhmRend3XNG75b1B/qJ2EfVmiK2j6AXoa0Eh?=
 =?us-ascii?Q?M11bZRtck9ovMirzGSrECj0GO5kJdpvIm9akQk4odLos7bIsdYIuVXNi58wS?=
 =?us-ascii?Q?wVh9DAbNMYiiSQBJU9oL/QrY0T2suJN0x4faOY+NRmJplNE9SoidvCHBPlHc?=
 =?us-ascii?Q?srq7NZCOw/j4/NYsSCx6PSDMr58o2NkZVQ1h3c4WGbzkl4n4utaPyIl2yRJk?=
 =?us-ascii?Q?Lu3CTJSQq9DX2m+vNvySEhAcGJs2xFJ1rXOjWkKYioIq4gnY5Ksw5IZGu0Wh?=
 =?us-ascii?Q?nqzngLnXEshm0CCIH2L4d3l2/bN5z05PgMCcwxewphowjMOBnShfI+GDPLov?=
 =?us-ascii?Q?M0easi2i/60iTGrai6IWA6m9FSYRO+1iNiMaAyR+ykoBwYZNI+dEH8npheR8?=
 =?us-ascii?Q?C8+e7y98gYKBqTYxAcv7z1esmW2EFXIAmx4CsCVdG8rQrrFz34JTR0LSgOMD?=
 =?us-ascii?Q?78SJTsdypXLQ4UdA1I27VptTRP5cPsSw7PjBRTUsJTDdyEQDtwZOAIIWPTj0?=
 =?us-ascii?Q?YBm4Um4QLMVF1GQOLQy3QHcwSBj1M/MwwCWPOfOf2sZFzIIT6s917ODvKMYz?=
 =?us-ascii?Q?ZdF1eB94L1RwSOG/0y8Moh4QVgJBR//9PcygbRF0DT73gky3Vt8yUisofYnX?=
 =?us-ascii?Q?1JhIazDuktGyjWpTsUMa/yriMGGNpIqJlrC9NYSWSgCsgqoNcFLqUyLi6/l5?=
 =?us-ascii?Q?xYizPfD3T9k59alVCgLEMITrjMmHgeOGFT7fdQRphBvGlA1wITnfpTqxT9fM?=
 =?us-ascii?Q?yKBbFTxcWMG01VJu7B9H81tcFy221Rswcl18FZ5ASNyQYoxpYrdimwT8pj8w?=
 =?us-ascii?Q?HM6/eQCLhArNlQg8Acu0+SZoHp8eP+NrFibs7eAc2gY2q01XufFO4Kt1ZFFX?=
 =?us-ascii?Q?7JQ3HmqKfKQODpAmya054adlYWhu7C7Q0HkLYSop+Ned1A9x+1iydHNc6es3?=
 =?us-ascii?Q?tfLcWCH84+CXdJ4gtUwB22t2Oz0ksHo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <93B35AC911EDC446A887FA567FC232FF@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a1c7c79-4471-4e5c-7eed-08da3814dff0
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 14:52:33.3459
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4MUyNsBqpBgF6YXD/yUK3NEToHC7o2EVM5kfhMVHWRDn4fKQ99jN9mjsWFYbojP8kprqQtqLOuNfnwpVEap5Hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB2008
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-17_03:2022-05-17,2022-05-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205170090
X-Proofpoint-GUID: GUjhCVRWzsuvmtGAWwncackhFlo7LK6t
X-Proofpoint-ORIG-GUID: GUjhCVRWzsuvmtGAWwncackhFlo7LK6t
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Sven Schnelle <svens@linux.ibm.com> [220516 13:10]:
> Liam Howlett <liam.howlett@oracle.com> writes:
>=20
> > * Sven Schnelle <svens@linux.ibm.com> [220516 11:37]:
> >> Hi Liam,
> >>=20
> >> Liam Howlett <liam.howlett@oracle.com> writes:
> >>=20
> >> > * Sven Schnelle <svens@linux.ibm.com> [220515 16:02]:
> >> >
> >> > I tried the above on my qemu s390 with kernel 5.18.0-rc6-next-202205=
13,
> >> > but it runs without issue, return code is 0.  Is there something the=
 VM
> >> > needs to have for this to trigger?
> >>=20
> >> A coworker said the same. Reason for this seems to be that i've run th=
e
> >> code in a unittest environment which seems to make a difference. When
> >> compiling the code above with gcc on my system it also doesn't crash.
> >> So i have to figure out what makes this unittest binary special.
> >>=20
> >> >> I've added a few debug statements to the maple tree code:
> >> >>=20
> >> >> [   27.769641] mas_next_entry: offset=3D14
> >> >> [   27.769642] mas_next_nentry: entry =3D 0e00000000000000, slots=
=3D0000000090249f80, mas->offset=3D15 count=3D14
> >> >
> >> > Where exactly are you printing this?
> >>=20
> >> I added a lot of debug statements to the code trying to understand
> >> it. I'll attach it to this mail.
> >
> > Thanks.  Can you check to see if that diff you sent was the correct
> > file?  It appears to be the git stats and not the changes themselves.
>=20
> No, it wasn't. I did git stash show with -p, which doesn't make sense.
> I've attached the correct diff.

Thanks for this.  I think the key is that the offset is beyond the end
of the node (count).  What is happening is that we are already at the
last entry in the node and calling next.  I had moved the last entry
from the loop to optimize mas_next_nentry() and set it after.
Unfortunately I did not check for this condition on entry to the
function.  I have a patch I will send out shortly.