Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 17 May 2022 16:23:30 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Max Staudt <max@enpas.org>
Cc:     Oliver Hartkopp <socketcan@hartkopp.net>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and
 can_skb_headroom_valid to skb.c
Message-ID: <20220517142330.vm7jqoe6i63ryqtc@pengutronix.de>
References: <CAMZ6RqKZMHXB7rQ70GrXcVE7x7kytAAGfE+MOpSgWgWgp0gD2g@mail.gmail.com>
 <20220517060821.akuqbqxro34tj7x6@pengutronix.de>
 <CAMZ6RqJ3sXYUOpw7hEfDzj14H-vXK_i+eYojBk2Lq=h=7cm7Jg@mail.gmail.com>
 <20220517104545.eslountqjppvcnz2@pengutronix.de>
 <e054f6d4-7ed1-98ac-8364-425f4ef0f760@hartkopp.net>
 <20220517141404.578d188a.max@enpas.org>
 <20220517122153.4r6n6kkbdslsa2hv@pengutronix.de>
 <20220517143921.08458f2c.max@enpas.org>
 <0b505b1f-1ee4-5a2c-3bbf-6e9822f78817@hartkopp.net>
 <20220517154301.5bf99ba9.max@enpas.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tgwfqoi623ckzpip"
Content-Disposition: inline
In-Reply-To: <20220517154301.5bf99ba9.max@enpas.org>
Precedence: bulk


--tgwfqoi623ckzpip
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 17.05.2022 15:43:01, Max Staudt wrote:
> > Oh, I didn't want to introduce two new kernel modules but to have=20
> > can_dev in different 'feature levels'.
>=20
> Which I agree is a nice idea, as long as heisenbugs can be avoided :)
>=20
> (as for the separate modules vs. feature levels of can-dev - sorry, my
> two paragraphs were each referring to a different idea. I mixed them
> into one single email...)
>=20
> Maybe the can-skb and rx-offload parts could be a *visible* sub-option
> of can-dev in Kconfig, which is normally optional, but immediately
> force-selected once a CAN HW driver is selected?

In the ctucanfd driver we made the base driver "invisible" if
COMPILE_TEST is not selected:

| config CAN_CTUCANFD
|         tristate "CTU CAN-FD IP core" if COMPILE_TEST
|=20
| config CAN_CTUCANFD_PCI
|         tristate "CTU CAN-FD IP core PCI/PCIe driver"
|         depends on PCI
|         select CAN_CTUCANFD

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--tgwfqoi623ckzpip
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKDr+AACgkQrX5LkNig
011wSgf/RV+/tPG2xXLH0ovdmc9xiGLHdexWXlcaQGRlACwpK3TzxCdKsnf5EA/r
AOx+7UogJqyoeBxO1lIm4Cqp3vclJ3i2xPjZADpGCvn+yulIZerhqOmEeerae0Bk
CR+/vyCFGJIHERQOOR/B3Wum7pM1kOPHE7V+5DGJikZ59Giyq3Lnf1hAS+qP6I/8
3w/eu8cGzYLkNigVyA+BWkZLm+hx2HH2sSWYNfnxpV5m7usfG+tKI8dROxLttPpx
TgMXWCjyDC63y5V0yXD/B6+TaFFGsrZCOtBgwUP6eVyVyKnxZSYlI8fd4ybY+U7W
mGX8jgAz6iGHy8sukm1eRz5mUxZxJg==
=WKSH
-----END PGP SIGNATURE-----

--tgwfqoi623ckzpip--