Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp189851lfo; Tue, 17 May 2022 21:48:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMawY650ny1a5krb7z/BdrxqrymLW5s5JxA6xe1XMhvK4TIIaLEAscfUKmGiTJawslCUgA X-Received: by 2002:a05:6a00:1a86:b0:50f:f4fd:c9a7 with SMTP id e6-20020a056a001a8600b0050ff4fdc9a7mr25558802pfv.46.1652849326113; Tue, 17 May 2022 21:48:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652849326; cv=none; d=google.com; s=arc-20160816; b=kknRe36nOVkhtFf6TkgpLUcktivA1RevwGyJs7DBfjkbGv5eL55JUipCTCOrMKmJSx wn+iwhQP0UnFcIjFymRHBFmmQEbVn5mFMHXOOLxIdEhAB5tYZ02djxC13dOhXcOU/Iha w9t5PAkstV+FAiLOiK1aYn1wDR6Js3nARfZPL6MwaBa3gxUItX+mVfGexibcsNMNYkNa SR0XPQpJ+WRc+n850i+gD1a6nrfm0L7myvdf96+BuCbJsZuZsImaiuuSEyTXHBGxkJzJ 671UmZdPizhNq9vIjI8YZrCSgzdt18KzatgeORW4efY9aGYZd8fqIFSvHhJdQ9zEl5fE k2qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=jf4s8QIDSrOKg81HbuSA52ij+q0WBYhYTRAF+5w+aLk=; b=pgMLcs3jOumRDLtLqrV4aM/Y9XUn4SF5E1mFxnCZrQM6LGi4LgKoVIc8SZeU6eeaLw JurifV+sfZfeDIit/lI4+A55oAl0DApjxVhB4FpKMvnxNOw+dKTWumBZ+4U/FU0QN/86 4npULctsL3N2B4fxkRD7HqQNaf8XMLTOBycJOEFK+Ay8eusOrqNTW6pSU5pjVmFdrrIG kUBC5Fj/S/v9YerFpbv9CS1oEbL/73p9lda8S28d+sChns3vYXG3ecyTCItq8qeL7H7G NUKKA90bs3yE1z9Ohf5oVE0tAUAY0mbQmbccYdbAFc0WKBlXTV99/ju8bDeCUjPWUyDn 0Yig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VtoWTUwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id o12-20020a056a00214c00b004fa3a8dffdfsi1579403pfk.150.2022.05.17.21.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 21:48:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VtoWTUwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3D35B1271B2; Tue, 17 May 2022 20:59:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351319AbiEQRGv (ORCPT + 99 others); Tue, 17 May 2022 13:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350480AbiEQRGs (ORCPT ); Tue, 17 May 2022 13:06:48 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFD7513F0E; Tue, 17 May 2022 10:06:47 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id n18so17909885plg.5; Tue, 17 May 2022 10:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jf4s8QIDSrOKg81HbuSA52ij+q0WBYhYTRAF+5w+aLk=; b=VtoWTUwBib/p6g9+5Y6v7nCk/SG4snA+neR+JdtetOycCsBah4LsINBvKMmAVfJtbR VbiMQdF3H+44sT0KlE99hveW4lREXTpNV7FbX1ZjPTQGDakMHFYGIGYAvVsk/RNBOdIA lNJuw4/hWrPpWYmDGJjQUeJTXttNjagmUPdfKaYkFjSw42oqlfPmIaUhR6b1uOyHihot O4q3FiZOfGQwlrJ0v52lIES4ktkkdYtvY6bW7STRDlnYNlND0CIUTNX7pqtuAf9Vchv5 pzqkTDAN+l+uYcWxT1e+knThpmgWlXfPDZiwbUF996JX6DRDdSh2ttcOQqpwo6eUTUEa 68gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=jf4s8QIDSrOKg81HbuSA52ij+q0WBYhYTRAF+5w+aLk=; b=N+j4TvhGeIlm70TvLs/dk8u+lHMQs64Dnw7ea21Xm3K5h5/foUdPCS+BEG3HGfAInY WN7Jd7ddfYK1kH8zyg3FCGkyEmTW4JbrJpU6q6YgBahltu9ylUsJ0bToQc2c0pYT15T1 lXEbi9orsWWaas9+JCo0/a25yXv5ZVH/z2jFn1HUV7x7svE0MCO8f+U6H/A/7bpUL2qt UrdVG6pQbkpKlb6orodM+IwiNXct0S7NnVq3nlf5IGmXPbnEulKwwJ8L/63gMsc7GsDe j/7g4PXHVYf7fcZ5wooftJ5l3yFuN+SkvpjWEocrTh8sWL+DTTw6U1Klo2n6qZEsrYlp rE8w== X-Gm-Message-State: AOAM531EgZ9SvMiaZ4BHAuxmOKyX8cAYw/OCAdJM63iAT9TrK/aSjInA 84y923msqTobVHcOQ4ZI/d8= X-Received: by 2002:a17:902:bb90:b0:158:a031:2ff2 with SMTP id m16-20020a170902bb9000b00158a0312ff2mr23462620pls.117.1652807206983; Tue, 17 May 2022 10:06:46 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:62fc]) by smtp.gmail.com with ESMTPSA id p3-20020a170902a40300b001618645a902sm4039447plq.155.2022.05.17.10.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 10:06:46 -0700 (PDT) Sender: Tejun Heo Date: Tue, 17 May 2022 07:06:45 -1000 From: Tejun Heo To: Xiu Jianfeng Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] cgroup: Make cgroup_debug static Message-ID: References: <20220517112523.243386-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517112523.243386-1-xiujianfeng@huawei.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 07:25:23PM +0800, Xiu Jianfeng wrote: > Make cgroup_debug static since it's only used in cgroup.c > > Signed-off-by: Xiu Jianfeng The only thing it does is gating CFTYPE_DEBUG which isn't used anymore. Can you remove both CFTYPE_DEBUG and cgroup_debug() instead? Thanks. -- tejun