Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp191360lfo; Tue, 17 May 2022 21:52:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMrtUfXBkuhCL1Kor4wBZbva47DV5H0qu5kLw7SFcO9w7nHZvfn7hjlDvFBk6WbznNlq3C X-Received: by 2002:a17:902:bf45:b0:15c:df47:3d6 with SMTP id u5-20020a170902bf4500b0015cdf4703d6mr24757631pls.58.1652849571817; Tue, 17 May 2022 21:52:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652849571; cv=none; d=google.com; s=arc-20160816; b=Dl4DUQs2Gvz3DAJdek9WyN01tGgaHOn62/O3cFJ1mr0auAmQzuz0HDN+L96m9S04jt RSwTSxqcu+FmNdbBQAMDjqwy1l3zbJ8+3yQtXeUURCO3oAOfy2gA5+5mWMKWW5bq+e83 oIdr5RK9CYWjRbgMt0hYcFJPAn0AKH96p70YYhYjf2GLTz/4I6IQJfBMB1PrRYFCd1MB BRPaFBuW+UcyWWpW5bUyY0sNhkDy5DKdkwqY/YIyFwM4U4Gc6VW3l6u8wSI5k/kOhS9V yHHV7ORRVjm3wCsimUnafDIFpa754dwY/X37aA4hyZLapZHkbnVQ1AL6SyDq0xjMQsKG YrjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YUsMCylN0zh8xJplquTMkjli5fF8AmheIudUgY6ptis=; b=CYSxQ6a/xaYTevCtpR2ikpuxaKQEmtyqfgz30gQJDonunLkGdDCmiv9tR92rTKEV0Y v6EDl8CQi58mZKIRL62vhxYaX3rtPlHjbrtvqHAqecWWmNtxEQtVduWjEltpdVs9X2zS vsTvNUdL95PRF479ZZYwyiTaVp6ZtFEcgr/GYuUCVepsud7fK48+9FTssb4bpxY1AUiF TNDdKTxQXS8U15Eq0/23skani7DoW3W4gMyjPFLxflg9KDAyuK5gqA94AlapqCXC3Ags P95+LcyU9jWGHrWOd4GdJiUsanYBc+827yTwLmkCoaQFnR34Gyml677JbiCZVrahsnQz akbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=O6t4fRjq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 12-20020a63000c000000b003c5e1870574si1256947pga.667.2022.05.17.21.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 21:52:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=O6t4fRjq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B269643AF0; Tue, 17 May 2022 21:02:13 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbiEQWUL (ORCPT + 99 others); Tue, 17 May 2022 18:20:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbiEQWUJ (ORCPT ); Tue, 17 May 2022 18:20:09 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 695563C719; Tue, 17 May 2022 15:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YUsMCylN0zh8xJplquTMkjli5fF8AmheIudUgY6ptis=; b=O6t4fRjq0KN7eDopqIXl0NbsKe WqcgBXtLQn9rUHmkMpIKX/cYJxvWBiOSqkD+qJIUMfpCe6xo1G+mUMGSbXuG9hpuFypEvXpr3THHD 2spEYAhkghuLewdADFku7kwhdY3U+I9koD8pLej++6ybMVT11E221rSo9OoSt0lLoDRlBxHCUYPrj fGmBfvwqBMv7n7tNLaG63gWJYYtYjp3ntnv03UPMeN3Uap2x0WiDPUMY27fuDgifjyOk8mdJN9fZH bubLM+AV+fGNVfLoIxI8Do6GATRyHwdAtZ8caYkVjMXIhemOP3HZz7b6MSjjDzHo9SzpNMgii3uV/ OZqHU9Yw==; Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nr5Xy-00FqqD-Mi; Tue, 17 May 2022 22:20:06 +0000 Date: Tue, 17 May 2022 22:20:06 +0000 From: Al Viro To: Daniil Lunev Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, fuse-devel@lists.sourceforge.net, tytso@mit.edu, miklos@szeredi.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] FUSE: Retire superblock on force unmount Message-ID: References: <20220511222910.635307-1-dlunev@chromium.org> <20220512082832.v2.2.I692165059274c30b59bed56940b54a573ccb46e4@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512082832.v2.2.I692165059274c30b59bed56940b54a573ccb46e4@changeid> Sender: Al Viro X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 08:29:10AM +1000, Daniil Lunev wrote: > Force unmount of FUSE severes the connection with the user space, even > if there are still open files. Subsequent remount tries to re-use the > superblock held by the open files, which is meaningless in the FUSE case > after disconnect - reused super block doesn't have userspace counterpart > attached to it and is incapable of doing any IO. Why not simply have those simply rejected by fuse_test_super()? Looks like that would be much smaller and less invasive patch... Confused...