Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Wan Jiabing <wanjiabing@vivo.com>,
        gushengxian <gushengxian@yulong.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all
Date:   Wed, 18 May 2022 10:16:16 +0800
Message-Id: <20220518021617.10114-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o7yOdzth9hkr21/jTxAE1E9iYbiN4rphs1rPH4SBa1P8l96vLVxBemD1E8p6?=
 =?us-ascii?Q?x2eWO03EBJHSncGNZm6psQMroUgwAvp9EyiLWns6fXTWCutR0SnZMLIwBxhu?=
 =?us-ascii?Q?6kg5dCxRXIDRTjXmPCrJG0jTlF1+O75IL/NnVnzDm1t5ywt126oeTVBu/LYv?=
 =?us-ascii?Q?CE8pbrYuB1QfDulvEc+9xrjXP9nm+3gnu1rciliTpo8MQqI4wLg3QcEI9hLr?=
 =?us-ascii?Q?uKxyJKmFiKrmnRHa3a6pPulIRA3RBQDJf7SqFlt6AZqIpyR7AOumUrT5zJUd?=
 =?us-ascii?Q?+AHI8CKO0H1jTGZx8iVQtCEjYuNkIgqKw7POxtbt1DAbGgllsRXU68U/y0sU?=
 =?us-ascii?Q?nObAiQilWRpRbS9xg6Cenm/FddGnx8SenZ2bTuQ8bJZRqafvruX3yh+O/7XQ?=
 =?us-ascii?Q?gb6LtPQHC+JWdQi66SAyrRVGdmwriN9/k34nZpsh35NmhjObzvrt8LC/rWyF?=
 =?us-ascii?Q?M8Fo/qEJzxf81RIOz4O/SRu+lEb4Rz6upu+GwoNYyNpGr19J0Schqvujl1hk?=
 =?us-ascii?Q?6DOwRZlvs9nYilTBK+71zaW7NMi1WiXz4yiSnDHBSWyd/C6zbaLBoJfWsTk0?=
 =?us-ascii?Q?k+H15Wom0ao0OOleVXd2n9sAiUH8T9IAkTqWNEsYraeAOy4eYzgRee9CmW1t?=
 =?us-ascii?Q?BNic3SISqlzUSg28/BX87kJTHpNB4TteiNRJIfIF40TS43WXcpvRZfnpUVYp?=
 =?us-ascii?Q?V9U6Xp5bGPt/rSILosWNIN4StGjcLwFX1VRQeVZlEzhOhY3jQpB9HTzXUGCV?=
 =?us-ascii?Q?slcqKcyN9eoB5lYWk4gNdzmtFu/DE4zcH+y8Q3t2uqlQXfYHIewsz3/XeoZa?=
 =?us-ascii?Q?LKK62MOdKxgUt3cHpWjnfT6Y3I8mQ98KJV+CdsBEor1bow/gFSkMwENoyBrw?=
 =?us-ascii?Q?vcKylgmWsf94U/5w+yFioHM7ykyKkR/pggQyNc0ibF22BJq3qWo/33+0pPvq?=
 =?us-ascii?Q?a4kzGUgLEXnYj8dK5Gr6ocqupobQIF2HqpuPGS3on18wlsaJwWPW3EjYb676?=
 =?us-ascii?Q?YkoLV+16+dTWv4yFgheOG89D8uBcyqbZUgLnaH2H6kb+6qfDCTtRe/vsY8hx?=
 =?us-ascii?Q?DLYKN05mSuGpoxJUKIQBkWKqqQu75go9JHGRiyptmMulqxuwce8CJJ92bEC6?=
 =?us-ascii?Q?+zqyVvaz3RsnR2Tchm+oejOnQtDA6cF7mI3yjHDIfKzDwSvYQZjFuZA2UFeR?=
 =?us-ascii?Q?vobfut+eVkt767CI1PaNCdY2TL+cYCh62qZbIe5Xhw7jWvFurNV86F/rYULO?=
 =?us-ascii?Q?n2QlwjEUy9dLVo8zOMkw43R07+qMMZvnaZ8t2vOcL5vyNeDKnM1c2aW/bElk?=
 =?us-ascii?Q?qywnGDzeM4qG3zyYNaSm2U08XqyqNKy0kNosBhtewQHvhmiJTJDv1upgtsrq?=
 =?us-ascii?Q?N9i+YozcskpbfEhdmIF7fSDon/s9cETNT11XOmDxBV5eY+qu4e44euUZkC91?=
 =?us-ascii?Q?uhDSUHUkzdK8s2hEMhzJN6xJ6gtq8cwOQKDqfI7ql3Y7/R9KKvtnFqHsDwgo?=
 =?us-ascii?Q?Ke3ed5FuReZehRPtSnSn9jKNeBXK/1R/D2p0Kd/3XdeLrR5SQRRaMetn0QPk?=
 =?us-ascii?Q?xXis2VE87vWSBBNLfb0XzeWsrg/U1B2mrfPX+vEdFzJN0CG901bE8+O2X8Q7?=
 =?us-ascii?Q?ZeG6TdiVEgr6B3WxohYHyRLRF0eRTJZjriELC/oeni13HBZ81vNrcn8f7yHT?=
 =?us-ascii?Q?CsfihxTUOHMQBl6mcii5HBVlKmCklZbaYFnZ/K7+Gm6NbROkfiqE4lFsp+u2?=
 =?us-ascii?Q?KCkQJjYoOQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8912ffea-101a-4e5a-3831-08da38746d8e
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 02:16:33.4401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w12OCxASwuUC8mbFGxP3vLzTUYrbI/8Za9ULUnhokb+fhP95amCa8NS/7yzRr1+F7oMIouM9K2zICD50O1YoOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4525
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck error:
./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671.

Here should be 'cp' rather than 'ip'.

Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 sound/usb/endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index df5a70013a85..f9c921683948 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -1668,7 +1668,7 @@ void snd_usb_endpoint_free_all(struct snd_usb_audio *chip)
 		kfree(ip);
 
 	list_for_each_entry_safe(cp, cn, &chip->clock_ref_list, list)
-		kfree(ip);
+		kfree(cp);
 }
 
 /*
-- 
2.36.1