Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 07:49:53 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Mark Bloch <mbloch@nvidia.com>
Cc:     Rohit Sajan Kumar <rohit.sajan.kumar@oracle.com>,
        "matanb@mellanox.com" <matanb@mellanox.com>,
        "dledford@redhat.com" <dledford@redhat.com>,
        "sean.hefty@intel.com" <sean.hefty@intel.com>,
        "hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
        Manjunath Patil <manjunath.b.patil@oracle.com>,
        Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5: Add sysfs entry for vhca to
 /sys/class/infiniband/mlx5
Message-ID: <YoR68a8aN5Ld5Jv7@unreal>
References: <1652137257-5614-1-git-send-email-rohit.sajan.kumar@oracle.com>
 <BYAPR10MB2997DF974EF3631A2E69CA3CDCCA9@BYAPR10MB2997.namprd10.prod.outlook.com>
 <Yn85iFNS96yO2ISD@unreal>
 <d37309bd-c7e0-8e15-bae9-9341f4f9192d@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d37309bd-c7e0-8e15-bae9-9341f4f9192d@nvidia.com>
Precedence: bulk

On Sun, May 15, 2022 at 10:36:07AM +0300, Mark Bloch wrote:
> 
> 
> On 5/14/2022 08:09, Leon Romanovsky wrote:
> > On Fri, May 13, 2022 at 05:46:16PM +0000, Rohit Sajan Kumar wrote:
> >> Hey,
> >>
> >> Sending this as a gentle reminder to review the patch sent earlier this week which can be found in this email chain.
> > 
> > Patches that sent in HTML format, to wrong addresses and not visible
> > in patchworks/ML, without target net-next/rdma-next/e.t.c., with wrong
> > title are generally ignored.
> > 
> > Why vhca_id that returned from MLX5_IB_METHOD_QUERY_PORT is not enough?
> 
> The driver returns that only when in switchdev mode.
> I don't see why that can't be changed but that's the state today.

My guess is that it is not needed outside of switchdev mode. This is why
I would like to know why current solution is not enough.

Thanks