Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     YueHaibing <yuehaibing@huawei.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        "paulus@samba.org" <paulus@samba.org>
Cc:     "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] powerpc/book3e: Fix build error
In-Reply-To: <8b169642-5d32-4135-93a7-4969515d1ab0@huawei.com>
References: <20220517094830.27560-1-yuehaibing@huawei.com>
 <0e8b7931-9bfb-1948-c141-c4e612ba0fe6@csgroup.eu>
 <8b169642-5d32-4135-93a7-4969515d1ab0@huawei.com>
Date:   Wed, 18 May 2022 14:50:34 +1000
Message-ID: <87sfp7o351.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

YueHaibing <yuehaibing@huawei.com> writes:
> On 2022/5/17 18:45, Christophe Leroy wrote:
>> Le 17/05/2022 =C3=A0 11:48, YueHaibing a =C3=A9crit=C2=A0:
>>> arch/powerpc/mm/nohash/fsl_book3e.c: In function =E2=80=98relocate_init=
=E2=80=99:
>>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration =
of function =E2=80=98early_get_first_memblock_info=E2=80=99 [-Werror=3Dimpl=
icit-function-declaration]
>>>    early_get_first_memblock_info(__va(dt_ptr), &size);
>>>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Add missing include file linux/of_fdt.h to fix this.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>=20
>> Thats for fixing that.
>>=20
>> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>>=20
>> It means we don't have any defconfig for 32 bits booke with=20
>> CONFIG_RELOCATABLE ?
>
> Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/=
configs

It's selected by CRASH_DUMP, which is in ppc64_defconfig.

But it's not enabled in corenet32_smp_defconfig which is what I build,
or any of the other 85xx configs.

I guess it should be, I think it's true that RELOCATABLE=3Dy exercises
more interesting code paths?

cheers