Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp165607iob; Tue, 17 May 2022 22:30:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3BC2mDrdgzwDXdaNduX3sdNtWYxlwacUOYL9GgkGre5DbCkZM4qHNxOlH0sZSx1f4tW// X-Received: by 2002:a17:902:d502:b0:161:bc5f:7b2d with SMTP id b2-20020a170902d50200b00161bc5f7b2dmr2927655plg.140.1652851823464; Tue, 17 May 2022 22:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652851823; cv=none; d=google.com; s=arc-20160816; b=e1xhI8FnTRM3G6Ifho0kDEzRAn7flfMrrWc2u5N+rDNxF988Z79HdsuiwhSeFzfLiY W+KU4bFDCrb2P5yRpT5arKc8I9M4G1uPHJW729Y7jQRHkk357uDEj7kqs1CJAjlf47AK ilF/6kX3n5tlX7IwKf2XRAydhUgw1OyvkwUWMP96BqYWVQMC/j8Y4qWQJd66HUQMU9NN yARyQjBMF0ptOY8nSej/3H2fNc3qpW1uMPm6PUvVH9eTAxXyn/J1T7C9kpeZJRtgzw0E sDTBy4zWxdCXaDTodD5S4TaRUeSoeZqSSfEQw8vHlIn8BNpc3nBOLRLrdByoS7ImW+03 UxGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=P9A6+JofltEFoj7YgsDM+78pjILvy+7P/odXSdgtbcY=; b=XS/8L5UQOQ4OInXdYcJauq3eaUX+gTUoJ6AgPM8tj1rlXEuA3e/YavcWiJjqckSI9d cf37TADdtx3y5HkeyKNd7K15IWAILeI/1hJiLU4i4qsUB4npCOMoVNI8J5LdiNHMYO5Y e4ray6iQj3UyE02MsIEqEdWVWAph4W+69BSltDeTSydxuUW+aMq23O/2yy1veURh69G1 mavxJujs4lJqF1CaSVZVTdwpkLxniQsNbeGITRyiCAzSIUiKq2Ztg6lZKQGy3f/elGKr 5m0vY69wdPgUaK7/sG3k0tqrPAIlREFQmEccM37z1GPwTRi82iUBmFAOGxm3X0uxRX3H fZQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 2-20020a630a02000000b003dba528c905si1469139pgk.324.2022.05.17.22.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 22:30:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 409F44475B; Tue, 17 May 2022 21:57:19 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230105AbiERE5M (ORCPT + 99 others); Wed, 18 May 2022 00:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbiERE5K (ORCPT ); Wed, 18 May 2022 00:57:10 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09C3D42ECD; Tue, 17 May 2022 21:57:08 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 22C5B68AFE; Wed, 18 May 2022 06:57:05 +0200 (CEST) Date: Wed, 18 May 2022 06:57:04 +0200 From: Christoph Hellwig To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , James Smart , linux-nvme@lists.infradead.org, Christoph Hellwig Subject: Re: linux-next: Tree for May 17 (drivers/nvme/host/fc.o) Message-ID: <20220518045704.GA30131@lst.de> References: <20220517194118.2caa01b8@canb.auug.org.au> <5958ccea-d89c-8b1a-15d3-19d8cacd141d@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5958ccea-d89c-8b1a-15d3-19d8cacd141d@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch that adds nvme_fc_io_getuuid need something like this folded in: diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index a11c69e681180..3c778bb0c2944 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -1911,7 +1911,9 @@ char *nvme_fc_io_getuuid(struct nvmefc_fcp_req *req) struct nvme_fc_fcp_op *op = fcp_req_to_fcp_op(req); struct request *rq = op->rq; - return rq->bio ? blkcg_get_fc_appid(rq->bio) : NULL; + if (!IS_ENABLED(CONFIG_BLK_CGROUP_FC_APPID) || !rq->bio) + return NULL; + return blkcg_get_fc_appid(rq->bio); } EXPORT_SYMBOL_GPL(nvme_fc_io_getuuid);