Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220518020812.2626293-1-yangyingliang@huawei.com>
In-Reply-To: <20220518020812.2626293-1-yangyingliang@huawei.com>
From:   =?UTF-8?B?5ZGC6Iqz6aiw?= <wellslutw@gmail.com>
Date:   Wed, 18 May 2022 12:57:12 +0800
Message-ID: <CAFnkrsmmn0ut2_9uJN3kS4uQGHuO0DONJveXvYm5oRMjKCoiZw@mail.gmail.com>
Subject: Re: [PATCH -next v2] net: ethernet: sunplus: add missing
 of_node_put() in spl2sw_mdio_init()
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
        andrew@lunn.ch, pabeni@redhat.com,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Yingliang,

Thanks a lot for fixing the bug.

Reviewed-by: Wells Lu <wellslutw@gmail.com>

Best regards,
Wells

Yang Yingliang <yangyingliang@huawei.com> =E6=96=BC 2022=E5=B9=B45=E6=9C=88=
18=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=889:56=E5=AF=AB=E9=81=93=EF=
=BC=9A
>
> of_get_child_by_name() returns device node pointer with refcount
> incremented. The refcount should be decremented before returning
> from spl2sw_mdio_init().
>
> Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
>   add fix tag.
> ---
>  drivers/net/ethernet/sunplus/spl2sw_mdio.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/sunplus/spl2sw_mdio.c b/drivers/net/eth=
ernet/sunplus/spl2sw_mdio.c
> index 139ac8f2685e..733ae1704269 100644
> --- a/drivers/net/ethernet/sunplus/spl2sw_mdio.c
> +++ b/drivers/net/ethernet/sunplus/spl2sw_mdio.c
> @@ -97,8 +97,10 @@ u32 spl2sw_mdio_init(struct spl2sw_common *comm)
>
>         /* Allocate and register mdio bus. */
>         mii_bus =3D devm_mdiobus_alloc(&comm->pdev->dev);
> -       if (!mii_bus)
> -               return -ENOMEM;
> +       if (!mii_bus) {
> +               ret =3D -ENOMEM;
> +               goto out;
> +       }
>
>         mii_bus->name =3D "sunplus_mii_bus";
>         mii_bus->parent =3D &comm->pdev->dev;
> @@ -110,10 +112,13 @@ u32 spl2sw_mdio_init(struct spl2sw_common *comm)
>         ret =3D of_mdiobus_register(mii_bus, mdio_np);
>         if (ret) {
>                 dev_err(&comm->pdev->dev, "Failed to register mdiobus!\n"=
);
> -               return ret;
> +               goto out;
>         }
>
>         comm->mii_bus =3D mii_bus;
> +
> +out:
> +       of_node_put(mdio_np);
>         return ret;
>  }
>
> --
> 2.25.1
>