Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp166827iob; Tue, 17 May 2022 22:32:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCCOSb+kXhmYs1jbu8osqOLs9RInpZ9cNrVql5gKTzcbfj2gvi8xoe1MCyNV5VESrOcxHT X-Received: by 2002:a17:90a:690c:b0:1df:3b6f:d073 with SMTP id r12-20020a17090a690c00b001df3b6fd073mr17240763pjj.18.1652851945663; Tue, 17 May 2022 22:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652851945; cv=none; d=google.com; s=arc-20160816; b=nTzTN6C8gQq8xezfUWAx7wzkDRb9R+xiUABe4C17tsgtJm72K7FrlT3SO0HFcJh0tn ZHtIri6TM6pZ8NXZlHTsZRy/6wu46hBiQQRzu1MGnRgeWjoXv2JULmO41ivfS6lhkqG0 o64lnIC3ZoXmGmZXzxJJbrm9cEXF3kHqAG3xwBMfqs1YG1v1zpmL2NqSbkeBFhQ4yhGH CJ6I5XHNayc1g74ofjvNx8rPbQLgg8hBFYpEcNUbXCw+jLiCFm6beV6nynRXsnXV8J2N mB7EGlXSvnw8tPgwqorfG/FbBcEQc76tHBK2ctLyxK7PDZjPuRGaObaNnMnf96L7SzO5 tMZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=I9YQWhyZX2/RpbjnCcry7qzZl2Hzq5L+6NYKhVenpOM=; b=VfcTwN/u56PppsTah+yiSHEQ+9ixPk96OxK+ba4kf3h58C2KTbYR+GczCyVxBhPEoB rsn7q0hDSIYJohM65Yp9SWW30mVhwAbWnlNDSVDbpDaKSiFLRtlmgdG/LcBgBeUfgRpF 6Ww8odE3/0/956wP0xEUgMXCZD/Hh2Q61nGSTn0ZwYbIb1LjKOPC5nz61fSbqJv325zB nks/FVDRd9A9oI66AlFotXTmUdvFO5+ME2ZNM+RSsNq6lJ8Mu5HLC7VEDjHjJQmZn+lf AMTtCr9OGSwUEymP3okL2iSWNSGGuNN3Pz+w2/lVanbJ7hU2H/PpJ/uaN41jrxceV8lf Hlpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=tqf0LLx5; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x13-20020a170902a38d00b00156bddf0f3csi1572297pla.53.2022.05.17.22.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 22:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=tqf0LLx5; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B8E172604; Tue, 17 May 2022 22:01:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbiERFAu (ORCPT + 99 others); Wed, 18 May 2022 01:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbiERFAh (ORCPT ); Wed, 18 May 2022 01:00:37 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE7A4BE2F for ; Tue, 17 May 2022 22:00:33 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id AD8ED1F390; Wed, 18 May 2022 05:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652850031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I9YQWhyZX2/RpbjnCcry7qzZl2Hzq5L+6NYKhVenpOM=; b=tqf0LLx5wQK9vqcmxoaxerYLMhj5VOkEtOAWfKlL7aeZCqheNaatorbiNveZZSJb6tLP8V +NzpwND0AgVwO1fr12HQ3FYoOwMfYQ+aExQX/d56QBmJ4s6XwurboazZ6RVcXKTH7QqKPd 0Qudsk0zWVfXI5uZRioqVKFwTvrG1I8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652850031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I9YQWhyZX2/RpbjnCcry7qzZl2Hzq5L+6NYKhVenpOM=; b=V1PgXNYF12XwKN/EeBAaaHHFvcnxWqxE1a1YFKTu3WbmgQdoY7ObkVrhw1yhBoeiaih/7U aU8gUN14KoKseyBQ== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 4E0962C141; Wed, 18 May 2022 05:00:31 +0000 (UTC) Date: Wed, 18 May 2022 07:00:28 +0200 Message-ID: <87bkvvv3ir.wl-tiwai@suse.de> From: Takashi Iwai To: Wan Jiabing Cc: Jaroslav Kysela , Takashi Iwai , gushengxian , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all In-Reply-To: <20220518021617.10114-1-wanjiabing@vivo.com> References: <20220518021617.10114-1-wanjiabing@vivo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 May 2022 04:16:16 +0200, Wan Jiabing wrote: > > Fix following coccicheck error: > ./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671. > > Here should be 'cp' rather than 'ip'. > > Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock") > Signed-off-by: Wan Jiabing Oh, that was a silly failure. Applied now, thanks! Takashi