Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 20.83.241.18 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.83.241.18;
 helo=mailrelay000000.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net;
 pr=C
Envelope-to: frowand.list@gmail.com,
 devicetree@vger.kernel.org,
 robh@kernel.org,
 linux-kernel@vger.kernel.org,
 yilun.xu@intel.com,
 trix@redhat.com,
 mdf@kernel.org,
 dwmw2@infradead.org
Message-ID: <c7e4e7b9-c5e8-9af9-6c16-2a8e0e7e61f7@xilinx.com>
Date:   Tue, 17 May 2022 22:02:04 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH V2 Create empty OF root 1/1] of: create empty of root
Content-Language: en-US
To:     Frank Rowand <frowand.list@gmail.com>,
        <devicetree@vger.kernel.org>, <robh@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <yilun.xu@intel.com>,
        <maxz@xilinx.com>, <sonal.santan@xilinx.com>, <larryliu@amd.com>,
        <michal.simek@xilinx.com>, <stefanos@xilinx.com>,
        <trix@redhat.com>, <mdf@kernel.org>, <dwmw2@infradead.org>,
        Max Zhen <max.zhen@xilinx.com>
References: <20220216050056.311496-1-lizhi.hou@xilinx.com>
 <20220216050056.311496-2-lizhi.hou@xilinx.com>
 <48b43291-b65a-0939-16ee-95b342e46377@gmail.com>
From:   Lizhi Hou <lizhi.hou@xilinx.com>
In-Reply-To: <48b43291-b65a-0939-16ee-95b342e46377@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Microsoft-Antispam-Message-Info-Original: fctt5Pzn1vT6O5mw1rsE0o1XMpwOJWF6kvkOoSA4zp4Vn+QPSibq+tHELdit4SNwBgJGJib4Rms9lVpU0KD9b6vb3aXsBiadgNGHHjtwp67RqZ2X1hc7ldIueBlX/ID0OsLVBT01XoXs0ZZGqeIvKI1ROypx5UEbk/PmLB/BTNCkOCK7o2wQyBJMrfifTQhLPtzhBXn+3lApwWvXXKXJVou5ejGEVzfuJoSMfKFxobeyAqY+cMP1oCmU4rYnbjjaQcQywmBp3BQRBlrhsd/VHRCYJu4H3R7mbxwOT/Nz1HsvoZLds/iNXjIUvc2dWr7/qNVYStD4df/VwzStOOLOCMzZJWdl+GkmpBFzr9SOLdi923GOo19kpfffvOv5rR9wNyZR5cV27PVc5y5P9MMm6vZlYXcCpGSmCrnN8IQ0J5tIfOVD+a7QddsfSycvvA2/GuqqZ5rs52k4DucByW3onffh5hvq4YspOO65i23P0D+/v5yOR/1swX9lxSrXojcoBjPwgYnNUTXV/qNUxPG1/Wnotzr2s0Yy6ribbAF/2U3KDm7pkPWcjWj/E10ZL8q3ifISrddtlFQ5GFduXk4KSMOiIU70MTMLmYfzMISzwg7dauvbFZLz0uaUHHr5hENP0fQS/Pv7Sl0Y1M68ybzcuKMFy5GTRUigsyM+Q6EgJVXCKuL+slH+TtpgND2IBVZkSyUEKFiaBlaU+XQRD+3WSbllijkUIMsjOXLhHK75TCHQ8SC67aRR1H4//zDSvzPv4HdlxeJD+xgJykSEV4RQ5Uk5pIHNSTDi+JNE9G84e8qzoOoxjT9D2Z5fCSGoV4TO3Y1KZDhaYCr0XufyN2D6lu8wplCZgBxqIauEK1gcatY=
X-Forefront-Antispam-Report-Untrusted: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(2906002)(36860700001)(107886003)(83380400001)(5660300002)(31686004)(186003)(2616005)(508600001)(8676002)(44832011)(966005)(8936002)(36756003)(9786002)(40460700003)(336012)(316002)(426003)(6666004)(82310400005)(54906003)(31696002)(4326008)(26005)(110136005)(70586007)(47076005)(7636003)(356005)(53546011)(70206006)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4413
X-MS-Exchange-Transport-CrossTenantHeadersStripped: SN1NAM02FT0041.eop-nam02.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 0fdb807f-7629-4e69-03f7-08da388b91ab
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: jYfFTSWQOoKwBi/usKqcg/EzXzj7CQR9TKmB2FV13cfzPJctNz1XIRcVqKCb6yveRZh1s8pL3wnuFuNO1iqE8m3ei1WtAUYx0x9F7xDrVadfjnx+LsYxW6buaPxFfYVA5VBvYTLY0bkKGY10/HJafH3S2Z849F6YdM6u4OAvzSW0ZBSKPtVU/Q3ZRZS8+angAnLMjd0d/SvGQpP1xWwmCmlPTM/TDOHRnwE8EQsU/q3k4yYyn6d+zhkGVfEklutp2u/3OtMQNEuXUX+VdXm7r06VgMQKtBtJ4lPhcip6mOxDDGv93K59zvMUc+p7xGo/twYW3HqfbM2JkiFL3duJUKIcOT0OjcsOAJ95l2Mh/Hpx7skY3fTGi0JgWjPGJnuOMPSQFuujuWf4cH/2YXszJX+VU0fbn4bEt5dr7Sq8WUML6kQ2ElzuJcPBBEfEro13WQahIQYPfk+USqTPKU0F0CP7Csjv/qC89dgsbA9KPuflkEPfGAGjydYiuYGv2r1IudlRv3cv8AvCoqcVdgRVgDdQJzSNp+X3K36eWsekqGS3xkBYT9HoKUMBwYaGMCRXfp1dUVGRRqNWKrJ1Xvt4MncpV7IWXR//sqJzBMFEMHirRdrKjq/HpHLLCBLaM40PtwpiBTP/jB+wVZrjMe7PdYSQMVW20RzwlnPkABAy4YC+keMt9uWmmFmtTmKSCC+HiPZOhCQCC3NmuuhfE4kJ1YcEsvgVoUum4eulsvu6VmrDjR9nb5aE2UFmvnZnxgy7XMcTNXzOXa/baura3af/waw/qzdk2DTVF8BcBaFhv+SR5v1vlXp8i0+3MdX297Dyuc6kT27x5ViaZBNC0MboWW04OXsmOjoXp7+gvnrIOS1vzxuEnTW58hygiTgs5hMFYV6cgFXdaWagWKd8DVeKLQ==
X-Forefront-Antispam-Report: CIP:20.83.241.18;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mailrelay000000.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(44832011)(8676002)(9786002)(8936002)(70206006)(508600001)(5660300002)(107886003)(36756003)(40460700003)(966005)(54906003)(2616005)(4326008)(26005)(53546011)(336012)(426003)(47076005)(81166007)(6666004)(2906002)(36860700001)(110136005)(186003)(83380400001)(31696002)(82310400005)(31686004)(316002)(50156003)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 05:02:14.8577
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 198ab51e-bb9d-4101-25a6-08da388b9358
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[20.83.241.18];Helo=[mailrelay000000.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net]
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1NAM02FT0041.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB5598
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/16/22 20:22, Frank Rowand wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
>
>
> On 2/16/22 23:00, Lizhi Hou wrote:
>> Xilinx Alveo PCIe accelerator cards use flattened device tree to describe
>> describe apertures in its PCIe BARs. Each device tree node represents an
>> aperture and each aperture is an hardware unit which requires a driver.
>> The product detail:
>>      https://www.xilinx.com/products/boards-and-kits/alveo.html
>>
>> Thus a base device tree is required. Then the Alveo card driver can load
>> its flattened device tree and overlay it to the base tree. However device
>> tree does not always exist. To resolve this, add OF_EMPTY_ROOT config.
>> When it is selected and there is not a device tree, create an empty device
>> tree root node.
>>
> Please run scripts/get_maintainer on your patches to see who to put in
> the distribution list.
>
> I recently stumbled across this patch series and the previous related
> patch series (currently up to
> "[PATCH V3 XRT Alveo Infrastructure 0/8] XRT Alveo driver infrastructure overview")
> when I noticed it in an email archive.
Sorry about this. We will use scripts/get_maintainer to make sure the 
required maintainers are included next time.
>
> A similar need of creating an of_root if otherwise empty is being discussed
> in the thread "[PATCH 0/3] add dynamic PCI device of_node creation for overlay"
> at https://lore.kernel.org/r/20220427094502.456111-1-clement.leger@bootlin.com

Thanks a lot for your information. We investigated on adding dt node for 
PCI device as well and got some questions.

https://lore.kernel.org/lkml/79e4c876-e5a4-861f-cfbc-c75ed1a07ddd@xilinx.com/#t


Thanks,

Lizhi

>
> -Frank
>
>> Signed-off-by: Sonal Santan <sonal.santan@xilinx.com>
>> Signed-off-by: Max Zhen <max.zhen@xilinx.com>
>> Signed-off-by: Lizhi Hou <lizhi.hou@xilinx.com>
>> ---
>>   drivers/of/Kconfig         |  5 ++++
>>   drivers/of/Makefile        |  1 +
>>   drivers/of/of_empty_root.c | 51 ++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 57 insertions(+)
>>   create mode 100644 drivers/of/of_empty_root.c
>>
>> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
>> index 80b5fd44ab1c..452d2316b47b 100644
>> --- a/drivers/of/Kconfig
>> +++ b/drivers/of/Kconfig
>> @@ -94,4 +94,9 @@ config OF_DMA_DEFAULT_COHERENT
>>        # arches should select this if DMA is coherent by default for OF devices
>>        bool
>>
>> +config OF_EMPTY_ROOT
>> +     # driver which requires at least the empty base device tree to
>> +     # overlay its own device nodes should select this.
>> +     bool
>> +
>>   endif # OF
>> diff --git a/drivers/of/Makefile b/drivers/of/Makefile
>> index e0360a44306e..c65364f32935 100644
>> --- a/drivers/of/Makefile
>> +++ b/drivers/of/Makefile
>> @@ -12,6 +12,7 @@ obj-$(CONFIG_OF_RESERVED_MEM) += of_reserved_mem.o
>>   obj-$(CONFIG_OF_RESOLVE)  += resolver.o
>>   obj-$(CONFIG_OF_OVERLAY) += overlay.o
>>   obj-$(CONFIG_OF_NUMA) += of_numa.o
>> +obj-$(CONFIG_OF_EMPTY_ROOT) += of_empty_root.o
>>
>>   ifdef CONFIG_KEXEC_FILE
>>   ifdef CONFIG_OF_FLATTREE
>> diff --git a/drivers/of/of_empty_root.c b/drivers/of/of_empty_root.c
>> new file mode 100644
>> index 000000000000..5c429c7a27bd
>> --- /dev/null
>> +++ b/drivers/of/of_empty_root.c
>> @@ -0,0 +1,51 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2022 Xilinx, Inc.
>> + */
>> +
>> +#include <linux/of.h>
>> +#include <linux/slab.h>
>> +
>> +#include "of_private.h"
>> +
>> +static int __init of_root_init(void)
>> +{
>> +     struct property *prop = NULL;
>> +     struct device_node *node;
>> +     __be32 *val = NULL;
>> +
>> +     if (of_root)
>> +             return 0;
>> +
>> +     pr_info("Create empty OF root node\n");
>> +     node = kzalloc(sizeof(*node), GFP_KERNEL);
>> +     if (!node)
>> +             return -ENOMEM;
>> +     of_node_init(node);
>> +     node->full_name = "/";
>> +
>> +     prop = kcalloc(2, sizeof(*prop), GFP_KERNEL);
>> +     if (!prop)
>> +             return -ENOMEM;
>> +
>> +     val = kzalloc(sizeof(*val), GFP_KERNEL);
>> +     if (!val)
>> +             return -ENOMEM;
>> +     *val = cpu_to_be32(sizeof(void *) / sizeof(u32));
>> +
>> +     prop->name = "#address-cells";
>> +     prop->value = val;
>> +     prop->length = sizeof(u32);
>> +     of_add_property(node, prop);
>> +     prop++;
>> +     prop->name = "#size-cells";
>> +     prop->value = val;
>> +     prop->length = sizeof(u32);
>> +     of_add_property(node, prop);
>> +     of_root = node;
>> +     for_each_of_allnodes(node)
>> +             __of_attach_node_sysfs(node);
>> +
>> +     return 0;
>> +}
>> +pure_initcall(of_root_init);