Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp169152iob; Tue, 17 May 2022 22:37:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSROojmaXT/HD3HP8BijOdXEp8OBUK4QrEoeofY7WcER6XLgcHbJSaxty3zc2fy/fjzJTs X-Received: by 2002:a17:902:ec83:b0:161:ab37:7ad3 with SMTP id x3-20020a170902ec8300b00161ab377ad3mr6151497plg.114.1652852225710; Tue, 17 May 2022 22:37:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652852225; cv=none; d=google.com; s=arc-20160816; b=Z0b+RYU20rcmdv2E7gMN/G3izQHQ6OZ1dKn4Akyf8V7w+a/LVnS+1/OL63E5qCF8pj ElqCVJoxDKEH6HEaupNEinc+J8LIw2yEIxGLp+5EHOjk8hjaJSOgiqTr4ssSEx+ZNH2F ulBN47u/ggs/SSzMkt55VWZY3Ls+xlVRkZIzM9kjX2rUqqRzHkS4yx59iTt0CzucOB+5 q5yAEfe94DU7/cOgiCteSCLyUsvi2MfnP8C67cAB6lJQfqSs0TRlFcSJVFHeVw9JOfmm h6D9/XeTvmZo7WyA/9nhv1wIZKuFHmLJe+/Sqnc36IevqmhcUvTWnV5pomqz3e6Uh9W1 9iNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=KZmmmLKIfUyqU4ERMkQqUnelPxHzP53HsoTRK7Tlr2c=; b=soOdxDGs7v24lZWgcF6lax/hFBH5cN1lFaOi7pt9/jYptLZsyXlusOkuUeNtmBY0jg yiJPzsBcdB+RCjXp4mNvOau8S8Dp3kaM82+MlbCGltwjWr4/Kokebuh4x6+7FIF2iGlq dBBOCVPyssPDTeuD0Uf8X8kj/yh2vKaZLLG1xJTfYOkVo3p7ezRZmRf7AzZjVPMAVyYu WsSKxGwMkJ3Pm8tQSQChgbV7Uqo4e5OBgwWrkZhbpU00NtsLgOxBUYEt4i/vu2YHJb+X cJIDSLPKAgXGjtEwW506kclrEByRAT2QFvhx8QfR72bko2H9i9Z+c/MCRHeUjFMi02d6 SrDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eBqtamRF; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id oa15-20020a17090b1bcf00b001df621048f4si5980077pjb.10.2022.05.17.22.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 22:37:05 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eBqtamRF; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 97C11F03; Tue, 17 May 2022 22:08:35 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230124AbiERFI0 (ORCPT + 99 others); Wed, 18 May 2022 01:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbiERFIY (ORCPT ); Wed, 18 May 2022 01:08:24 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29BC64A3F5; Tue, 17 May 2022 22:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652850502; x=1684386502; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=g+iSTe6Mh+en0o6j9xQzuQH9px9l+PlOCzYWCb780jo=; b=eBqtamRFnHkNt1LR3DshquHMN/hRQZzIHiMJ4qLjg0LOazSM9K19YsHR 7GDPVHZe279O8Cey273f0rv2M3BF4n3Egz4j3TQlYV63eD11RF0WurPG9 nX0h2rQ5wk0VL15E65OrlpXaPjZgwyKPYcWuQ+zj9a3w9uTZkdZlSiTVx oY7mhhBSnrX0JVkbTfwOsOktA6C3mLqINe2b6Z9FYBAONgShHFKBG9vMr lbHvmD5DgD36T6hmWVzpzQKCtoESlZc1ymmsdTB7oxJui5yizHRXVD/Up ggZr0Rdoe8pHY2qm9aKToyJXSHeMjWpLZLXK5rDFIEMfjRrxh0FP+Dn4Z w==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="270307435" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="270307435" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 22:08:21 -0700 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="714226200" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 22:08:19 -0700 Received: by lahna (sSMTP sendmail emulation); Wed, 18 May 2022 08:08:17 +0300 Date: Wed, 18 May 2022 08:08:17 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable Message-ID: References: <20220517163820.86768-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517163820.86768-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 07:38:19PM +0300, Andy Shevchenko wrote: > +static const struct irq_chip intel_gpio_irq_chip = { > + .name = "intel-gpio", > + .irq_ack = intel_gpio_irq_ack, > + .irq_mask = intel_gpio_irq_mask, > + .irq_unmask = intel_gpio_irq_unmask, > + .irq_set_type = intel_gpio_irq_type, > + .irq_set_wake = intel_gpio_irq_wake, > + .flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE, > + GPIOCHIP_IRQ_RESOURCE_HELPERS, > +}; You still have the inconsistent alignment here.