Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp195707iob; Tue, 17 May 2022 23:30:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGiylXFX3x/KELol6Kkb7BbSw0ZG/U8QILTCKE2LnGOPJRFRoWSRoleLgHSMCcPn+8o8gw X-Received: by 2002:a17:902:9345:b0:15f:186b:e478 with SMTP id g5-20020a170902934500b0015f186be478mr25910642plp.117.1652855433689; Tue, 17 May 2022 23:30:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652855433; cv=none; d=google.com; s=arc-20160816; b=J7nDkXw99ajxLkIoNBluydb77PMruvK63hkjP+x0AsdjoxYpUrJZinIiCBBy/P840M /TtYaD3aWp0sNuzN1yVBDTpCmwTsqmBggsuQmEUy8A54tdHGI1H9ttoK+2YUxuqkw5/T fNbRaisSco8MwTcjyoxkGf5UVe0nFjl3x7657DiKnZqqnCQPB52TAYV5nz+ju/dBVDY3 rqY87k4VexmU8svUY9NQ45pfs5q/J+AI1SEgO+n3UDfZq3tSE2golAwww+f2Gb5rJyB0 xUcMyphFR/70140Q8mfCm+yVQzTpaudrA1yUZ6ueSJCJCOGqJtjqWWlqa9QK+IQQObqo J+PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=RIeoYLoCawjr8OpcRy+8RXVUl2WmZaXE2ovsv6gD3jM=; b=X7MSzZD1jAgdAmYCXTf5hJ/XbbXWufHtLefxjRH7KDWsl9AfkAFdbAvEko53b5blH9 6jGfBoaTNPfpf4qtl6hFgDGRqwqKdjdWzPeuA+F9LbKiFT08sykY59+4F+SSZsln4pRp 3lSBWsLVDCRJZIkFkms1mGJW0u/AElpTlDsPclehZWZlz1DNjTXx2Kt21RiOYEXibbvF kJK1RdSpEAIPR1IQQPL6bC3bslP9M0Uzk7pdfqeUmk3Gd7mzgz8PYwpAOTz+iuxivnzw ALd9n/TxQgboeQ4CoWTWdIfQ28PFGPeN0Fkg4HqRl6fB8GYHfhw3aRpsjOHu/hm4TN3E c/cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HVpk4jDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id c16-20020a63d150000000b003820b4f8361si1601142pgj.182.2022.05.17.23.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 23:30:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HVpk4jDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3F896E15EB; Tue, 17 May 2022 23:29:33 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbiERG3Z (ORCPT + 99 others); Wed, 18 May 2022 02:29:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230512AbiERG3U (ORCPT ); Wed, 18 May 2022 02:29:20 -0400 Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0D99E15E1 for ; Tue, 17 May 2022 23:29:19 -0700 (PDT) Received: by mail-vk1-xa2c.google.com with SMTP id b81so671918vkf.1 for ; Tue, 17 May 2022 23:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RIeoYLoCawjr8OpcRy+8RXVUl2WmZaXE2ovsv6gD3jM=; b=HVpk4jDiYKpcrU3F7PfpRsPgcA3B5SNbD0HdcyxPxjdgfPBfNvqhfiwg49kOsyu9dF m+fststC/MoGohWdD2sePs1rWc80DMLkG3fR7IrynJzRvi6h24/NKUWton3psSSJOfg4 ZMEPHd46g83k7TBRN6m9txwle0WdxcbBwG76BFzdzh5XZYOb5nO/ih8F63asNdicup0d Jq8bWZ9cx2tKluss3Z/mDUBbhve49vU3ffvN9t4D/gt3M4eGo05NDVjemOenaF+6eX26 dG7GFKfxTQ5Gwlj4M58Pv6HgMKjIbagG0vQItm0O4Uno0ixoXYnuayZ6pHL/Qu/YBiMG VQ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RIeoYLoCawjr8OpcRy+8RXVUl2WmZaXE2ovsv6gD3jM=; b=EV2x3geC19nHG3yW+M1d4E+z0CqANFMbSs9E3tOMRU6Wfnwfo5qzUV9MUy20dQtFKY FsKIP+lc9IrgfdWYuqZwzxEX1kuEW04/AClnZp6d/GT7ryel+HckTTpftZPb0ltaP3vQ ZeCOlG5/F+q+xfe5I7qLNBL8bgg9UOMFGTCtE/XQpW4jaqpKp+rNwNvx2ySNiGs9eb77 WIpdWWGaPO70rFYiULELYE4KgqI8bShqpRpHlzBDZT16ePUiH12QYtJEdbnhzb1v9XP+ ASp4snoEl4qAZkZOz4ePqLkOvegFypOjDucf80LCX+DLYcPEboWBdASzSgf0La1iYHXy 3zoA== X-Gm-Message-State: AOAM5318o+mEBk+gZ8/H3gdIVFxYu1re8pr/i5InUA3MMmKyByK/PKYw aj5gJ2wT3r5RYaX5oKPQzqKRR1fsFEOR5VnItic= X-Received: by 2002:a05:6122:a0e:b0:352:1914:b7ae with SMTP id 14-20020a0561220a0e00b003521914b7aemr10166403vkn.10.1652855358560; Tue, 17 May 2022 23:29:18 -0700 (PDT) MIME-Version: 1.0 References: <20220512034652.61134-1-linmq006@gmail.com> In-Reply-To: <20220512034652.61134-1-linmq006@gmail.com> From: Romain Perier Date: Wed, 18 May 2022 08:29:07 +0200 Message-ID: Subject: Re: [PATCH] ARM: mstar: Fix refcount leaks To: Miaoqian Lin Cc: Daniel Palmer , Russell King , Arnd Bergmann , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le jeu. 12 mai 2022 =C3=A0 05:47, Miaoqian Lin a =C3= =A9crit : > > of_find_compatible_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 5919eec0f092 ("ARM: mstar: SMP support") > Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 S= oCs") > Signed-off-by: Miaoqian Lin Looks good to me, Reviewed-by: Romain Perier