Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 18 May 2022 09:49:59 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: add check for kzalloc
Message-ID: <20220518064959.GP29930@kadam>
References: <20220518063024.514280-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220518063024.514280-1-jiasheng@iscas.ac.cn>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3QTtIwD7rZZ1P9USCMt0t++FM6al95hcR8kzz09zefEyQQCy8qTeq46tzrBi?=
 =?us-ascii?Q?sDkHr+UYyaGOzjTMGlKU1wy1P5FzeOu3NhvGZKn2bhKzjDL4RIzqObLuA/2Q?=
 =?us-ascii?Q?j4cK9aIHH+Cv266QHUs8HD3IuxLk4/bz9TapjlmvVoN+wzY7ClTZo+tP6qWj?=
 =?us-ascii?Q?QXWJhD8lE7h1FZEJfsG80KJau60CRtKAgYmN5XvGO5Cyrc1n/8OTW5SluA1g?=
 =?us-ascii?Q?7Z0JJm/QlZV6+DyxVOf0x3SO6amvqn7JjISS4gD/PFnB94xP0shJyMnl9LfV?=
 =?us-ascii?Q?Xq7OUC2uZyvV3LCJEEvfNIHpAwly3+pm1a5dUKySJ/3e6yKZQkfR+SRnCd3v?=
 =?us-ascii?Q?RoNKaj18YHQYnQHTiqWEIBBdZs7mPO7esavzxyETLWTd+mTU3mFuY3vuqkHM?=
 =?us-ascii?Q?0VhoaPpDk5I2MmZGHlmoMxcaubTGMORH4SOk1IaHqwAdFls6t90yGfoCzFt1?=
 =?us-ascii?Q?75Bs0IM/bjpgqfrrg9px1+4A3iE9QOP1qCW/aKDlZ27OHH9/XLuuUx6Qt0+w?=
 =?us-ascii?Q?x+ZSPchpv3RJMSpeKl1kzpCWJF+/DDs6xvyGIc9mIwaUjB54ma8VZuwRlyVq?=
 =?us-ascii?Q?XcIWzk7gbny538BkN0Q0CJwB16lBxe4cLyj3LDmSE2Fb5iPhqwbWOIeQTt62?=
 =?us-ascii?Q?ye1uO0CWxMXnkXa2dq48WpPs7f5ABBgkEVc2C8uRU1BYE1Thx71DVC1hxldc?=
 =?us-ascii?Q?6Eo0mBeSktsML2g5Gee5lv/YjnkiNmf8In6T/JOhMka90IC1NW73a+QpgrIq?=
 =?us-ascii?Q?yCnQMTAQeM5C1nsafRtbB0qHCZO0esntPvnpTRPb2ebh1hZt0ZmRzxATsXgo?=
 =?us-ascii?Q?+6bPy/elzQFBj3YL+7kC9vHG+r99J4uFJpFQP13Ekyfz+gaiqC4H8xYk9pfQ?=
 =?us-ascii?Q?Qk8cSneNmjuTCQr29n7jP+IvhNT5ff1AngaCQ4OfqTY0VYKZcAgxmdplHNcI?=
 =?us-ascii?Q?AZ0jvOxGrK3kUX6jT1RpCrRYYr0+fRjtY0jfCSn5KVYZpCAdLpsvbL5VrEqt?=
 =?us-ascii?Q?AWTOmyIoDFjDKRbqIo5EAsMZ7pCELzH2cNCKJIgCx8ZU+Zp900LkNX7yLuoQ?=
 =?us-ascii?Q?51qx4EI8IInn3P3SivTnW7NNezIHSsSo/7F2PxY0IpzFLH+7jrYdMrqE2Bq2?=
 =?us-ascii?Q?OzarO2Zv7Af0tWVSb7jcsrXdLvoX0t8KLLtWApRtbfiSbzi0aLZwm0BOw2Bd?=
 =?us-ascii?Q?aXJgBmcDGgVXv84UBk9x6uUdSWso2WXKmBfYzperpvpFPdHYGwHEYA8kf1j4?=
 =?us-ascii?Q?UIuwRFDxkKKWcNwZb7rW/q7hj9+ydY7aPMwfqsLd9qC9He1bedAxDB86f6W+?=
 =?us-ascii?Q?1uRe/SChe3rn4RrkVFiZPaI4/eAbzTfY54jjzW3v6zKPSDxx0wN2sGCKLORI?=
 =?us-ascii?Q?jJqG4VcWbw58ne2B97UmI648/yWJLlDy55Mj1rmiRd1jd+AMNjeHhbiZnfeo?=
 =?us-ascii?Q?M42bNTL5SiqOOwEe3cqj1/oP1Bozd2zRNdmBpIM5uyWpawXOoAzIyX00tOZh?=
 =?us-ascii?Q?s6h+rmvXMmFU/IX7dpPWQMkzzvIpShON5kP1pAQ9aZPen42itEyJW2ER+ygY?=
 =?us-ascii?Q?6JAG0ZAtyqIWjO0QzCfnhLzfjAGkn2zf1l3EeJXPP+QZybUHN5G246icB9nk?=
 =?us-ascii?Q?ybkfiFuLcERvtrYbs1Isv6xPIuLUcHjCTi7GpVHMHECaInCNIrOr9tK28zg3?=
 =?us-ascii?Q?Oeq9sOrql48BRyvrtBNuKwFzDiMjRj2bVAOSfxcW9KLrVvR4sd4lItn1V0+9?=
 =?us-ascii?Q?3gT0U4B6TIQgz4BZ9lHRWTMvqgIsvM0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3df0540-5faa-4d46-8c49-08da389aa6b0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 06:50:10.0928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WesNqB34wDnjrMFAzBvEjYEgbfNvlqxVBLD67h2sD/U0LUp1jFF98rxLhz5CPHXHw5cELBu9WAXRbiFnLX/dwPg47MMUTbiL50BytV4XxnI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2642
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-18_02:2022-05-17,2022-05-18 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0
 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205180035
X-Proofpoint-GUID: cYUhx2mlCFKtZsL67o3zuv8bWLJciwzO
X-Proofpoint-ORIG-GUID: cYUhx2mlCFKtZsL67o3zuv8bWLJciwzO
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 18, 2022 at 02:30:24PM +0800, Jiasheng Jiang wrote:
> diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
> index c2a550e7250e..0b3bcfbf22f7 100644
> --- a/drivers/staging/r8188eu/core/rtw_xmit.c
> +++ b/drivers/staging/r8188eu/core/rtw_xmit.c
> @@ -178,7 +178,10 @@ s32	_rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
>  
>  	pxmitpriv->free_xmit_extbuf_cnt = num_xmit_extbuf;
>  
> -	rtw_alloc_hwxmits(padapter);
> +	res = rtw_alloc_hwxmits(padapter);
> +	if (res)
> +		goto exit;

Unfortunately this needs to be:

	if (res) {
		res = _FAIL;
		goto exit;
	}

Eventually someone will get rid of the _FAIL garbage but for now the
caller expects it.

regards,
dan carpenter