Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp234633iob; Wed, 18 May 2022 00:40:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOQ8FJXff5pnzSiPE6GXWoIq5II0DMDfyRnre9+ge52pL5wZ3DHCRv3llj+ASV+Td7keeD X-Received: by 2002:a05:6a00:21c8:b0:4c4:4bd:dc17 with SMTP id t8-20020a056a0021c800b004c404bddc17mr26328628pfj.57.1652859608991; Wed, 18 May 2022 00:40:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652859608; cv=none; d=google.com; s=arc-20160816; b=vr5vJa9FYrTWnf/NmiKXe8KRz3UeADmbRrzq7MCMlfXHiwE0c+WXAktruHUCKw+6N8 GALRYgXthJ8S4m9kTZoku39s1s+gPUN+E+ZwR0+4IWssqKbnjMIvaGGIF6B1guDM4O44 NXTIHgZVBr2eJBSvsDSmG6+ualTkUlbopWvLjqzqKe031uahrW8077aGjyIstGTYLI90 jIkkD75U2QMqR75RS9NeB3iinK9U4fWfvlB+qAjL4gZ5fyf0riiXYhXAV7BelL0VsBly Jizo3mQCqkthEz35DDZnvtTG+TlSKkRDbcV50u9KQrm97K5W0Xye4EAfkLFuYRhHfIVA ApLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=P5UqBAHM0WQnE0g9GWkUw6qeNdkfJBe6hJymXR6R360=; b=0egOkMWJFdTuCsSXxpCvl3qswdTzCIyrV9bVF00K2pYbOEi6+6QBZwZht/XNHS9qHd sKA0tfUH5DwXNtq/4MTTALTUpz1m+gA2FxBneXD1nGaNRPTj3/bPXbKRQBb80KDGtTpm UuDe7X6Hxi5VVNTu/Ctv/4r+MbCxxRr/ij4Z40xp16yEML9GJ6QWLO+VbFlFl4PrNHNt pi5Kn86xWDFo+kwbiX3krXfLwy1bDrxk1Bn7BGNZkG7xtwfqKJIoIoBmPxa6ovBFsM1a 7Y3OdqYL3GvAvjFQEfQr/XnScDPFKT+rlQsBH53fTQHVJwfgJRQa7CsnxGq6tjzADdtR 3EMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=zP2u3zx4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b9-20020a170902d88900b00159071f2c80si1693691plz.593.2022.05.18.00.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 00:40:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=zP2u3zx4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BC094118023; Wed, 18 May 2022 00:40:06 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232350AbiERHkA (ORCPT + 99 others); Wed, 18 May 2022 03:40:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232348AbiERHjy (ORCPT ); Wed, 18 May 2022 03:39:54 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9C0106A47; Wed, 18 May 2022 00:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P5UqBAHM0WQnE0g9GWkUw6qeNdkfJBe6hJymXR6R360=; b=zP2u3zx4Nqx82fjyBoNHLz6AOY fHpXQJ24sWyjJtbHiAfCUHkKqWlu+/N5+S0QbL3dxp8min4ZnwWiMdlFcvfoW1l3rHL6lvSU8JyPu tI3TV57NNnj4Bq/keqxZOTeeF9+9ZA4sWjS7BtUPWhT9DC+xFJLcsYPpuaji0p2/Oxwir7jvsuX/U y9dpkmCJOjq2ER5XK5/faIeJxiQU9bZ+mnUsplo/ChCMm+unL1KWLS94bBjJDlzxjHqeD1l6dxzdJ VudQgLy9jb8GOsrg3Fazw16gK5iNYGZFgwlNxo8CYGkPD+FAuZ8uZSZp9jKMhuX8XVLWsUSQokF10 K34xQl0g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrEHV-00084D-Sx; Wed, 18 May 2022 07:39:41 +0000 Date: Wed, 18 May 2022 00:39:41 -0700 From: Christoph Hellwig To: Jason Gunthorpe Cc: Matthew Rosato , alex.williamson@redhat.com, cohuck@redhat.com, borntraeger@linux.ibm.com, jjherne@linux.ibm.com, akrowiak@linux.ibm.com, pasic@linux.ibm.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, hch@infradead.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM Message-ID: References: <20220517180851.166538-1-mjrosato@linux.ibm.com> <20220517180851.166538-2-mjrosato@linux.ibm.com> <20220517185643.GY1343366@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517185643.GY1343366@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > if (device->ops->flags & VFIO_DEVICE_NEEDS_KVM) > { Nit: this is not the normal brace placement. But what is you diff against anyway? The one Matthew sent did away with the VFIO_DEVICE_NEEDS_KVM flags, which does the wrong thing for zpci, so it can't be that.. Also if we want to do major code movement, it really needs to go into a separate patch or patches, as the combinations of all these moves with actual code changes is almost unreadable.