Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <92258b87-824c-79cc-c775-972018c45c87@linaro.org>
Date:   Wed, 18 May 2022 09:45:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 1/6] dt-bindings: regulator: qcom,spmi-regulator:
 Convert to dtschema
Content-Language: en-US
To:     Robert Marko <robimarko@gmail.com>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        lgirdwood@gmail.com, broonie@kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>
References: <20220517120000.71048-1-robimarko@gmail.com>
 <12093e84-49b0-d36d-cfde-08ab8af3801c@linaro.org>
 <CAOX2RU4PpTQJUNkDremkhfdPG-=1NbG5xLmu22zFSOrqKMce5g@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAOX2RU4PpTQJUNkDremkhfdPG-=1NbG5xLmu22zFSOrqKMce5g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 17/05/2022 22:58, Robert Marko wrote:
> On Tue, 17 May 2022 at 16:47, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 17/05/2022 13:59, Robert Marko wrote:
>>> Convert the bindings of Qualcomm SPMI regulators to DT schema.
>>>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>> ---
>>> I am aware that syscon alone is not really acceptable, its converted
>>> directly from the old text bindings.
>>>
>>> There is also the issue of some MSM8994, MSM8996 and APQ8096 devices using
>>> '#address-cells', '#size-cells', some even defining reg property for
>>> regulators.
>>>
>>> Any advice on how to solve these issues is appreciated.
>>>
>>> Changes in v2:
>>
>> Changelog goes after ---
> 
> Ok, will fix up in v3.
> 
> While we are here,
> any ideas about the DTS-s that use reg and #address/size-cells for
> regulator subnodes and syscon?

Ideas for what exactly? It looks like a more of a subsystem convention,
whether to use unit addresses for children which are not real devices
(LEDs use unit addresses, regulators do not).

Best regards,
Krzysztof