Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp239152iob; Wed, 18 May 2022 00:48:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBZ8k2EZerUlRPzuHKUztN6FIJCL6ILTPb0/F6PJn/+v3nmmrr8S/vIjoQ85XOC31jy6fQ X-Received: by 2002:a17:90b:2241:b0:1dc:d4d3:3047 with SMTP id hk1-20020a17090b224100b001dcd4d33047mr40328053pjb.128.1652860104505; Wed, 18 May 2022 00:48:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652860104; cv=none; d=google.com; s=arc-20160816; b=IxT00d4LOGTFJlBhV1xs8ZiC2oa2EnyOybTVY4z8Q9VSLc/anyyyFC8Lf7bzoj2/zJ Sm58wJJLbBkwVaKoU5EqzpWyxv4sxecgfWDPEJ06yqS39uLOfnVVBSaFwDFqPTezXvf8 LyCeBww3oNU8T+flZO5sCo8gZ43qSLteVjB/1lg6Nj1nvxN/IMK6Q9VB7hHGmyXFQJdh s0Ny4BVGJ4o3p/68wpkgUqPMYfZCwOBYnxpOblvEGMyJyoY1msZju9oRhcEtoFkN1SiZ ppT4gggJRkLtSrxV8nzjEvlhVUzErpVh/iX/gElKEnSXa9zTuFNzWgbHPGbLbdUT97Pt /+ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eYhDLxMmwvMOyckDiVHVyMmqmEWGbbWduzz8f6EoW7w=; b=V7SGDViliOsrptYl5CU7Ek4cWUY3T/tmpiwgzsFec3Kwq4fXHkLOHZSM8A3JAM3T3z vSyVJuvZ2U6P3gRXWH6hcwrmG7aqQDLo6V/wdJMqLmlCXW3zAZTeLZ6THYTXPg66V+8z EvaDc5M2+0cTR1zn9NsERzoo7MCWImMmud4+VuifSDQKsT5eqnMqlIRC91ATBl6m+8ka a7Is5Y9nnhVIeXfIAdJOQl9zw57OozLU1FuGpY56EbzpRrqHAHJgFIenuBJ57ekPaSuE SU39kRDDNC22uwprBymFf8W+nqZN2Nj+PsyN18NZ8mz1xqlKYrpsJeYSdZdHptueyT9q aOLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=A57xSi62; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m14-20020a170902db0e00b00161ccc49576si255307plx.312.2022.05.18.00.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 00:48:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=A57xSi62; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C3DA217042; Wed, 18 May 2022 00:46:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232403AbiERHqW (ORCPT + 99 others); Wed, 18 May 2022 03:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232343AbiERHqT (ORCPT ); Wed, 18 May 2022 03:46:19 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64E81140CF; Wed, 18 May 2022 00:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eYhDLxMmwvMOyckDiVHVyMmqmEWGbbWduzz8f6EoW7w=; b=A57xSi62gZdHfEmDFs5ABgQVlf 877bK1lc99hRjaSFHxGasl/efP8yeorgGh6tPcDiAuvoObOU54KwdRVqTXUcFQEb9w0I+j2hH01Jt 7i6CYX1HN+iwBMiqOQiBUpDippnTsNf1qhb3LeUsQHUGcs5jtdAsVgOqPgvB94jIN4L3/ia2wLpDv 7JIiBGQlY6D5KpTBk0/WYIG3+MgVf+wxIuegc0L2pfXVZzjpUO7a4kKyKrjEfe11Sf+OZeH2ruc6w DlH+FwqvU/sNnFO37gHmjKHHJ6oEraPIqSqbhV8MIUplRjvQX8NX5qzORW5dl3RiIoGUJ+C80ZXcH s5jNMp1Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrENY-001TvH-BW; Wed, 18 May 2022 07:45:56 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id EC46698119B; Wed, 18 May 2022 09:45:55 +0200 (CEST) Date: Wed, 18 May 2022 09:45:55 +0200 From: Peter Zijlstra To: Song Liu Cc: Song Liu , Linux Kernel Mailing List , bpf , Alexei Starovoitov , Daniel Borkmann , Luis Chamberlain , "Torvalds, Linus" , "Edgecombe, Rick P" , Kernel Team Subject: Re: [PATCH bpf-next 2/5] x86/alternative: introduce text_poke_set Message-ID: <20220518074555.GC10117@worktop.programming.kicks-ass.net> References: <20220516054051.114490-1-song@kernel.org> <20220516054051.114490-3-song@kernel.org> <8370EC6E-C01F-496C-8B7C-D13EF9C474C5@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8370EC6E-C01F-496C-8B7C-D13EF9C474C5@fb.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 06:58:46AM +0000, Song Liu wrote: > Hi Peter, > > > On May 15, 2022, at 10:40 PM, Song Liu wrote: > > > > Introduce a memset like API for text_poke. This will be used to fill the > > unused RX memory with illegal instructions. > > > > Suggested-by: Peter Zijlstra > > Signed-off-by: Song Liu > > Could you please share your comments on this? I wrote it; it must be good! What specifically you want to know?