Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 11:13:35 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: r8188eu: add check for kzalloc
Message-ID: <20220518081335.GR4009@kadam>
References: <20220518075957.514603-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220518075957.514603-1-jiasheng@iscas.ac.cn>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KhnyjJ06dYIHVcjijC2xkczN7r65ifIOeSKpsqu4kMlYPiPKSRemN83S5uwz?=
 =?us-ascii?Q?WO6Gm0/Hs8f30hgZFc9NQLz73xSogRozB7LbWZu/mV4dUyPZUcrGJUy3HZYj?=
 =?us-ascii?Q?UNLflwOEV7WQ+Y5D5GV7dzopzJoOHsE/3iOQoDCR+Mus2xrxHrarFXpzREng?=
 =?us-ascii?Q?SdhtYaHOjekjt7oduxePkP8Tf/pX7aEhKAN8znHDBChi6NuiCiAC+pX+BQAF?=
 =?us-ascii?Q?K1/tkT92wdibh1i99IrxsMSTU/xuhsox59lT1O9Db4z2mS1rUo7IaqtD433s?=
 =?us-ascii?Q?NN7mH+JXaS2hFWY3UlfZro2OTdZzOmbQU5f4zqrjBXQ61Rav9psBgF9zFZwN?=
 =?us-ascii?Q?cTx+OiUOD7r0i9O13+c7D44K4bz/5Xp2P+qSlzNSRbaqvlxl7ObKO35EPPIj?=
 =?us-ascii?Q?sDPHIyiI8Q/i/nCpeg3goB+4EhdTgEffn925I4jGL114weRVEmdNqb+1bFow?=
 =?us-ascii?Q?NrBzdliEtoE1+k0pJK5nLzUolX+cBkNbuYw4Q/vTS6fBU2gHwuvxrc2ZrKUX?=
 =?us-ascii?Q?4Dd64SA5Km/9bAbG118cgyl3bxpGqIIECsXzAuf8Ep6qWuNMf390KHArZppd?=
 =?us-ascii?Q?0ozcrwxHsisazcfhLtEegXVAmHG0m6ma3e/F2V3BciTEKFyYz03PpKUrqbLf?=
 =?us-ascii?Q?TP0mUE32B9BRDl2Jt3Q+KQlCl7hkigN2JhV5KrpLJYpbnKPj0qh7Qg11YOIW?=
 =?us-ascii?Q?z984EwQdY0px38wjXVuzxKbHbDE7dbKxCSijOTD/Rs6O1OMvLkoX8Snw9a/D?=
 =?us-ascii?Q?42CQsVjjcmA1OUGwuoVT9iX+S3ZI+kh7e+p7QxHovwbjLz2WKN/X83+ZS4/1?=
 =?us-ascii?Q?gOY4b3N1EQvEC9HvxiOE3ccAHNU9Ce9RJc1CNGso+bG0+3Wc4njzFKs7NtWK?=
 =?us-ascii?Q?Pa90m9fhqG7eqM344/CtAq5eu9bhKHPX2FSgClfQpcj+6fWIqVFCvsYBbzis?=
 =?us-ascii?Q?jvg8YXdTwByDSVMjqJgmAvndwy0qnApqCxCsEH+GNY2Fqyl9As0PL0hfacbv?=
 =?us-ascii?Q?xthMmWyKL8duGdsoqHx9KRsljds1hrfGuSZM/TJsnLF/lxHm6u7XgcT8Vb1R?=
 =?us-ascii?Q?IZ6HV5EsRM04Bus8vqN2Ba4z4p2WaZ6U7ASMgmIVRQ1kXiHF615i26lbNJ0D?=
 =?us-ascii?Q?2nl3hjAdEuh9RHmSBOPlKWNI5Pj5uhEohP5hfmpmrRR7HeKEqO228G5KhFm+?=
 =?us-ascii?Q?uVYqODnfTvhT2trc3DcFyW5iNuRATid6xxnj2BBaAJuoxuBKRsq0YO611xlI?=
 =?us-ascii?Q?giX5k6kSSBcClm3dyrNZv8QfzCP9zrpVnU36g7P6cCQwBKTq8D391ZpMv37l?=
 =?us-ascii?Q?hC2N1zq8KLrCo8+uUH/61IM+iZX2nkHN3suK2FCFACsbb2mjrb4OP63sLRjV?=
 =?us-ascii?Q?SrpeDqfLZ9DVoNSv8RcAoIriUpR/aFwo/QNKUxcR/34V6gn79J3aBrWJb16Y?=
 =?us-ascii?Q?EvDF1b5Qz/XC+VbdIu9JBgVlWAyieP5MYwc2kXj/pzWv9KBOXgS9SdlLcjsE?=
 =?us-ascii?Q?V6zjEfaptvGNEXfXIYlW0q9HqVSvJO5PO1CqpgFLbdx9VeIloZQKarVotJwP?=
 =?us-ascii?Q?fmKBedQd3eULM/ZFNMBWa9jbWxe4Clnvy1HLYIoR1J5bWStsZuUNvi3IPQnc?=
 =?us-ascii?Q?/Xq/K8dWDZUx7kLHdjCIpfBO5j3Phs5tJI48NjZT3ah3U1sG8/mLTph8ntyA?=
 =?us-ascii?Q?8pkDrruaHrZ4OgLW8RQhAenqvaPa9jBrPJ4M+Ud1QN1SvW50pUlqv7ogl/S8?=
 =?us-ascii?Q?2SGQBIpWQD7XjzDlmULjK410UdPshnY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e08536c-950e-44a6-f8bf-08da38a65689
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 08:13:49.5674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I/oXwYlrU/eLIF4Y0q85TSQLL51rYPCUwZdhwGcDITk8tL3utAPsnMn8pn3/AN93BcqG2802QupzJeJGYg3HmYjYbjwCSGhtiYGMhPVqnQk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4710
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-18_02:2022-05-17,2022-05-18 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205180041
X-Proofpoint-GUID: oBbOwswWG9DzkcV67Sc1Ybj694-3p6eb
X-Proofpoint-ORIG-GUID: oBbOwswWG9DzkcV67Sc1Ybj694-3p6eb
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 18, 2022 at 03:59:57PM +0800, Jiasheng Jiang wrote:
> As kzalloc() may return null pointer, it should be better to
> check the return value and return error if fails in order
> to avoid dereference of null pointer.
> Moreover, the return value of rtw_alloc_hwxmits() should also
> be dealt with.
> 
> Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Looks good!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter