Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp259432iob; Wed, 18 May 2022 01:21:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2fMfja5Xp2PFgTBccSh+xqFoBAVN2LGv77J81GD6WRZz0XmMOrsxXq3YxVH/sd9RMvdVV X-Received: by 2002:a62:6411:0:b0:50a:81df:bfa6 with SMTP id y17-20020a626411000000b0050a81dfbfa6mr26983276pfb.26.1652862075863; Wed, 18 May 2022 01:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652862075; cv=none; d=google.com; s=arc-20160816; b=ckHx7oQAHyI5EjKh9uwI9x1txU2C4Wyhaqt032840difPAN1HEOF6RWD69dUA4TDLc So3IkC33cCcpkhmrAGKuoFE2NOBaKV60jf6Xm0WItz4oU2RSmxz8+F6W/klJqdw3sLKT vgEftgTd9h0ggg4NwhxFdMjr5UappvaXP1V9bJFFUf5RXTTz8lC4wDVO9s/GYm1nc6Po nEhtm7u6rlP95sZCAN1gQJY4cMxcIIKkbK0OcEPv+dDntbgYKV386m/4Gt3DjXoCDHQI y3fN3kcRkQnc9uJxttVf83jTtU/chMDKFdDQeKz1e2GEnrVNQQOIHfDfunbUMq9Upa7a A0MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=w062iR+N5eNAKHBifSA2gAqSf7gtsZDEdT7pHsErEsg=; b=nKUosIP86fp0vO4CliKj9YyRmo5nw13+B2y9o9WV2abI6IHvFECZox9BvSDfuyFulo 1EQSnmBnoecW//XoRYkTDaJ0tNvaCVeJKa6/O3zQTnuvxcAySzi3w63aVSXqkw3hEPpC u0qUPyYUx8FPLeASQGBDBoOraWpNpOIrY+ahwRRJZzJxr8bgfAoC4tstdqCHNttpCZtl QVRMxVeRvX96chNsJosfrDeQmkY4kxB4zXJb0yb/Qch23dXj8FHwtPz5M2H3qPGH9XgH rg3jfWAmNJtW50Oj8q7NXmdixUgLRBfVEnHyU2NuKJt0Xpb0mk6du3z3FrJYp4Tv+5iW KFeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id nd10-20020a17090b4cca00b001bf35bf24d7si5505364pjb.63.2022.05.18.01.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 01:21:15 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 453CB994E2; Wed, 18 May 2022 01:18:20 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232830AbiERISO (ORCPT + 99 others); Wed, 18 May 2022 04:18:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232820AbiERISM (ORCPT ); Wed, 18 May 2022 04:18:12 -0400 Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB49798588 for ; Wed, 18 May 2022 01:18:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 5D2ED206BF; Wed, 18 May 2022 10:12:39 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fIlEGlifOAuS; Wed, 18 May 2022 10:12:38 +0200 (CEST) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id E545A206B0; Wed, 18 May 2022 10:12:38 +0200 (CEST) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout2.secunet.com (Postfix) with ESMTP id DFD8C80004A; Wed, 18 May 2022 10:12:38 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 18 May 2022 10:12:38 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 18 May 2022 10:12:38 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 1466E3182D02; Wed, 18 May 2022 10:12:38 +0200 (CEST) Date: Wed, 18 May 2022 10:12:38 +0200 From: Steffen Klassert To: Jiasheng Jiang CC: , , , , , , Subject: Re: [PATCH] net: af_key: add check for pfkey_broadcast in function pfkey_process Message-ID: <20220518081238.GT680067@gauss3.secunet.de> References: <20220517094231.414168-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220517094231.414168-1-jiasheng@iscas.ac.cn> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 05:42:31PM +0800, Jiasheng Jiang wrote: > If skb_clone() returns null pointer, pfkey_broadcast() will > return error. > Therefore, it should be better to check the return value of > pfkey_broadcast() and return error if fails. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Jiasheng Jiang Applied, thanks!