Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <e70aa81d-95d6-9a89-2e34-f5e5974b40f1@intel.com>
Date:   Wed, 18 May 2022 18:01:56 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] KVM: x86: Fix the intel_pt PMI handling wrongly
 considered from guest
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>
CC:     <pbonzini@redhat.com>, <vkuznets@redhat.com>,
        <wanpengli@tencent.com>, <jmattson@google.com>, <joro@8bytes.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220515171633.902901-1-yanfei.xu@intel.com>
 <YoJYah+Ct90aj1I5@google.com>
From:   Yanfei Xu <yanfei.xu@intel.com>
In-Reply-To: <YoJYah+Ct90aj1I5@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzZ2N3lQUE1seDY4Rlh2MEpPaG4xczhMaE5jWUttMlB1U1BBOWRiZnpheEFB?=
 =?utf-8?B?KzhSVjQzMEViWW1ZcmhwQVRuTUN3Z3ZBd2ZUWmtoSTNCS3NiMm5wYWJidHND?=
 =?utf-8?B?YnFkUmZjdnZoT25nTUk5MlZBR3c0dzcxLzh4NjZyYkI5KytkZXNmem5iQVkx?=
 =?utf-8?B?TnNHRXdOZ29nZktlTWt6clhBQkVBMVQvcUFIU2doQjFLeEFoYTRTbkZRUHBY?=
 =?utf-8?B?eWxUNG52Z3ZKc0JyUytVcVJhbXptQzdqRTFZUUFkWjQvcW52WjF2L2J6Zmpo?=
 =?utf-8?B?cXEvc2xlMzI3YnBhTHFpeWFzUkxENFp3aFc2UmhNUDF3YmxSRGZFc2YzQ2J0?=
 =?utf-8?B?blFhYU9JR2thWGYwTzBHcVpxWVZXS1dybXZwOWZpd2ViUWhDaWNrZ240cHRF?=
 =?utf-8?B?OFJpM1kzaUZkcmYwSTdwVU5RODdlKy9wOGhtaWl1M1U3QXpzb3E3QkVLSFlm?=
 =?utf-8?B?aVdkYkJUd3JKTTc0WVEzcjZWRnVMRk5PczdRMGJtM1R4WVplcDNLUmVOWWxJ?=
 =?utf-8?B?UEZsVURIWUdvYzJ1RXlMN3VSeCtDNHF3RFh6SlRRYTk3ZFZRaUo0bGUrdkRW?=
 =?utf-8?B?OWV2dnV2V1JNTys2Kyt5RzdpUVVvYjhFZmtRMUhaQWlFNFJMYWZ0N3NsWGds?=
 =?utf-8?B?cVhVMU5EZFpiTW1qa2QzT3hrV3MwOThIT3Z4RlBJWm1rREM1VFNoSHpYNldR?=
 =?utf-8?B?OFJXZ1JVSlY2TEJ0UjFHMjQ4WE1RdDRtcmkxS3JNSXlUbDJlbHY3OTRDd2x3?=
 =?utf-8?B?OHVtaFYybzNMQkM5ejZ1ZkRuQ2FGeVNBTkNxTUc3SG14QmtodkdJbkI5dURO?=
 =?utf-8?B?S0dyVkpxYXZaeDYwNTBTTlQxMFlhYjd3YzZiOEJYOFlaU2E4Q2s5azU0MjBh?=
 =?utf-8?B?ZU9tTitZcXVIL2s3K2NrS0gvZkZ0WW5iOFkwV1dsSkVkeWVMRkttZ2ZuenB6?=
 =?utf-8?B?dlg3QXlqTlVOWllUdzRZb0NSWU9OM0g4dkhyMUpYdWFJdmhVZ1BvRHNWTThW?=
 =?utf-8?B?VUkxRFNZYm1rV1V0TzJGbm8yMUhjSGROd01SYTk3Y2pNcWtjZThMSzBtc2ky?=
 =?utf-8?B?REl0VWxsb2RyUlIzcnJ4MDRzUFArTjdFS2lKWm9ubUNaM0pWMG4zeUp2Wm9G?=
 =?utf-8?B?WFQ5Q2RxdU5WQmY4UTVEZlZqYkpOaUxjbnVpRXk3dXVNTC81K3NWRzBhNWg0?=
 =?utf-8?B?ZUhwTFFUaG9WaFMyUmdEdnNKN204WEdxcjFvU3lub3FGTDV0TjlUUEVNZjJQ?=
 =?utf-8?B?T1BabmI3SGdUTktiZmpJbk9UTVUvL0VsTjZaMGRIa09IZHRrbjR2bDl6WGR3?=
 =?utf-8?B?bVpjUmgyOUlaNDBZeXFEQlBOa1NUZldVTkRMcFBIdWxQRTlGSmRVdS80TlFV?=
 =?utf-8?B?YkVYbzJDdlJoY2wyVmk1Qm9YR2kzTUpoRnF6dVFWSTI2eVhqSlNMakQzR1hQ?=
 =?utf-8?B?TmNhaGZxWklMc3NGckRYNTdtS083L2pocnI4UTJDRHk5UEN6ZUhNeXVqa2Vu?=
 =?utf-8?B?OSswS0ZQbXk2cTJId0ZyWmZqdklzY3dQOHVFeDk1Q2Nic1c3dU5JVkRCTHgy?=
 =?utf-8?B?MzRDVXZJMmRJK0tqenVuTHp1UzdrcXhLSWJkcm82eU4xZmh1WGtlTzFoVHpN?=
 =?utf-8?B?Sm1TaUs5aUtKczZBN2NTa29rclJjdHRaTlFYZ3VoRXpqTDZsS2Y3Q3dkTUhr?=
 =?utf-8?B?Mlhnck53c3JsR2pYYlhOOERxR3orQnp2dkh5dGJGc0dndUJYNE5YUmtSTXhl?=
 =?utf-8?B?VjdkZkFtdmtScFlRcEhNa05SUnBaaXFaNGkxaXBVVkU5dnR0UGZmSVdmdTd5?=
 =?utf-8?B?Q2VXY2FKZDVqQkpiR3B6cFZhcUMycGRXdkdwd2hqd3FibDl5dFBJKy84NGtE?=
 =?utf-8?B?WTYvNmp2Zi9RUHo4dGtjQm9pdEI3VUsyUFNQQURNMWgrUitBV04zOURaY1Yz?=
 =?utf-8?B?L1RtZi8yaGsza3UwUW5yTmJHQmdEKzBRNnNqZFhEUDdUZG1JNWhrUENvN2Q3?=
 =?utf-8?B?Q3REK0xjRTIwWHZKTkJpYkdNRjF2UHdYa0FjYklLYjRuSE1nS3RiSzlkT3g0?=
 =?utf-8?B?Z0drQS9rVVBXZUlDaDhIeUdkZjBiKzBjTjFndmhkNWlWZ0daYzNlb09xd2pC?=
 =?utf-8?B?SlV2MnBlb1JzVlM2RzNvVmcxL05DQXZXenprRnJ0MzBWeDNYZGVjeHBYWTA5?=
 =?utf-8?B?bkN1Z3NpNUp4UmZKNzEvdVZXc3B4ZlE0SUwzR2RQaUt0c1V0blh5eHhBZmRE?=
 =?utf-8?B?U2dEQlRzV3crSmIwNE9aaFVJNFFMZkJKNlNrT1dyMC9BejZ5YmJuUUFjVGZa?=
 =?utf-8?B?aG9NZkdHMVJrb2dud0VkR21YZ1BuVzJjRDlOK21RWFhoQ1VQcXVjZz09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c9577059-8d53-42a6-3ac5-08da38b587ba
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4129.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:02:34.7617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 72Xqz9rjLbUADSfKvNGb2u7aAMJsCgSi39l2Q9gGdCrSeDHp3yA0XaYb7JQjC5mzPTAzs38FN8VPmjOfIGoSOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2825
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022/5/16 21:58, Sean Christopherson wrote:
> On Mon, May 16, 2022, Yanfei Xu wrote:
>> When kernel handles the vm-exit caused by external interrupts and PMI,
>> it always set a type of kvm_intr_type to handling_intr_from_guest to
>> tell if it's dealing an IRQ or NMI.
>> However, the further type judgment is missing in kvm_arch_pmi_in_guest().
>> It could make the PMI of intel_pt wrongly considered it comes from a
>> guest once the PMI breaks the handling of vm-exit of external interrupts.
>>
>> Fixes: db215756ae59 ("KVM: x86: More precisely identify NMI from guest when handling PMI")
>> Signed-off-by: Yanfei Xu <yanfei.xu@intel.com>
>> ---
>>   arch/x86/include/asm/kvm_host.h | 8 +++++++-
>>   arch/x86/kvm/x86.h              | 6 ------
>>   2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
>> index 4ff36610af6a..308cf19f123d 100644
>> --- a/arch/x86/include/asm/kvm_host.h
>> +++ b/arch/x86/include/asm/kvm_host.h
>> @@ -1582,8 +1582,14 @@ static inline int kvm_arch_flush_remote_tlb(struct kvm *kvm)
>>   		return -ENOTSUPP;
>>   }
>>   
>> +enum kvm_intr_type {
>> +	/* Values are arbitrary, but must be non-zero. */
>> +	KVM_HANDLING_IRQ = 1,
>> +	KVM_HANDLING_NMI,
>> +};
>> +
>>   #define kvm_arch_pmi_in_guest(vcpu) \
>> -	((vcpu) && (vcpu)->arch.handling_intr_from_guest)
>> +	((vcpu) && (vcpu)->arch.handling_intr_from_guest == KVM_HANDLING_NMI)
> My understanding is that this isn't correct as a general change, as perf events
> can use regular IRQs in some cases.  See commit dd60d217062f4 ("KVM: x86: Fix perf
> timer mode IP reporting").
>
> I assume there's got to be a way to know which mode perf is using, e.g. we should
> be able to make this look something like:
>
> 	((vcpu) && (vcpu)->arch.handling_intr_from_guest == kvm_pmi_vector)

Thanks for your comments, I am going to understand these clearly and 
then reply or give a next version.

Regards,
Yanfei

>
>>   void kvm_mmu_x86_module_init(void);
>>   int kvm_mmu_vendor_module_init(void);
>> diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
>> index 588792f00334..3bdf1bc76863 100644
>> --- a/arch/x86/kvm/x86.h
>> +++ b/arch/x86/kvm/x86.h
>> @@ -344,12 +344,6 @@ static inline bool kvm_cstate_in_guest(struct kvm *kvm)
>>   	return kvm->arch.cstate_in_guest;
>>   }
>>   
>> -enum kvm_intr_type {
>> -	/* Values are arbitrary, but must be non-zero. */
>> -	KVM_HANDLING_IRQ = 1,
>> -	KVM_HANDLING_NMI,
>> -};
>> -
>>   static inline void kvm_before_interrupt(struct kvm_vcpu *vcpu,
>>   					enum kvm_intr_type intr)
>>   {
>> -- 
>> 2.32.0
>>