Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220517163820.86768-1-andriy.shevchenko@linux.intel.com>
 <YoR/QXuS+VlLVWto@lahna> <YoSyTq2908EptTGd@smile.fi.intel.com> <YoS6EkfU1TdggKS/@lahna>
In-Reply-To: <YoS6EkfU1TdggKS/@lahna>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 18 May 2022 12:05:38 +0200
Message-ID: <CAHp75VenknSRSUkGj9rKfzw2q1Mm-+zRrzAmcYRLdK1GJHDoHw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 18, 2022 at 11:19 AM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Wed, May 18, 2022 at 11:46:06AM +0300, Andy Shevchenko wrote:
> > On Wed, May 18, 2022 at 08:08:17AM +0300, Mika Westerberg wrote:
> > > On Tue, May 17, 2022 at 07:38:19PM +0300, Andy Shevchenko wrote:
> > > > +static const struct irq_chip intel_gpio_irq_chip = {
> > > > + .name           = "intel-gpio",
> > > > + .irq_ack        = intel_gpio_irq_ack,
> > > > + .irq_mask       = intel_gpio_irq_mask,
> > > > + .irq_unmask     = intel_gpio_irq_unmask,
> > > > + .irq_set_type   = intel_gpio_irq_type,
> > > > + .irq_set_wake   = intel_gpio_irq_wake,
> > > > + .flags          = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE,
> > > > + GPIOCHIP_IRQ_RESOURCE_HELPERS,
> > > > +};
> > >
> > > You still have the inconsistent alignment here.
> >
> > I'm not sure what problem do you see.
>
> I mean the tab alignment you use:
>
>         .name           = "intel-gpio",
>         .irq_ack        = intel_gpio_irq_ack,
>         .irq_mask       = intel_gpio_irq_mask,
>         .irq_unmask     = intel_gpio_irq_unmask,
>         .irq_set_type   = intel_gpio_irq_type,
>         .irq_set_wake   = intel_gpio_irq_wake,
>
> All the other struct initializations in the driver use this style (and I
> prefer it too):
>
>         .name = "intel-gpio",
>         .irq_ack = intel_gpio_irq_ack,
>         .irq_mask = intel_gpio_irq_mask,
>         .irq_unmask = intel_gpio_irq_unmask,
>         .irq_set_type = intel_gpio_irq_type,
>         .irq_set_wake = intel_gpio_irq_wake,
>
> Hope this explains.

Yes, thanks!

Okay, can you give your conditional Ack if there are no other
comments? I will fix it locally.

-- 
With Best Regards,
Andy Shevchenko