Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 18 May 2022 11:11:09 +0100
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Gyorgy Szing <Gyorgy.Szing@arm.com>
Cc:     Sumit Garg <sumit.garg@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "op-tee@lists.trustedfirmware.org" <op-tee@lists.trustedfirmware.org>,
        Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] tee: Add Arm FF-A TEE driver
Message-ID: <20220518101109.xdmiuj5gjqg3drhm@bogus>
References: <20220408134144.1532704-1-sudeep.holla@arm.com>
 <CAFA6WYNbwqNqK89ZCWWpAT5HCR59A+J873_5Odyjyb9qu00nsg@mail.gmail.com>
 <20220426144545.6qkn6iwayuwpvi7g@bogus>
 <CAFA6WYMCTn-YQrA-GixYu6OG8Qr_xsZ7xuk4LfFA-1PHgus3RQ@mail.gmail.com>
 <AS8PR08MB5895E2E79F48D5CBF939C45391CE9@AS8PR08MB5895.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AS8PR08MB5895E2E79F48D5CBF939C45391CE9@AS8PR08MB5895.eurprd08.prod.outlook.com>
Precedence: bulk

On Tue, May 17, 2022 at 06:55:47PM +0100, Gyorgy Szing wrote:
> Hi Sumit,
> 
> The best way to test the driver is to use the PSA SPs from Trusted Services
> similarly as described on the wiki page above. We have merged the TEE driver
> enablement patches to integration branch of TS recently, and as a result the
> set-up and build instructions above will build an end-to-end config using
> the TEE driver.
> The TEE driver integration needs to be changed though. Instead of building
> the TEE driver as an out of tree module from our fork [2], you might want to
> change the config to use the driver posted by Sudeep. If you wish to use the
> op-tee build flow, the makefiles in OP-TEE/build repo part of the above
> set-up need modification too.

Correct I have done something similar when testing as a module.

> TS will build multiple test executables targeting the Linux user-space. For
> TEE driver testing any of these targeting the "arm-linux" environment will
> do, but I suggest using the "ts-service-test".
> 
> AFAIK Sudeep is testing with TS too using a similar set-up.
>

Indeed. I just made couple of minor changes to the way app checks the presence
of the driver and dropped the version check.
Ref: ffarpc_caller_check_version in components/rpc/ffarpc/caller/linux/ffarpc_caller.c
to make progress.

> [2] https://gitlab.arm.com/linux-arm/linux-trusted-services
> 

-- 
Regards,
Sudeep