Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 18 May 2022 19:00:37 +0800
From:   Zenithal <i@zenithal.me>
To:     Conor.Dooley@microchip.com
Cc:     palmer@rivosinc.com, paul.walmsley@sifive.com,
        aou@eecs.berkeley.edu, heiko@sntech.de, atishp@rivosinc.com,
        anup@brainfault.org, ebiederm@xmission.com, keescook@chromium.org,
        linux-mm@kvack.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        mtk.manpages@gmail.com, linux-man@vger.kernel.org,
        jiatai2021@iscas.ac.cn
Subject: Re: [PATCH -next v2 2/3] RISC-V: uapi: add HWCAP for Bitmanip/Scalar
 Crypto
Message-ID: <YoTR1aBcscG+oe0W@Sun>
References: <YoS6qRhxGuwHmK7q@Sun>
 <YoS7lgTmcRT0q9y+@Sun>
 <fba8ab6e-17bf-1fe1-ad5f-339276907298@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fba8ab6e-17bf-1fe1-ad5f-339276907298@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/9z3/+OT9gnshGKlc8zb/U+NpnnuoH6b6WVfdhnvpCeNsfQnmoXuzwVQL4Aj?=
 =?us-ascii?Q?rJM8Z5qoIJpEZIg4Pg4oPAXFBSU3Spih0qpzgweYgpVYgdJSYOT/phUc08p+?=
 =?us-ascii?Q?dMqXG7zogPmLFz+08p/vcDIvG7t3S7zvx6ylIjiWZiCLZV53Oi4mXXpFIHZh?=
 =?us-ascii?Q?syTW+eRboZdyA4pY1xTPgWu1MhOe1x9X0qhQ5d2mCmnEkZSqqgeKKIoiQ+On?=
 =?us-ascii?Q?xc4zcd/vIDYq4Dlhyfhdi7hhORpe0Do0Oe7GFDmExspPOoMFoR5VtZcCO9Rm?=
 =?us-ascii?Q?HrQMAw0nE5ltgYn1kgbta4itiKNKIc2Q8pXlP7ZMiNkD8QXcLuHz99FUy1nN?=
 =?us-ascii?Q?HFea5zmf9NDSWQxeNlL+IlNGLVzBVZ3LVEKEsX+t1LBmH6LrfqS2UPWzkhZ7?=
 =?us-ascii?Q?PTWSWsYbLDtsUfaJTKV70j5Xt+s29h90YgQpE7aW6vz5E+O0sqpWca1wafpp?=
 =?us-ascii?Q?k/lfxaqzlfYgZc+ZXG/avp9JtIiAOWlDCOBpITF/IBSggAARDiSHZcp+TjFc?=
 =?us-ascii?Q?Y5ogGfjzPCfAuOSLjtVMQ//e11pI/SFOPLSgqzYIAFWXDe0sV/s0lh9NmVzM?=
 =?us-ascii?Q?ZchuXgVUXs7FMZbMM1jtjV5azvn6fRQ9ZcEmG5UAN2XoIneuVWNsyd0PQc/2?=
 =?us-ascii?Q?ZdnRdERpRJgOC/V5e4U4pStWDAQo8R/C9nbWpQ8wuscCp18AGj6162t26jiy?=
 =?us-ascii?Q?1eBNoHClG/RDOIHyjLTfOCxQaseECXrgDYWaJRplezTe0yQOBO0X13hEyVqZ?=
 =?us-ascii?Q?g6pvkZlIagPstSqToKT6veFCsoEm2KBD6HhMeBg3ETsAZAizxeRZZj+WxuRf?=
 =?us-ascii?Q?2UuVlASXjnH32wsEqaupthMnFeqKX4DaS0JqhfIaC+Gr9QcErfZ01OTqGEDx?=
 =?us-ascii?Q?AnqCo1+BGCiEterdDJCaarRz2LKBeRoYbJ7q3v7rEqv4EHG6mK9V8AtE/ynn?=
 =?us-ascii?Q?RAjJFFqMzv8ajU/RLaEDTojGUnu6H8oG0D6ygF8DhjjVhVTF1wISJmxtebns?=
 =?us-ascii?Q?Aq4KGM8gSgwaBxRoeQJPHBxORBRcAWxZvB0IMTJBM8tGVkOvvqja2H3+15P9?=
 =?us-ascii?Q?fAjd8lKd5YzxMzeSibcLNxJ5k30B9M3VLZcpZMMip5GxzHCtLfSjchLClWrD?=
 =?us-ascii?Q?8zo8ir5ChEzc21joPrqx/EW9+4DKxiNOphCxPXShyE3LiolEBjJ2piL5Qw65?=
 =?us-ascii?Q?pd3iG+d2Tr4Pe3/l/CkLkVstsDwqm05dtfuGeXF+3SdRTepXJk5G/53igGMa?=
 =?us-ascii?Q?1XnI9U1bMqFHEwjXG5Y6+1a4RN/oAfL9lx4XNc74gTQ/rueyGNPEJ2TCg8nS?=
 =?us-ascii?Q?7+z/Ml2lenm+2U3EUdBwnEK+8+1Brurj/ZToUg7E+/7vKm0QApNG0vTVK8+P?=
 =?us-ascii?Q?q/A733qGTx7s96gsoA5YAfl6XkqHiryDXUNzTu+CQy7FvzudCj0EWnsQaYZa?=
 =?us-ascii?Q?lUsc78TfwKHCjxIQEOo3DUDueYTBGMPUW50u964VVIWJmta59cGHCDqW1z58?=
 =?us-ascii?Q?l/4uV6y4FY9EQppuNbUKhR6ksioZnnGlAOTB+ny48M88Xy6Gw/430s1lhDdW?=
 =?us-ascii?Q?KoQnVuG8YFDvhOJ8bPhcthXeCH+6PIz/Kb4JIrvsGm8OoKrxet+m5DCMnl4q?=
 =?us-ascii?Q?3Lxi/XhLhTayJZDAWZy4ASYGUWp9Gf+bwUbOUU41J/cWBsqY1qP7/VLRc9JC?=
 =?us-ascii?Q?N5IVhkn5jbq4Zd6Xain3N4WRaDtFSA9DhFUaH2nVQOl7NlS1azu041UosvNP?=
 =?us-ascii?Q?IrkXjKq5ZQ=3D=3D?=
X-OriginatorOrg: zenithal.me
X-MS-Exchange-CrossTenant-Network-Message-Id: 37bcf7e1-2957-4087-b5e4-08da38bda7bf
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1393.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 11:00:44.3348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 436d481c-43b1-4418-8d7f-84c1e4887cf0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 09nH2ix7WJaq6lRpIprgWZbvpmdKipXAm22Kp9udtYrfnmbc9rX04anCe5urNEm7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB1161
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 18, 2022 at 09:39:53AM +0000, Conor.Dooley@microchip.com wrote:
> On 18/05/2022 10:25, Hongren (Zenithal) Zheng wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > userspace currently lacks a way to detect whether the
> > platform has Bitmanip/Scalar Crypto capability,
> > this commit provides a way such that the userspace
> > can detect it.
> > 
> > RISC-V currently still has no mature mechanism,
> > but no matter how things in the spec changes,
> > (no matter how "M" mode things change), the kernel
> > still needs to offer some API to the userspace.
> > 
> > More discussion can be found at
> > https://github.com/openssl/openssl/pull/18197
> > Userspace currently has to use env var to detect them.
> > 
> > This commit along does not assume any specific mechanism
> > below kernel.
> 
> s/along/alone?

Thanks for catching this typo!

> 
> But I think you could rewrite this sentence to make it
> clearer, I had to read it more than once to see if that was
> actually a typo or not.
> Possibly swap "This commit" for "This interface" or similar,
> both here and in the first paragraph.
> Maybe something like:
> 
> "This interface does not make any assumptions about the
> underlying hardware"

Will use this kind of description in the next version.

> 
> Thanks,
> Conor.