Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 14:33:15 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH net v1 2/2] net: dsa: lantiq_gswip: Fix typo in
 gswip_port_fdb_dump() error print
Message-ID: <20220518113315.w3p6vzj3djat2abd@skbuf>
References: <20220517194015.1081632-1-martin.blumenstingl@googlemail.com>
 <20220517194015.1081632-3-martin.blumenstingl@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220517194015.1081632-3-martin.blumenstingl@googlemail.com>
Precedence: bulk

On Tue, May 17, 2022 at 09:40:15PM +0200, Martin Blumenstingl wrote:
> gswip_port_fdb_dump() reads the MAC bridge entries. The error message
> should say "failed to read mac bridge entry". While here, also add the
> index to the error print so humans can get to the cause of the problem
> easier.
> 
> Fixes: 58c59ef9e930c4 ("net: dsa: lantiq: Add Forwarding Database access")
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

>  drivers/net/dsa/lantiq_gswip.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 0c313db23451..8af4def38a98 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1426,8 +1426,9 @@ static int gswip_port_fdb_dump(struct dsa_switch *ds, int port,
>  
>  		err = gswip_pce_table_entry_read(priv, &mac_bridge);
>  		if (err) {
> -			dev_err(priv->dev, "failed to write mac bridge: %d\n",
> -				err);
> +			dev_err(priv->dev,
> +				"failed to read mac bridge entry %d: %d\n",
> +				i, err);
>  			return err;
>  		}
>  
> -- 
> 2.36.1
>