Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 08:58:52 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        alex.williamson@redhat.com, cohuck@redhat.com,
        borntraeger@linux.ibm.com, jjherne@linux.ibm.com,
        akrowiak@linux.ibm.com, pasic@linux.ibm.com,
        zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org, linux-s390@vger.kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM
Message-ID: <20220518115852.GG1343366@nvidia.com>
References: <20220517180851.166538-1-mjrosato@linux.ibm.com>
 <20220517180851.166538-2-mjrosato@linux.ibm.com>
 <20220517185643.GY1343366@nvidia.com>
 <YoSivTU7nivO9FMD@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YoSivTU7nivO9FMD@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5FfdLZdlYjppZcUzT6IjMvGiAxwjld+W526QBK4EsX9M8pZtCy+63E1zAgNZ?=
 =?us-ascii?Q?0wcjI7qsGEKyuGLaGw2E3QC6HksU6FKh2cP3nDX/8VuroFxKXfg7+dBtEBYc?=
 =?us-ascii?Q?TAZva2XaX4pzLC7Tlp1NI5Snn3wSFc0G6HFfGvkxTMU4QCSK1Zfjc35kKIsi?=
 =?us-ascii?Q?h246hl3HDtMKzDffe0j8YvcBG2VtdLQdJ6UNuTm+r0bj3qzdOIb/Tv2iBlRp?=
 =?us-ascii?Q?YCUcIas/cEL7ok1tTTJO4UpoWIhZ78tMaE+HsrV6rFBZ7sKc9d3FGkdADbkM?=
 =?us-ascii?Q?P8ez8mOKh7JIhKIQ6Ebt7R9GP1zIxCZZiasqUo2t78hatRxFUbD9+b+ieXP8?=
 =?us-ascii?Q?gqhdBCT+nL6M5BQrqSiDjR8xgyZLrFAzSg07w8WU3Dbn8vIwh0DdT4EaMdqU?=
 =?us-ascii?Q?A7cwYzYeheAHHt/QImvpMghzsKPFX/sDLS/yohOsXZnig0k9+3D2bRcHjHlH?=
 =?us-ascii?Q?iGEsAKeJpY3Jac9Jp9/Pr6YKYoZJLixtQ5iJ5ptKS2y3JEk8FCj3/x0zDeU8?=
 =?us-ascii?Q?MlEgmq/XT/EhLxoD5ELN3nBWuBjlYOxo6SSZnwJUYdw/kgVSoqO4De1/AEn6?=
 =?us-ascii?Q?jXSfhAN705mWp8W8E+a77mxSartm/WRR++/Rgn+Sudy5xDGZFEzlJF4YgnkG?=
 =?us-ascii?Q?OVU0qa98uW0E1qlt2fA42GkJvJwvm1DyEg7VBREz1CtHnrOFbzUfg8iRaCAl?=
 =?us-ascii?Q?E7+J5lEj7CW09sBeIyVKa3/qLAXEKEI3ER2Ro35Gd98RLQuM9regitBi0/Pt?=
 =?us-ascii?Q?brzYUn4iFA/rPuIRLuhotG4xDe85uOjk+KVxErfeG663LcCbfjUedGXKtMDY?=
 =?us-ascii?Q?udo1Fxs6QQXvhwdvG8VOZUKyIGjEnOaFMWg4Wi7SrLkOmF+F3ZzSzhZLLNwd?=
 =?us-ascii?Q?rclIv0shdAXYUZBhwKcvZ9tgnBtpXL0X9OFk+0fzQvlsUqGhArTx5zc8evgM?=
 =?us-ascii?Q?QAhgRFn0wz9PTz4UzonM8SXGI0pXSGLCpoSRPUFuiIUPSSPOy5T+0Hk9igEO?=
 =?us-ascii?Q?OW/zRFS3yFqch+kwvfcUcH3BfKSgQ7+YWP0ZBO1OqgmZ8WONIfDi7iAWlg3d?=
 =?us-ascii?Q?/P6gw2KRrOVZWlDZiD49iZGKxzvjUg0vNqlWWPDLCXmx9jCo6pv0nEub+wT4?=
 =?us-ascii?Q?fOtb82nedLt/e70hNxAKSgZhheEK6oS/9Z6xQYXLDu6P+V5gXLfe/OkQFQiI?=
 =?us-ascii?Q?e7S2J72tnhoqzcduqOj5U23M3WR5NG/Jiizc+If3PWYG1m7cy3PB/GQ4fACn?=
 =?us-ascii?Q?YMcFAHyn/xlFJdXWTWSmrJ2YnqtXDW10+P6+SmBWI0WOjsN5iKGbeTmmzkhp?=
 =?us-ascii?Q?ri7FNNHMqTuLzgaI4aR/6kdGWaObcNmgJkm6v0IzIKZF8ETswfaGkYB9NziQ?=
 =?us-ascii?Q?1YNq8zxsroigwUr37qFdK+obLOPQRem9tNE5kk8Ut6lWUqSYBtkpQS0vFswg?=
 =?us-ascii?Q?h6YqGkJHoTwP0KIAk5agKZ6A5yAuGBSK4WyktX2uhduLLZ23Jq3XcCu0vQ3Z?=
 =?us-ascii?Q?n2gfpR6U3atCMQrs8F08B7rQtBcZ0JvudY+CIcTQ7Ode+ZOWcEVPwR9vU9td?=
 =?us-ascii?Q?Dyuye8vDJHaH6F3qcK+8+SuMijTaXdOIwFDKaV2fAXmA95dHsiuE5SJGWy2o?=
 =?us-ascii?Q?2THbxNVEw3/bRMkdFFpjt7sO62pyN651vk1rT3Y1KeujcPWWfNyajrilmLF7?=
 =?us-ascii?Q?Ha2v1nHhAz4PSZ2iTzSLIuaWXNmocGEM9UGAJURDcGl3zqEzUStMrw9za6lU?=
 =?us-ascii?Q?4yC/JA7j1w=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e26ac32-5394-43a1-0f2f-08da38c5c80a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 11:58:54.4192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3bMOsCQhA1OmSAe7QkEgBDhhA5o8dD0cyysPejy7Ax4C1upCXOu1noR7ExoVxbhn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5442
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 18, 2022 at 12:39:41AM -0700, Christoph Hellwig wrote:
> >  	if (device->ops->flags & VFIO_DEVICE_NEEDS_KVM)
> >  	{
> 
> Nit: this is not the normal brace placement.
> 
> But what is you diff against anyway?  The one Matthew sent did away
> with the VFIO_DEVICE_NEEDS_KVM flags, which does the wrong thing for
> zpci, so it can't be that..

Against what I sent before, I did this before Matthew sent his

> Also if we want to do major code movement, it really needs to go into
> a separate patch or patches, as the combinations of all these moves
> with actual code changes is almost unreadable.

Sure, just checking how things could look at this point

Matthew's version first followed by the code motion is probably a good
approach.

Jason