Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 15:05:03 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Rob Herring <robh@kernel.org>
Cc:     =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Herve Codina <herve.codina@bootlin.com>,
        =?utf-8?Q?Miqu=C3=A8l?= Raynal <miquel.raynal@bootlin.com>,
        Milan Stevanovic <milan.stevanovic@se.com>,
        Jimmy Lalande <jimmy.lalande@se.com>,
        Pascal Eberhard <pascal.eberhard@se.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings
 for Renesas RZ/N1 Advanced 5 port switch
Message-ID: <20220518120503.3m2zfw7kmhsfg336@skbuf>
References: <20220509131900.7840-1-clement.leger@bootlin.com>
 <20220509131900.7840-6-clement.leger@bootlin.com>
 <20220511152221.GA334055-robh@kernel.org>
 <20220511153337.deqxawpbbk3actxf@skbuf>
 <20220518015924.GC2049643-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220518015924.GC2049643-robh@kernel.org>
Precedence: bulk

On Tue, May 17, 2022 at 08:59:24PM -0500, Rob Herring wrote:
> On Wed, May 11, 2022 at 06:33:37PM +0300, Vladimir Oltean wrote:
> > On Wed, May 11, 2022 at 10:22:21AM -0500, Rob Herring wrote:
> > > > +patternProperties:
> > > > +  "^ethernet-ports$":
> > > 
> > > Move to 'properties', not a pattern.
> > > 
> > > With that,
> > > 
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > 
> > Even if it should have been "^(ethernet-)?ports$"?
> 
> Why? Allowing 'ports' is for existing users. New ones don't need the 
> variability and should use just 'ethernet-ports'.
> 
> Rob

Yeah, ok, somehow the memo that new DSA drivers shouldn't support "ports"
didn't reach me. They invariably will though, since the DSA framework is
the main parser of the property, and that is shared by both old and new
drivers.