Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220517110737.37148-1-ilpo.jarvinen@linux.intel.com> <20220517110737.37148-2-ilpo.jarvinen@linux.intel.com>
In-Reply-To: <20220517110737.37148-2-ilpo.jarvinen@linux.intel.com>
From:   Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>
Date:   Wed, 18 May 2022 17:48:21 +0530
Message-ID: <CAKfKVtFO5z68JwFtGDoHAVVfwXvNnT0B_dGZutCLyu6Vo8tXOQ@mail.gmail.com>
Subject: Re: [PATCH 1/9] serial: uartline: Fix BRKINT clearing
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-serial@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Peter Korsgaard <jacmet@sunsite.dk>,
        Sean Anderson <sean.anderson@seco.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 17, 2022 at 5:58 PM Ilpo J=C3=A4rvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> BRKINT is within c_iflag rather than c_cflag.
Nit typo in the subject line.


>
> Cc: Sean Anderson <sean.anderson@seco.com>
> Fixes: ea017f5853e9 (tty: serial: uartlite: Prevent changing fixed parame=
ters)
> Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/tty/serial/uartlite.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.=
c
> index 007db67292a2..880e2afbb97b 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -321,7 +321,8 @@ static void ulite_set_termios(struct uart_port *port,=
 struct ktermios *termios,
>         struct uartlite_data *pdata =3D port->private_data;
>
>         /* Set termios to what the hardware supports */
> -       termios->c_cflag &=3D ~(BRKINT | CSTOPB | PARENB | PARODD | CSIZE=
);
> +       termios->c_iflag &=3D ~BRKINT;
> +       termios->c_cflag &=3D ~(CSTOPB | PARENB | PARODD | CSIZE);
>         termios->c_cflag |=3D pdata->cflags & (PARENB | PARODD | CSIZE);
>         tty_termios_encode_baud_rate(termios, pdata->baud, pdata->baud);
>
> --
> 2.30.2
>