Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp455961iob; Wed, 18 May 2022 06:01:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHMZA99wgtXMBswh+I3IKjtRYkeVenGw1DwUl92JrZn1eRteKS/Dc/mQ68Vap+uw2pTDK9 X-Received: by 2002:a65:5544:0:b0:3f6:1c53:a3a2 with SMTP id t4-20020a655544000000b003f61c53a3a2mr742657pgr.48.1652878901462; Wed, 18 May 2022 06:01:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652878901; cv=none; d=google.com; s=arc-20160816; b=BRezflHnu73iVtrCLOlC0ZzrdwzukCzoDbRjpjwTTee2E3MXL9vPzanIuSLBdFLnrG A4Fcuj+kalnBeyAkAlI9IE759ASIxPH+U13oYNUEIDJi4I1wtDnoZJODl4Wyj95PxCFd ElfKjL35nKWofLD71SS01Do28/m+8JHIBhwh4Wtw0ePEfnpDqjI/G0/h8mnr4l4req/0 TMmbFZgBbi7/fBLhu1piR9A4v/rCx6hh/fQ8VkMpddSz1QyYjcCFwSUISpZ6WDGF2GCB aQj9mYWAWGx/ZOTtvbINRUzflK3lw/aQeB2hGxq8wpitm10jXZJrv4OuGTMIo6LaBoWW 0G1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=ViV40HmmMQBoT9BxjSXilwgyWU2rNWUpBTFXxtxCUEA=; b=q+3BWZDkNzP9RtOgeW2NyW6QVvYpvI2BLNLwTcgShofpsp9FO/qUtqNknJQ2FhTPCa xUWmw5eieNqq3E6Eunb/bULDMQlaPTKt8INBXUtkm1ejAJUBUL+cUCGSR3v7C3CwiA/e +eNmJ69MCqfGaK0psjSYMa/p16sBwgbvUcvbOKERcPNQzas7f1mHzv2WmQDUt8RBakr0 tbLRftNeAd4Obcrw44dHWEX9s4QUNpm8uSaXUFBmfHSOZxxhw0ZrtM4AjSfE2qvumnxe 9E862c8JtKLQCUs2RPPtuHP/rUzDMKUtG+/wCAsmfELKZz4CUxjKcJc2JV6cpoZaC4nv ouXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NB3cjU0V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id r2-20020a170902ea4200b0015d1f1c9235si2699170plg.561.2022.05.18.06.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 06:01:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NB3cjU0V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B73081A4921; Wed, 18 May 2022 06:00:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237391AbiERNAT (ORCPT + 99 others); Wed, 18 May 2022 09:00:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237185AbiERNAN (ORCPT ); Wed, 18 May 2022 09:00:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDBF1A44BE; Wed, 18 May 2022 06:00:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2AED161770; Wed, 18 May 2022 13:00:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 87694C34117; Wed, 18 May 2022 13:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652878811; bh=jV0UE4C0jzdCV5m7lxDB5yRcAJgyYyREBVZUK8Fu95g=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=NB3cjU0V9Hb4m8mqwu969TTrs5SMIsx090peKIyan3upbns4BgzjPTQLOzcUCxCDa w3Nt1EOlOr40Fs9l5CwdvADRqbOhQIB71dMWXAEhN1cQ49kfPM/TAs4jJwI4ZBbfYG Qxif6dlBivnFLlog1n3+ipw8ec8S3RJHRgrF1lgfv3Iupr1B/SXW0GVIyySA06JKeQ rrpe307JcxKvH40yin5xv6YOE5gymqXHUxisDxVzIgPOGGEAmSZvnqtpw5aa7X1TJt xmYxl2TDDVM9So7m2qqA0bwyEVHPB0SiWvPxxtkYkDQFpOx8JqpT9zLwfEiQE8kLvP 806OPfToNGlHg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 6EB49F0383D; Wed, 18 May 2022 13:00:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v0] nfc: pn533: Fix buggy cleanup order From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165287881144.21214.2658320019255160778.git-patchwork-notify@kernel.org> Date: Wed, 18 May 2022 13:00:11 +0000 References: <20220518105321.32746-1-linma@zju.edu.cn> In-Reply-To: <20220518105321.32746-1-linma@zju.edu.cn> To: Lin Ma Cc: krzysztof.kozlowski@linaro.org, dan.carpenter@oracle.com, cyeaa@connect.ust.hk, rikard.falkeborn@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Wed, 18 May 2022 18:53:21 +0800 you wrote: > When removing the pn533 device (i2c or USB), there is a logic error. The > original code first cancels the worker (flush_delayed_work) and then > destroys the workqueue (destroy_workqueue), leaving the timer the last > one to be deleted (del_timer). This result in a possible race condition > in a multi-core preempt-able kernel. That is, if the cleanup > (pn53x_common_clean) is concurrently run with the timer handler > (pn533_listen_mode_timer), the timer can queue the poll_work to the > already destroyed workqueue, causing use-after-free. > > [...] Here is the summary with links: - [v0] nfc: pn533: Fix buggy cleanup order https://git.kernel.org/netdev/net/c/b8cedb7093b2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html