Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp490104iob; Wed, 18 May 2022 06:40:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkFO+KlnRWZ6DyrrTy2gn5PHUqIZiHd+LuTU/YY2D0Y3R6mpZV6DarqYJsyNlvZ36fxgLV X-Received: by 2002:a05:6a00:1acf:b0:50e:1872:c6b1 with SMTP id f15-20020a056a001acf00b0050e1872c6b1mr27464690pfv.76.1652881227881; Wed, 18 May 2022 06:40:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652881227; cv=none; d=google.com; s=arc-20160816; b=q8kFaIHfCOWWrSwXwRVnHU112cd2srZeXSwBeScsJsWRjckLsSYL6zEOJZtK2958E9 yWUySkZdO8CNKW9abKNLkHjocCaA475+vA9zJ+7feG5GhHeg4VakteOJh+JJ6G7RaENO Kf0a0auWk3wiQPxZgSVC6mk7Frvotm/cTL4EaH6N9VmvnqbFj3o/w7kowwqkFDlx5fOQ nyYN5VDBLtWQQISnqNHji64Rw2c4Q9nBRuTlYaBgv+l78VrgGpnrqlJ9dNnxERx0hDCX CQf3OfRHA031oPdQ+THcOK7XmvnSC734krdmDPaMi+qKUAuxDADXk7Bg2sfU9gew2IYW HAxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BhJrvJLn+TzZ+Q8hiTJgSRsblqOxOpTfmvIr/hnkxcU=; b=szqeUqnqDdWRTuXUiCS+Rz6++XHF1tZFDj6K7NJ/+9p5qKT3iBLMmV7zFFvD2Eh98A j9GSbjJb3fGpOJ4Cg/647PHhnHn+D5cOBN3JpUW/swQQrgJ9mpM7bwh9IpuSaLQjn5eo qj7m/oF90uN70RjAIY2JLJOJGhVyjvQFLFNnpNei699IUbI3SvAk71c2sf0wtsIxE5c6 uTOj98EYihbSJXOnktlxUdWr8guleqqJaxnU2cGHBOUuDlsPmDHRAZiCbPf/2/oE215G 7uOcS9g/OxHl8LpXQBdHvRRPJN1az7r35FAXhDpcPgc7rxYaaeoFnJbyqyDdLrfgMJMw i1kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Fr1wEjHL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id x10-20020a63aa4a000000b003990b9576f5si2457513pgo.425.2022.05.18.06.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 06:40:27 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Fr1wEjHL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8DBA61AEC66; Wed, 18 May 2022 06:39:40 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238056AbiERNjd (ORCPT + 99 others); Wed, 18 May 2022 09:39:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238017AbiERNja (ORCPT ); Wed, 18 May 2022 09:39:30 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E09DF1A90E8 for ; Wed, 18 May 2022 06:39:27 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id t26so3730936ybt.3 for ; Wed, 18 May 2022 06:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BhJrvJLn+TzZ+Q8hiTJgSRsblqOxOpTfmvIr/hnkxcU=; b=Fr1wEjHLVhbeaVjSnAq2+SspRoi/e2nHtCbxH9sSXmM6/3QABuwEX0A/Bsv0tflvx7 FeGLTj9FD2gkRu3GbCWe+exRmItXfmUcb0sSDSRZD4+ElF7Rf4cjjxqwhIJimVNkCdOk G7KCBSkOvXlptSJIcRhHWmc11F2GcHXFR8+qTkIwKJt/USalM5VXcDoAQc4okcJGsMmX F5Pa+wE7uyY0nr89lorDyjvaYa071njtprkgH39qA936CcpcVGNJZnYzLFsDlr8OMsAs J7/lUHeHwu2zSymb7v1cPfmgnmY1K97t0ftjofja2ovNQL1w63T81Iy1+EXOY2o6HKTK rwtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BhJrvJLn+TzZ+Q8hiTJgSRsblqOxOpTfmvIr/hnkxcU=; b=younRyEQ5RrA/M0Uaoa1FTDSsJDPummhtfuvXAqdgN0SqDkKzhr+Wet7SqKSChyixj Bo1F1vJJmkLM3Q/qC02cEhrrmxX9holuUqK85sWZYukXd6NvrxmoHx8Bhq+5SkC580VE hA2t34MUV/hepwSJCzbviZYHt0AYke8/+7+G4aAhTRcv5+yg4mbHRteW9Pr/7yia5082 OWsijVqaT6HIYKATatRmHgaGaUWwDu1lCnK1WkT6TihUZO/ht8fl0zp/OU1yOV1wQheX uNMA49A4LUh6JmgeCNJcIciIpg3UxRRH+//8QK4jtGzBNJRXmnTKYM4anVu90ttFPEyp dvyA== X-Gm-Message-State: AOAM531iFgZ3dOXB17rox8DZP2fJelsAgo7BA6IpzVn9vmodNUxda6Un 8iwvJOU22fasI1Ir421I9kqU2PeX4cT1emz4iUf8hA== X-Received: by 2002:a05:6902:526:b0:64d:b6ab:f91d with SMTP id y6-20020a056902052600b0064db6abf91dmr14325832ybs.295.1652881167023; Wed, 18 May 2022 06:39:27 -0700 (PDT) MIME-Version: 1.0 References: <20220518062537.17933-1-hbh25y@gmail.com> In-Reply-To: <20220518062537.17933-1-hbh25y@gmail.com> From: Linus Walleij Date: Wed, 18 May 2022 15:39:14 +0200 Message-ID: Subject: Re: [PATCH] clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base() To: Hangyu Hua Cc: ulf.hansson@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 8:25 AM Hangyu Hua wrote: > Off-by-one will happen when index == ARRAY_SIZE(ur->base). > > Fixes: b14cbdfd467d ("clk: ux500: Add driver for the reset portions of PRCC") > Signed-off-by: Hangyu Hua Good catch! Reviewed-by: Linus Walleij Yours, Linus Walleij