Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp496942iob; Wed, 18 May 2022 06:49:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTyGSEHNLgV+PjD8GsuQoOCo3hzzvyjJTfSpo8GI0vjaXkVYnDCCR+rrumVpLboakXIckx X-Received: by 2002:a63:e348:0:b0:3db:7729:c0fe with SMTP id o8-20020a63e348000000b003db7729c0femr23924752pgj.482.1652881766739; Wed, 18 May 2022 06:49:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652881766; cv=none; d=google.com; s=arc-20160816; b=NDIGnLspim5O2G7ghTrYPTpbx1b7rBvEpQWvjWsB4PPioZaHvp7pvOtaswLCZ2e28H 6mypTFuyRtMLXlLP+WKnY5TR269BBFONXtBnYbE0i9tT9E8gCuIjuXp/qhbDunNYvk+p FRq+p123GhxW50TB5BcIz+jUSCO72sJWzmxJDERiE17/mzlo8p/HtegTUzWDI8fFzHHV YHD7ZWxgWfXbhn9I4FNOIkivqKTtFUO+94UsZD+iqBGZLH25FMs9bCr/j2jeqN3Z+aoi vl2NgAW1ZkQdcUMByEhlSPSLHDSAZS+HpejoHXLubBTMHkQ+WMANBy/GoGO8ugdLVJor EVow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=/v+nztOH8pMiCldPuv2onTZr9sRDaO7ZE4i23WJ4K5o=; b=HNPuTaDellf/CMfJgJ0Z5BJpre4tD3krT1l/dhAA4U24iDTKa3AUE9tbtITIpIzz7w DSUwzNCJBXzdSAvnglPrEOw95VycFjbb0fit598yqbYdwHFNCf4N+nGyFc/ydO7FaSH4 VfsdYxecoyug56TvZTC7+jP5Iql6zzj7Kf6dEzYSZ135YWv+Lzgl8Y/r+ufncwItwkA0 778y4h52atS/fMWdVuH7JFoPBQbDdtnVnZjPIr0pWTpVAvNFIEkKPHR949PQVL0ONqJF A0kZPN7KMvHgHnirggnCNm4sz2L0WAf7/DXmNeNj4B5MvBtGwt3xCa5cE73v//YYYcX5 UADg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=jJqGPkOU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y21-20020a631815000000b003816043efcdsi2663126pgl.450.2022.05.18.06.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 06:49:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=jJqGPkOU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ACC061A6ACB; Wed, 18 May 2022 06:46:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238157AbiERNpt (ORCPT + 99 others); Wed, 18 May 2022 09:45:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238078AbiERNpp (ORCPT ); Wed, 18 May 2022 09:45:45 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FE80C7B for ; Wed, 18 May 2022 06:45:44 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24I5xw9k005166; Wed, 18 May 2022 08:45:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=/v+nztOH8pMiCldPuv2onTZr9sRDaO7ZE4i23WJ4K5o=; b=jJqGPkOUdeC/L4ZyYUnC6X9sEc6RTnXH/TCZUrzLpo10aLccXsSaQ5Gh7PWNyyTk9an4 mLFfI6Vm4S1nGIDnnCnH+5UfcP+yZ0M+OXu35f4oFe99XWmmdA2m1TYIO9Wx4oc48EyB E+PwooMR8Mw9YVvGtUcQdWFGmlqCFOio1JhIexHAnTWUQh8EC5H4uIW/xePkvXF3R2UE nJJW++M+txPsTxeHfikhosSeWl01oawvw19rL8GgnKy+2+eUVrLrA17lRGIVoyoYTWBl mSBZVGDyaPatwAoYd1iH4vZ3o4JuSn+J0G5JKkT21y6DDAg9BvWVP7kNuIlACTq+NUGC Rg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3g28updkk6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 18 May 2022 08:45:17 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 18 May 2022 14:45:15 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 18 May 2022 14:45:15 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 94983B16; Wed, 18 May 2022 13:45:15 +0000 (UTC) Date: Wed, 18 May 2022 13:45:15 +0000 From: Charles Keepax To: Yang Yingliang CC: , , , Subject: Re: [PATCH -next] ASoC: wm2000: fix missing clk_disable_unprepare() on error in wm2000_anc_transition() Message-ID: <20220518134515.GJ38351@ediswmail.ad.cirrus.com> References: <20220514091053.686416-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220514091053.686416-1-yangyingliang@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: F0-9IuOAChH6CS56puNXd2LLsGwWYKkN X-Proofpoint-ORIG-GUID: F0-9IuOAChH6CS56puNXd2LLsGwWYKkN X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 14, 2022 at 05:10:53PM +0800, Yang Yingliang wrote: > Fix the missing clk_disable_unprepare() before return > from wm2000_anc_transition() in the error handling case. > > Fixes: 514cfd6dd725 ("ASoC: wm2000: Integrate with clock API") > Signed-off-by: Yang Yingliang > --- Acked-by: Charles Keepax Thanks, Charles