Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <9e6761899e81c8b7d91091403b5aab6e628e605a.camel@kernel.org>
Subject: Re: [PATCH] ceph: remove redundant variable ino
From:   Jeff Layton <jlayton@kernel.org>
To:     Colin Ian King <colin.i.king@gmail.com>,
        Xiubo Li <xiubli@redhat.com>,
        Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 18 May 2022 10:08:57 -0400
In-Reply-To: <20220518085508.509104-1-colin.i.king@gmail.com>
References: <20220518085508.509104-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2022-05-18 at 09:55 +0100, Colin Ian King wrote:
> Variable ino is being assigned a value that is never read. The variable
> and assignment are redundant, remove it.
>=20
> Cleans up clang scan build warning:
> warning: Although the value stored to 'ino' is used in the enclosing
> expression, the value is never actually read from 'ino'
> [deadcode.DeadStores]
>=20
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  fs/ceph/mds_client.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 00c3de177dd6..20197f05faec 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -437,7 +437,7 @@ static int ceph_parse_deleg_inos(void **p, void *end,
>  	ceph_decode_32_safe(p, end, sets, bad);
>  	dout("got %u sets of delegated inodes\n", sets);
>  	while (sets--) {
> -		u64 start, len, ino;
> +		u64 start, len;
> =20
>  		ceph_decode_64_safe(p, end, start, bad);
>  		ceph_decode_64_safe(p, end, len, bad);
> @@ -449,7 +449,7 @@ static int ceph_parse_deleg_inos(void **p, void *end,
>  			continue;
>  		}
>  		while (len--) {
> -			int err =3D xa_insert(&s->s_delegated_inos, ino =3D start++,
> +			int err =3D xa_insert(&s->s_delegated_inos, start++,
>  					    DELEGATED_INO_AVAILABLE,
>  					    GFP_KERNEL);
>  			if (!err) {

Reviewed-by: Jeff Layton <jlayton@kernel.org>