Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 14:51:57 +0000
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     ChenXiaoSong <chenxiaosong2@huawei.com>
Cc:     miklos@szeredi.hu, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, liuyongqiang13@huawei.com,
        yi.zhang@huawei.com, zhangxiaoxu5@huawei.com
Subject: Re: [PATCH -next] fuse: return the more nuanced writeback error on
 close()
Message-ID: <YoUIDcOmfJ5lppu3@zeniv-ca.linux.org.uk>
References: <20220518145729.2488102-1-chenxiaosong2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220518145729.2488102-1-chenxiaosong2@huawei.com>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote:

> +	/* return more nuanced writeback errors */
>  	if (err)
> -		return err;
> +		return filemap_check_wb_err(file->f_mapping, 0);
>  
>  	err = 0;

As an aside, what the hell is that err = 0 about?  Before or after
that patch, that is - "let's make err zero, in case it had somehow
magically changed ceased to be so since if (err) bugger_off just above"?