Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <372364b33b8d4b93908c3822e18f7d295de2ede9.camel@kernel.org>
Subject: Re: [PATCH 20/21] context_tracking: Convert state to atomic_t
From:   nicolas saenz julienne <nsaenz@kernel.org>
To:     Frederic Weisbecker <frederic@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Phil Auld <pauld@redhat.com>,
        Alex Belits <abelits@marvell.com>,
        Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Yu Liao <liaoyu15@huawei.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Uladzislau Rezki <uladzislau.rezki@sony.com>,
        Joel Fernandes <joel@joelfernandes.org>
Date:   Wed, 18 May 2022 17:09:55 +0200
In-Reply-To: <20220503100051.2799723-21-frederic@kernel.org>
References: <20220503100051.2799723-1-frederic@kernel.org>
         <20220503100051.2799723-21-frederic@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-05-03 at 12:00 +0200, Frederic Weisbecker wrote:

[...]

> +/**
> + * ct_state() - return the current context tracking state if known
> + *
> + * Returns the current cpu's context tracking state if context tracking
> + * is enabled.  If context tracking is disabled, returns
> + * CONTEXT_DISABLED.  This should be used primarily for debugging.
> + */
> +static __always_inline int ct_state(void)
> +{
> +	int ret;
> +
> +	if (!context_tracking_enabled())
> +		return CONTEXT_DISABLED;
> +
> +	preempt_disable();
> +	ret =3D __ct_state();
> +	preempt_enable();
> +
> +	return ret;
> +}
> +

I can't see any use for this function with preemption enabled. You can't tr=
ust
the data due to CPU migration and it could be a source of bugs in the futur=
e.
Wouldn't it make more sense to move the burden into the callers? They all D=
TRT,
plus, this_cpu_ptr() will spew warnings if someone shows up and doesn't com=
ply.

Regards,

--=20
Nicol=C3=A1s S=C3=A1enz