Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <adf7fca9aab320abc7a0c364b3e99709e0d99548.camel@kernel.org>
Subject: Re: [PATCH 21/21] rcu/context_tracking: Merge dynticks counter and
 context tracking states
From:   nicolas saenz julienne <nsaenz@kernel.org>
To:     Frederic Weisbecker <frederic@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Phil Auld <pauld@redhat.com>,
        Alex Belits <abelits@marvell.com>,
        Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Yu Liao <liaoyu15@huawei.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Uladzislau Rezki <uladzislau.rezki@sony.com>,
        Joel Fernandes <joel@joelfernandes.org>
Date:   Wed, 18 May 2022 17:31:32 +0200
In-Reply-To: <20220503100051.2799723-22-frederic@kernel.org>
References: <20220503100051.2799723-1-frederic@kernel.org>
         <20220503100051.2799723-22-frederic@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-05-03 at 12:00 +0200, Frederic Weisbecker wrote:

[...]

> diff --git a/include/linux/context_tracking_state.h b/include/linux/conte=
xt_tracking_state.h
> index edd9f8f5b753..0841435620cf 100644
> --- a/include/linux/context_tracking_state.h
> +++ b/include/linux/context_tracking_state.h
> @@ -10,12 +10,20 @@
>  #define DYNTICK_IRQ_NONIDLE	((LONG_MAX / 2) + 1)
> =20
>  enum ctx_state {
> -	CONTEXT_DISABLED =3D -1,	/* returned by ct_state() if unknown */
> -	CONTEXT_KERNEL =3D 0,
> -	CONTEXT_USER,
> -	CONTEXT_GUEST,
> +	CONTEXT_DISABLED	=3D -1,	/* returned by ct_state() if unknown */
> +	CONTEXT_KERNEL		=3D 0,
> +	CONTEXT_IDLE		=3D 1,
> +	CONTEXT_USER		=3D 2,
> +	CONTEXT_GUEST		=3D 3,
> +	CONTEXT_MAX		=3D 4,
>  };
> =20
> +/* Even value for idle, else odd. */
> +#define RCU_DYNTICKS_IDX CONTEXT_MAX
> +
> +#define CT_STATE_MASK (CONTEXT_MAX - 1)
> +#define CT_DYNTICKS_MASK (~CT_STATE_MASK)

Nit: These macros only work as long as we don't introduce new contexts. It'=
s
maybe worth a comment.

Regards,

--=20
Nicol=C3=A1s S=C3=A1enz