Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 08:33:44 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Guo Zhengkui <guozhengkui@vivo.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Colin Ian King <colin.king@intel.com>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        zhengkui_guo@outlook.com
Subject: Re: [PATCH linux-next] net: smc911x: replace ternary operator with
 min()
Message-ID: <20220518083344.0886bd6f@kernel.org>
In-Reply-To: <CAMuHMdWH1rdP22VnhR_h601tm+DDo7+sGdXR-6NQx0B-jGoZ1A@mail.gmail.com>
References: <20220516115627.66363-1-guozhengkui@vivo.com>
        <CAMuHMdWH1rdP22VnhR_h601tm+DDo7+sGdXR-6NQx0B-jGoZ1A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 18 May 2022 11:07:08 +0200 Geert Uytterhoeven wrote:
> On Mon, May 16, 2022 at 10:36 PM Guo Zhengkui <guozhengkui@vivo.com> wrot=
e:
> > Fix the following coccicheck warning:
> >
> > drivers/net/ethernet/smsc/smc911x.c:483:20-22: WARNING opportunity for =
min()
> >
> > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> =20
>=20
> Thanks for your patch, which is now commit 5ff0348b7f755aac ("net:
> smc911x: replace ternary operator with min()") in net-next/master.
>=20
> > --- a/drivers/net/ethernet/smsc/smc911x.c
> > +++ b/drivers/net/ethernet/smsc/smc911x.c
> > @@ -480,7 +480,7 @@ static void smc911x_hardware_send_pkt(struct net_de=
vice *dev)
> >         SMC_SET_TX_FIFO(lp, cmdB);
> >
> >         DBG(SMC_DEBUG_PKTS, dev, "Transmitted packet\n");
> > -       PRINT_PKT(buf, len <=3D 64 ? len : 64);
> > +       PRINT_PKT(buf, min(len, 64)); =20
>=20
> Unfortunately you forgot to test-compile this with
> ENABLE_SMC_DEBUG_PKTS=3D1, which triggers:
>=20
>         drivers/net/ethernet/smsc/smc911x.c: In function
> =E2=80=98smc911x_hardware_send_pkt=E2=80=99:
>         include/linux/minmax.h:20:28: error: comparison of distinct
> pointer types lacks a cast [-Werror]
>            20 |  (!!(sizeof((typeof(x) *)1 =3D=3D (typeof(y) *)1)))
>               |                            ^~
>         drivers/net/ethernet/smsc/smc911x.c:483:17: note: in expansion
> of macro =E2=80=98min=E2=80=99
>           483 |  PRINT_PKT(buf, min(len, 64));
>=20
> "len" is "unsigned int", while "64" is "(signed) int".

Ah, damn. I did double check that the build test actually compiles
smc911x.o 'cause this patch looked suspicious. Didn't realize that
more than allmodconfig is needed to trigger this :/

How do you enable ENABLE_SMC_DEBUG_PKTS? You edit the source?

> I have sent a fix
> https://lore.kernel.org/r/ca032d4122fc70d3a56a524e5944a8eff9a329e8.165286=
4652.git.geert+renesas@glider.be/

Thanks a lot!