Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <2da64be9-6cf3-199f-27af-597b6283d724@intel.com>
Date:   Wed, 18 May 2022 09:06:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.9.0
Subject: Re: [PATCH v4 07/21] x86/resctrl: Create mba_sc configuration in the
 rdt_domain
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
        <tan.shaopeng@fujitsu.com>, Jamie Iles <quic_jiles@quicinc.com>,
        Cristian Marussi <cristian.marussi@arm.com>,
        "Xin Hao" <xhao@linux.alibaba.com>, <xingxin.hx@openanolis.org>,
        <baolin.wang@linux.alibaba.com>
References: <20220412124419.30689-1-james.morse@arm.com>
 <20220412124419.30689-8-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220412124419.30689-8-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHNVMkJMdFVrbDUvWnFXZjMrc3U3elZBZTJ2Q2p6cnBkRmQzbEFsSjlqZWEy?=
 =?utf-8?B?aHh1UWFpMndDWUdJbFRzR2JwOGNkNFZoeWwzNTkrZnFqanpTWDdETUE4RzJE?=
 =?utf-8?B?UHdZQmRscjBpNm5WVVl5R3JjREhBVFlIYUE5MUhNUFJiWitFT3lnblplMnVx?=
 =?utf-8?B?M0Q1Z1dCNkZVWTFuWGpKNHVEUGZKSnMvTHhaMG9ZaEF1aTA4YmZ3UyszcFl2?=
 =?utf-8?B?dDBSVDlNbWEvNXJmYUM0ZmpZUHR5Ums4VlRvMEIycFhsTStIWGt1bVlTTExn?=
 =?utf-8?B?Ryt5YW9pR1V5YjYyVnViRUZaMnJzSk5FZDJnN2tQQm53MHdod0dQN25DdVRF?=
 =?utf-8?B?Q3RJaDQvK3FmMUdjc1EzTnJ3YWpTL3FUeFZSY0I5dEo5dTVyZDB1LzRKRzNq?=
 =?utf-8?B?QVdPblNTWmFET1RMa2YzTnlOYlNwNW9SRmlQVjd0Z2dJNVM0RVllVlNtRS9H?=
 =?utf-8?B?aDRJWUg0L3k4RldvbUV6eDRLNkU3TEVPNElnRGE1U2Q4aXdYcm1lTTVrQzBH?=
 =?utf-8?B?MXFSN2hQeTdMUDdzaExrQU05M1U4clh3b0lXNG8waHJPN2JYZy9hZVp0cjNt?=
 =?utf-8?B?c1ViaEEzME95cXI4d1NuM3ZzRERZa2xQanFtekRhZStBek03aDRiR2d4QUZk?=
 =?utf-8?B?MWc3RUtuTzg1dmdwdGhRbElpVm5SZGRPNjBsdmN1NWE1T3QxMW9IYmJma24r?=
 =?utf-8?B?THhSWXZzandhZmMxUXhSR1JtOFBiNCtUT21oZXZaZ0xXanppR081eUV2emcw?=
 =?utf-8?B?dlFTbzFhUmRxaXA3dkFkUk94dmQ2WUl1WnpNWXRBMGFRMGsyWjZDZGw3ZVB4?=
 =?utf-8?B?dWdURW15V3A3R0RXQWJybEx1NlB4K3Q2YzFLcmkyOXB3VW9udDNISnVOZ2tk?=
 =?utf-8?B?eWN1cDdKS3ZubnV1a1R3R3JmVmNPT0hjWG1TcGlaZHFJSHdiU1lWRkRaS3dW?=
 =?utf-8?B?MTRuM1FKbXVRVmNseTFzVkFmblZOSzN6UGIzaTJKdnc1Q3U3TzlCR3VNeXNT?=
 =?utf-8?B?WitkSmdkYjFkeEdmT2srOE5UUFN4KzZibk1JK2NEcEYvTFp6SkY1ZW1NR2JL?=
 =?utf-8?B?ZVdCblpQZmJBVHBUTEpldDlCclZueXB5MDVNLy9iQXJBaGFzSkxSbmpMNDBF?=
 =?utf-8?B?S1JtQlBSeS8rcVpkSEl6aUpXdlVRY0t2SDJUN0RSNDEzQUdmTklYN0dlZDFk?=
 =?utf-8?B?cnhQWldhZlZHQ3RRY0xwZVM3bnkvYmc5RWQwOWlDazRvU0hsUzFmcU1ocEZi?=
 =?utf-8?B?ek4wU0dFYkdSQzh2Q0lNQitwemR4MTZSNUJ1dFhCNUxobjhYc3N2clhMWDZJ?=
 =?utf-8?B?azJmdkpaU0Zyb29LZmg0am5uRlBqZ1QrcnJieDByZ2VEczZZVVpHV0RvM1RD?=
 =?utf-8?B?VFRUYTkraDdaeFJleExvQW9kdC9nRTlRSWdkTFNRZHR6UWhUUHlXd1lPRm5W?=
 =?utf-8?B?NGdHUzVXL1did3E3V3ZjMFQwa0tONjRyVzFhL1daNm1KODZ3SjZlSFBrNVhi?=
 =?utf-8?B?SmxqcUVDUjhjdTVYZEJyVU51YUZ0MEU4S1lPOTBvWlRXemVHWEZpRXp3VmZB?=
 =?utf-8?B?SEdWU0xRQUpzQzRRU0E4TnRWNFo4MDQ4WnF3VkV6a1hZaWJGRGFrQ3U1QVBw?=
 =?utf-8?B?YW9ObnU2THVRb2FraDVhVXMyU28rd211WG9jZG9McUdxcy9iaWJRNHdESStV?=
 =?utf-8?B?SUtCdHAzMnFyN2NlNTFqUUgyS3g5U1djKzVtUThueTBiU1hjV3NvTll3aEVM?=
 =?utf-8?B?eFY3V3hPaDNtYTdvREJXZEhpQzNMOUk4WEo2MllsY2IvSXZHWDVkK3B2Wmlq?=
 =?utf-8?B?Umdid1VhZitZcTFhUEh6SkVMQS81N2lNcXdyNDB6MDE5d2NHblJYbEp0WUJx?=
 =?utf-8?B?aUZlWVgrSk1VWHlCVXVKQ0tBRjB1d1lTTnA4dmI1SnB4N1p3WXFIR0JKUm1u?=
 =?utf-8?B?RmRmOCtrTnFDT1BWRzdTZit3amwyMFJsYXFka3BHbWhIWVNWVUpBbFppVXRr?=
 =?utf-8?B?TGtGUUcreFY2K0pXdWtTSjRQZ3BvdUNIVGkwbytrZXdicWhUTEtXdkNINS9Q?=
 =?utf-8?B?WUlKbUczaUw3aFRweXlBalA4MVVXc09rVE9hTS9Qek53YnArWTVZa2Nld3A4?=
 =?utf-8?B?ODk4VWt4TXlzQ2N3THNZaUpzSGhpaUR3ZkdncDVVUHRnSU1yL29wNmhxb2ND?=
 =?utf-8?B?ZmtLZy8xZ0pHUmtJUXlGbjFGQ2poWVphU2VwNHBpOGxXeExndjFMSUZmTzEy?=
 =?utf-8?B?ZDZuQkl0L3pLRmE0UlBNbGdLVXhNV21OQUNlM2R5MVFJOUZ4YTJibnZzZzRU?=
 =?utf-8?B?cjRTbWlZRU9KcEhXWkh1b0RaazYrK0lIb2RmeDRqRlZ6amRuVVVHNmRENEtY?=
 =?utf-8?Q?Mr2sFsAXALLPPwlw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 221ee7b5-7fe2-4fa9-b288-08da38e857c4
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 16:06:18.6186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 906BtlrcDHD1DKntHed8SQMTN1EKUILAUReCCc1OFOlrqbfE6GovmxB9fqGN9JmPo0RyvChwTH8kDJNyOPln/OM4/X4vP/U2tt8n9uH5MjY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4229
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 4/12/2022 5:44 AM, James Morse wrote:
..

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 5d283bdd6162..46ab9fb5562e 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -15,6 +15,9 @@ int proc_resctrl_show(struct seq_file *m,
>  
>  #endif
>  
> +/* max value for struct rdt_domain's mbps_val */
> +#define MBA_MAX_MBPS   U32_MAX
> +
>  /**
>   * enum resctrl_conf_type - The type of configuration.
>   * @CDP_NONE:	No prioritisation, both code and data are controlled or monitored.
> @@ -53,6 +56,9 @@ struct resctrl_staged_config {
>   * @cqm_work_cpu:	worker CPU for CQM h/w counters
>   * @plr:		pseudo-locked region (if any) associated with domain
>   * @staged_config:	parsed configuration to be applied
> + * @mbps_val:		When mba_sc is enabled, this holds the array of user
> + * 			specified control values for mba_sc in MBps, indexed
> + *			by closid
>   */
>  struct rdt_domain {
>  	struct list_head		list;

Please watch out for usage of spaces before tabs to ensure a clean pass
from checkpatch.pl.

Reinette