Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp626517iob; Wed, 18 May 2022 09:24:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGLVrADPzXBzwcpisZ+E551J27Ifg5Qs3fnpYGOJ++pzaTiVgNrw2c3UD4ok/D53awvymQ X-Received: by 2002:a17:902:a9c6:b0:15e:fe5d:cf67 with SMTP id b6-20020a170902a9c600b0015efe5dcf67mr483948plr.74.1652891060378; Wed, 18 May 2022 09:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652891060; cv=none; d=google.com; s=arc-20160816; b=x8X9FmjIvHKe1iUa0OM3Xf6dJhkaJ3D9bGw9pVCilXGPm49ON9Ar3YXHAaoajVPBjo v4ZRX/5BPsgaZ/4HiehwzT7jpDuWv+//l01gtrfd3fEZMXulOeCWo4yBc4/DaY1kJOPF z4hBt7tgG5l/hYwezsZqV55pWUZzmeou8nh8e1JFgqkaYBj4cTfeS3ZQWcZUVsFkgAtg GH7NsCwuMq1XCajtCLPmkXJkp5RNPyvyYR5TVM1DGkZR7eQSErnHTC6jPoYwuT9OiLBj juulXMYXx5TKB6LGMLYK+vdr09pWFSMSo9eDmK1tPvYbeV8S+M8RGA5hAaIiqeIHlUYQ uwoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=6/Upy6FSxYUWe3lFya0BVajvZHr/A/mp+/5xO6NiSNo=; b=t0/F5xn4DRW0HxR+vJI+Jmpu0TQON7qfu2o1LPAvnERL6hWKoF81/FHTaAV+w00wRF d58bukrg2zzW/AhWEKK2M4ib1T2JpgzDOy3wLbrZZdfmB1IBPPGx+imYht152P5tPGyU Frdp76iX2SdQFDxM7VhJ4FAV0ZSmXQUPEc2NoO2N0VhBLRhXGoXQvFoEKHrGa2jGbKB7 Bax+xpZcsYUldfixK798FvWcXVXfBQImIpWL83NAweqtPeriWrRFhPWvWU5CgaCKgin9 dE7sPjx6PnJRXpqkyQswrglcR2oq4I23XXjkhPSdmH3qSWJIjLWvUhnYU6MFzMEWPnVt P8SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NFQ+exhb; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i6-20020a17090332c600b00153b2d1653asi3544289plr.322.2022.05.18.09.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 09:24:20 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NFQ+exhb; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 53DEB1F0DE9; Wed, 18 May 2022 09:23:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239398AbiERQXf (ORCPT + 99 others); Wed, 18 May 2022 12:23:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240055AbiERQXc (ORCPT ); Wed, 18 May 2022 12:23:32 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CAC61F0DD0; Wed, 18 May 2022 09:23:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B73CCCE21AE; Wed, 18 May 2022 16:23:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1BC8C385A5; Wed, 18 May 2022 16:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652891008; bh=/Ybk8m/djEMtyRg29QUVApIAfaXZyYituDCyvsrcOSs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NFQ+exhbR9/ckJbmbOvrhE4sjaipQ8eRQVN/x+S8c/N7YcpukYSzQ8zQwQJx9Mwev IOTW+i6P0xhBAB/u6VC+iCFBmRW/5JpyCasNizrtF7Va4apZrjYs5LS1yk2vQAUcwF pYqPcZe0Slosj4KOkzD3jOHYJFZD5MZcVEGP3M0GHLsU4OzesBaFFbZEVKLh23RlbG b00NPjYw82md/E0r2KJhJNfLgRnb6B+QtKHbr+AhBZs0coU5IPX9u559beAdPUmoq8 wc1jN8dPNyAmzGrzG8R7Qxc6u45pI79Dxfxvh2vP9isa1Am27QOaxHTnxj9eqchnVw YurqJA4gd8oeA== Date: Wed, 18 May 2022 09:23:26 -0700 From: Jakub Kicinski To: Carlos Fernandez Cc: pabeni@redhat.com, carlos.fernandez@technica-engineering.de, davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] Retrieve MACSec-XPN attributes before offloading Message-ID: <20220518092326.52183e77@kernel.org> In-Reply-To: <20220518090151.7601-1-carlos.fernandez@technica-engineering.de> References: <20220518085745.7022-1-carlos.fernandez@technica-engineering.de> <20220518090151.7601-1-carlos.fernandez@technica-engineering.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 May 2022 11:01:51 +0200 Carlos Fernandez wrote: > When MACsec offloading is used with XPN, before mdo_add_rxsa > and mdo_add_txsa functions are called, the key salt is not > copied to the macsec context struct. Offloaded phys will need > this data when performing offloading. > > Fix by copying salt and id to context struct before calling the > offloading functions. > > Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites") > Signed-off-by: Carlos Fernandez Does not apply to net, please rebase.