Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ff0c9375-9e44-36fb-427e-37d53a6a7b98@quicinc.com>
Date:   Wed, 18 May 2022 22:15:40 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCHv14 5/9] lib: Add register read/write tracing support
Content-Language: en-US
From:   Sai Prakash Ranjan <quic_saipraka@quicinc.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     <arnd@arndb.de>, <catalin.marinas@arm.com>,
        <gregkh@linuxfoundation.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <maz@kernel.org>, <quic_psodagud@quicinc.com>,
        <quic_tsoni@quicinc.com>, <will@kernel.org>,
        Prasad Sodagudi <psodagud@codeaurora.org>
References: <cover.1651663123.git.quic_saipraka@quicinc.com>
 <9827bae40f6f319f294d06859c9e3c7442f067f2.1651663123.git.quic_saipraka@quicinc.com>
 <20220518100721.18fb5876@gandalf.local.home>
 <c696ebfc-9a2a-7b12-7297-3be8a31a82d3@quicinc.com>
In-Reply-To: <c696ebfc-9a2a-7b12-7297-3be8a31a82d3@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/18/2022 8:48 PM, Sai Prakash Ranjan wrote:
> Hi Steve,
>
> On 5/18/2022 7:37 PM, Steven Rostedt wrote:
>>> +        (void *)(unsigned long)__entry->caller, __entry->width,
>> __entry->caller is already defined as "unsigned long", why the extra
>> typecast?
>
> I remember seeing compilation errors without this change in early versions of
> the series. Let me check this again.
>
>

No warnings or errors without this extra cast, yay. New version posted.

Thanks,
Sai