Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756828AbXENVVr (ORCPT ); Mon, 14 May 2007 17:21:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752336AbXENVVl (ORCPT ); Mon, 14 May 2007 17:21:41 -0400 Received: from smtp1.linux-foundation.org ([65.172.181.25]:40626 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbXENVVk (ORCPT ); Mon, 14 May 2007 17:21:40 -0400 Date: Mon, 14 May 2007 14:21:25 -0700 From: Andrew Morton To: Vitaly Bordug Cc: linux-pcmcia@lists.infradead.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support Message-Id: <20070514142125.851f3d10.akpm@linux-foundation.org> In-Reply-To: <20070508223123.3633.72309.stgit@localhost.localdomain> References: <20070508222748.3633.37120.stgit@localhost.localdomain> <20070508223123.3633.72309.stgit@localhost.localdomain> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 20 On Wed, 09 May 2007 02:31:25 +0400 Vitaly Bordug wrote: > +/* > + * Some internal interrupt registers use an 8-bit mask for the interrupt > + * level instead of a number. > + */ > +static inline uint mk_int_int_mask(uint mask) { > + return (1 << (7 - (mask/2))); > +} grumble. "uint" isn't a favoured "type". Please prefer to use "unsigned int" if that's what is meant. Or maybe u32, if that's more appropriate - and it probably is, as we're dealing with device registers here. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/