Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 11:08:25 -0700
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Mikulas Patocka <mpatocka@redhat.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] objtool: fix objtool regression on x32 systems
Message-ID: <20220518180825.k4pvac42dlfdgdkd@treble>
References: <alpine.LRH.2.02.2205161041260.11556@file01.intranet.prod.int.rdu2.redhat.com>
 <YoJwtCeVzYUm6Uhg@hirez.programming.kicks-ass.net>
 <alpine.LRH.2.02.2205161145070.30905@file01.intranet.prod.int.rdu2.redhat.com>
 <20220516212517.GP76023@worktop.programming.kicks-ass.net>
 <alpine.LRH.2.02.2205180813200.22292@file01.intranet.prod.int.rdu2.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.LRH.2.02.2205180813200.22292@file01.intranet.prod.int.rdu2.redhat.com>
Precedence: bulk

On Wed, May 18, 2022 at 09:28:57AM -0400, Mikulas Patocka wrote:
> 
> 
> On Mon, 16 May 2022, Peter Zijlstra wrote:
> 
> > On Mon, May 16, 2022 at 11:56:21AM -0400, Mikulas Patocka wrote:
> > > 
> > > With this patch, the compiled kernel works. With kernels 5.17 or older, it 
> > > also works. I bisected it and the breakage is caused by the commit 
> > > 4abff6d48dbc.
> > 
> > Sure; but it works doesn't mean there aren't more latent issues. ILP32
> > hosted (cross) builds just aren't a thing I've ever considered. If we
> > really want to go support that then we should at least audit the whole
> > thing.
> > 
> > A quick look seems to suggest at least all the 'offset' fields should be
> > u64 or something. The only reason that works is because -mcmodel=kernel
> > keeps everything in the 2G range to make s32 immediates work. But it
> > isn't right.
> 
> There are many 'offset' variables and its hard to determine which should 
> be 64-bit. Would it be possible to commit this patch, so that kernel 5.18 
> can be compiled on x32 distributions? And you can do code refactoring in 
> the next merge window.

I believe Peter is going ahead with merging this for 5.18, and your v2
looks identical to what he already has here:

  https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=objtool/urgent

-- 
Josh